IMPROVEMENT: reuse pytest job artifacts by using workflow_run

Author: amilcarlucas

.github/workflows/codecov.yml

@@ -1,51 +1,30 @@
 name: Coverage
 # Make sure pull requests increase coverage monotonically
 
-on: [pull_request]
+on:
+  pull_request:
 
 jobs:
-  build:
+  pytests:
+    uses: ./.github/workflows/pytest.yml  # use the callable pytest.yml workflow to run tests
 
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        # os: [ubuntu-latest, macos-latest, windows-latest]
-        # python-version: ["3.9", "3.10", "3.11", "3.12", "pypy3.9", "pypy3.10"]
-        os: [ubuntu-latest]
-        python-version: ["3.12"]
+  add_coverage_to_pullrequest:
+    runs-on: ubuntu-latest
+    needs: pytests
 
     steps:
-      - name: Checkout
+      - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+      - name: Download coverage report
+        uses: actions/download-artifact@v4
         with:
-          python-version: ${{ matrix.python-version }}
-
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip setuptools wheel
-          python -m pip install -U pymavlink pytest pytest-cov coverage mock
-          pip install build
-          pip install -U .
-
-      - name: Install apt packages
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y xvfb
-
-      - name: Test with unittest
-        run: |
-          export DISPLAY=:99
-          Xvfb :99 -screen 0 1024x768x16 &
-          coverage run -m pytest
-          coverage xml -o tests/coverage.xml
+          name: coverage-report-3.9
 
       - name: Get Cover
         uses: andraghetti/coverage@v3.2
         with:
-            coverageFile: tests/coverage.xml
+            coverageFile: coverage-3.9.xml
             token: ${{ secrets.GITHUB_TOKEN }}
         # Use always() to always run this step to publish test results when there are test failures
         if: ${{ always() }}

.github/workflows/coverage.yml

@@ -3,6 +3,7 @@ name: Pytest
 # https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#packaging-workflow-data-as-artifacts
 
 on:
+  pull_request:
   push:
     paths:
       - '**/*.py'        # Watch for changes in any Python files
@@ -47,7 +48,6 @@ jobs:
           export DISPLAY=:99
           Xvfb :99 -screen 0 1024x768x16 &
           pytest --cov=ardupilot_methodic_configurator --cov-report=xml:tests/coverage-${{ matrix.python-version }}.xml --md=tests/results-${{ matrix.python-version }}.md --cov-fail-under=42
-        continue-on-error: true
 
       - name: Display test results as github job summary
         run: cat tests/results-${{ matrix.python-version }}.md >> $GITHUB_STEP_SUMMARY
@@ -61,3 +61,26 @@ jobs:
             path: tests/coverage-${{ matrix.python-version }}.xml
         # Use always() to always run this step to publish test results when there are test failures
         if: ${{ always() }}
+
+  upload_coverage_to_codecov:
+    runs-on: ubuntu-latest
+    needs: pytest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Download coverage report
+        uses: actions/download-artifact@v4
+        with:
+          name: coverage-report-3.9
+
+      - name: Upload coverage report
+        uses: codecov/codecov-action@v5
+        with:
+          verbose: true
+          files: coverage-3.9.xml
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+
+      # TODO: create a badge that presents the result of the Upload coverage report step