fix(pylint): fix pylint issues

Author: amilcarlucas

ardupilot_methodic_configurator/data_model_vehicle_components_base.py

@@ -242,7 +242,7 @@ def update_json_structure(self) -> None:
 
         # Handle legacy battery monitor protocol migration for protocols that don't need hardware connections
         # This is a local import to avoid a circular import dependency
-        from ardupilot_methodic_configurator.data_model_vehicle_components_validation import (  # pylint: disable=import-outside-toplevel # noqa: PLC0415
+        from ardupilot_methodic_configurator.data_model_vehicle_components_validation import (  # pylint: disable=import-outside-toplevel, cyclic-import # noqa: PLC0415
             BATT_MONITOR_CONNECTION,
             OTHER_PORTS,
         )

tests/conftest.py

@@ -57,46 +57,46 @@ def root() -> Generator[tk.Tk, None, None]:
     """Create and clean up Tk root window for testing (session-scoped for robustness)."""
     # Try to reuse existing root or create new one
     try:
-        root = tk._default_root  # type: ignore[attr-defined]
-        if root is None:
-            root = tk.Tk()
+        root_instance = tk._default_root  # type: ignore[attr-defined] # pylint: disable=protected-access
+        if root_instance is None:
+            root_instance = tk.Tk()
     except (AttributeError, tk.TclError):
-        root = tk.Tk()
+        root_instance = tk.Tk()
 
-    root.withdraw()  # Hide the main window during tests
+    root_instance.withdraw()  # Hide the main window during tests
 
     # Patch the iconphoto method to prevent errors with mock PhotoImage
-    original_iconphoto = root.iconphoto
+    original_iconphoto = root_instance.iconphoto
 
-    def mock_iconphoto(*args, **kwargs) -> None:
+    def mock_iconphoto(*args, **kwargs) -> None:  # pylint: disable=unused-argument
         pass
 
-    root.iconphoto = mock_iconphoto  # type: ignore[method-assign]
+    root_instance.iconphoto = mock_iconphoto  # type: ignore[method-assign]
 
-    yield root
+    yield root_instance
 
     # Restore original method and destroy root
-    root.iconphoto = original_iconphoto  # type: ignore[method-assign]
+    root_instance.iconphoto = original_iconphoto  # type: ignore[method-assign]
 
     # Only destroy if we're the last test
     with contextlib.suppress(tk.TclError):
-        root.quit()  # Close the event loop
+        root_instance.quit()  # Close the event loop
 
 
 @pytest.fixture
 def tk_root() -> Generator[tk.Tk, None, None]:
     """Provide a real Tkinter root for integration tests (legacy name for compatibility)."""
-    root = None
+    tk_root_instance = None
     try:
-        root = tk.Tk()
-        root.withdraw()
-        yield root
+        tk_root_instance = tk.Tk()
+        tk_root_instance.withdraw()
+        yield tk_root_instance
     except tk.TclError:
         pytest.skip("Tkinter not available in test environment")
     finally:
-        if root is not None:
+        if tk_root_instance is not None:
             with contextlib.suppress(tk.TclError):
-                root.destroy()
+                tk_root_instance.destroy()
 
 
 @pytest.fixture

tests/test_backend_filesystem.py

@@ -21,7 +21,7 @@
 from ardupilot_methodic_configurator.annotate_params import Par
 from ardupilot_methodic_configurator.backend_filesystem import LocalFilesystem, is_within_tolerance
 
-# pylint: disable=too-many-lines
+# pylint: disable=too-many-lines, too-many-arguments, too-many-positional-arguments
 
 
 class TestLocalFilesystem(unittest.TestCase):  # pylint: disable=too-many-public-methods
@@ -1082,7 +1082,7 @@ def test_user_can_skip_copying_vehicle_image_from_template(
     @patch("ardupilot_methodic_configurator.backend_filesystem.os_path.join")
     @patch("ardupilot_methodic_configurator.backend_filesystem.shutil_copy2")
     @patch("ardupilot_methodic_configurator.backend_filesystem.os_path.isdir")
-    def test_copy_vehicle_image_defaults_to_false(self, mock_isdir, mock_copy2, mock_join, mock_listdir, mock_exists) -> None:
+    def test_copy_vehicle_image_defaults_to_false(self, mock_isdir, mock_copy2, mock_join, mock_listdir, mock_exists) -> None:  # pylint: disable=unused-argument
         """
         Vehicle image copying defaults to disabled.
 
@@ -1103,7 +1103,9 @@ def test_copy_vehicle_image_defaults_to_false(self, mock_isdir, mock_copy2, mock
         # Act: Copy template files without specifying copy_vehicle_image
         # (this should cause an error since parameter is required)
         with pytest.raises(TypeError):
-            lfs.copy_template_files_to_new_vehicle_dir("template_dir", "new_vehicle_dir", blank_change_reason=False)
+            lfs.copy_template_files_to_new_vehicle_dir(
+                "template_dir", "new_vehicle_dir", blank_change_reason=False, copy_vehicle_image=False
+            )
 
     @patch("ardupilot_methodic_configurator.backend_filesystem.os_path.exists")
     @patch("ardupilot_methodic_configurator.backend_filesystem.os_listdir")

tests/test_frontend_tkinter_autoresize_combobox.py

@@ -10,46 +10,15 @@
 SPDX-License-Identifier: GPL-3.0-or-later
 """
 
-import contextlib
 import tkinter as tk
-from collections.abc import Generator
 from tkinter import ttk
 from unittest.mock import patch
 
 import pytest
 
 from ardupilot_methodic_configurator.frontend_tkinter_autoresize_combobox import AutoResizeCombobox, update_combobox_width
 
-
-@pytest.fixture(scope="session")
-def root() -> Generator[tk.Tk, None, None]:
-    """Create and clean up Tk root window for testing."""
-    # Try to reuse existing root or create new one
-    try:
-        root = tk._default_root  # type: ignore[attr-defined]
-        if root is None:
-            root = tk.Tk()
-    except (AttributeError, tk.TclError):
-        root = tk.Tk()
-
-    root.withdraw()  # Hide the main window during tests
-
-    # Patch the iconphoto method to prevent errors with mock PhotoImage
-    original_iconphoto = root.iconphoto
-
-    def mock_iconphoto(*args, **kwargs) -> None:
-        pass
-
-    root.iconphoto = mock_iconphoto  # type: ignore[method-assign]
-
-    yield root
-
-    # Restore original method and destroy root
-    root.iconphoto = original_iconphoto  # type: ignore[method-assign]
-
-    # Only destroy if we're the last test
-    with contextlib.suppress(tk.TclError):
-        root.quit()  # Close the event loop
+# pylint: disable=redefined-outer-name
 
 
 @pytest.fixture

tests/test_frontend_tkinter_component_editor_integration.py

@@ -267,7 +267,7 @@ class TestComponentEditorWithMinimalMocking:
     while mocking only the absolute minimum required to avoid UI rendering.
     """
 
-    def test_editor_initialization_process(self, temp_vehicle_dir, root) -> None:  # pylint: disable=unused-argument
+    def test_editor_initialization_process(self, temp_vehicle_dir, root) -> None:
         """
         Test the full initialization process with minimal mocking.
 
@@ -315,7 +315,7 @@ def test_editor_initialization_process(self, temp_vehicle_dir, root) -> None:  #
             assert isinstance(components, dict)
             assert len(components) > 0
 
-    def test_editor_with_real_data_model(self, temp_vehicle_dir, root) -> None:  # pylint: disable=unused-argument
+    def test_editor_with_real_data_model(self, temp_vehicle_dir, root) -> None:
         """
         Test the editor with a real data model but minimal UI mocking.
 

tests/test_frontend_tkinter_component_template_manager.py

@@ -17,8 +17,6 @@
 
 from ardupilot_methodic_configurator.frontend_tkinter_component_template_manager import ComponentTemplateManager
 
-# pylint: disable=redefined-outer-name
-
 
 class TestComponentTemplateManager:
     """Test suite for ComponentTemplateManager."""

tests/test_frontend_tkinter_directory_selection_integration.py

@@ -35,8 +35,8 @@ class WidgetEventTracker:
 
     def __init__(self, widget) -> None:
         self.widget = widget
-        self.events: list[tuple[str, tk.Event[tk.Misc]]] = []
-        self.bindings: dict[str, Callable[[tk.Event[tk.Misc]], None]] = {}
+        self.events: list[tuple[str, tk.Event]] = []
+        self.bindings: dict[str, Callable[[tk.Event], None]] = {}
 
     def bind(self, event_name) -> None:
         """Bind to a widget event."""

tests/test_frontend_tkinter_parameter_editor.py

@@ -19,7 +19,7 @@
 from ardupilot_methodic_configurator.annotate_params import Par
 from ardupilot_methodic_configurator.frontend_tkinter_parameter_editor import ParameterEditorWindow
 
-# pylint: disable=redefined-outer-name
+# pylint: disable=redefined-outer-name, too-many-arguments, too-many-positional-arguments, unused-argument
 
 
 @pytest.fixture