fix(pip install): Change pip install command to use virtual environment

Fix for updating the software via the GUI update button

Signed-off-by: Evans Cesil Thomas <148005352+EvansCesilThomas@users.noreply.github.com>

Author: EvansCesilThomas

ardupilot_methodic_configurator/backend_internet.py

@@ -10,6 +10,7 @@
 
 import os
 import subprocess
+import sys
 import tempfile
 import time
 from datetime import datetime, timezone
@@ -238,7 +239,9 @@ def download_and_install_pip_release(progress_callback: Optional[Callable[[float
     if progress_callback:
         progress_callback(0.0, _("Starting installation..."))
 
-    ret = os.system("pip install --upgrade ardupilot_methodic_configurator")  # noqa: S605, S607
+    ret = subprocess.check_call(  # noqa: S603
+        [sys.executable, "-m", "pip", "install", "--upgrade", "ardupilot_methodic_configurator"]
+    )
 
     if ret == 0 and progress_callback:
         progress_callback(100.0, _("Download complete"))

tests/test_backend_internet.py

@@ -192,9 +192,9 @@ def test_download_and_install_windows_download_failure(mock_download) -> None:
     assert not download_and_install_on_windows("http://test.com", "test.exe")
 
 
-@patch("os.system")
-def test_download_and_install_pip_release(mock_system) -> None:
-    mock_system.return_value = 0
+@patch("subprocess.check_call")
+def test_download_and_install_pip_release(mock_check_call) -> None:
+    mock_check_call.return_value = 0
     assert download_and_install_pip_release() == 0