FIX: fix pylint and ruff checks

Author: amilcarlucas

.pre-commit-config.yaml

@@ -18,7 +18,7 @@ repos:
       - id: check-yaml
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.1
+    rev: v0.9.2
     hooks:
       - id: ruff
         args: [ --fix ]

ardupilot_methodic_configurator/frontend_tkinter_base.py

@@ -189,12 +189,16 @@ def on_mouse_wheel(self, event: tk.Event) -> None:  # cross platform scroll whee
 
         if rows_height > canvas_height:  # only scroll if the rows overflow the frame
             if platform_system() == "Windows":
+                # Windows: positive delta means scroll up, negative means scroll down
                 self.canvas.yview_scroll(int(-1 * (event.delta / 120)), "units")
             elif platform_system() == "Darwin":
+                # macOS: similar to Windows but different scaling
                 self.canvas.yview_scroll(int(-1 * event.delta), "units")
             elif event.num == 4:
+                # Linux: Button-4 means scroll up
                 self.canvas.yview_scroll(-1, "units")
             elif event.num == 5:
+                # Linux: Button-5 means scroll down
                 self.canvas.yview_scroll(1, "units")
 
     def on_enter(self, _event: tk.Event) -> None:  # bind wheel events when the cursor enters the control

tests/test_annotate_params.py

@@ -594,7 +594,7 @@ def test_split_into_lines_edge_cases(self) -> None:
     def test_format_columns_edge_cases(self) -> None:
         """Test format_columns with edge cases."""
         # Empty dictionary
-        assert format_columns({}) == []
+        assert not format_columns({})
 
         # Single item
         assert format_columns({"Key": "Value"}) == ["Key: Value"]
@@ -612,11 +612,11 @@ def test_create_doc_dict_edge_cases(self) -> None:
         """Test create_doc_dict with edge cases."""
         # Test with empty XML
         empty_root = ET.Element("root")
-        assert create_doc_dict(empty_root, "ArduCopter") == {}
+        assert not create_doc_dict(empty_root, "ArduCopter")
 
         # Test with missing attributes
         param = ET.SubElement(empty_root, "param")
-        assert create_doc_dict(empty_root, "ArduCopter") == {}
+        assert not create_doc_dict(empty_root, "ArduCopter")
 
         # Test with minimal valid param
         param.set("name", "TEST_PARAM")

tests/test_backend_filesystem.py

@@ -17,7 +17,7 @@
 from ardupilot_methodic_configurator.backend_filesystem import LocalFilesystem
 
 
-class TestLocalFilesystem(unittest.TestCase):
+class TestLocalFilesystem(unittest.TestCase):  # pylint: disable=too-many-public-methods
     """LocalFilesystem test class."""
 
     @patch("os.path.isdir")
@@ -280,7 +280,7 @@ def test_write_and_read_last_uploaded_filename(self) -> None:
 
         # Test reading
         with patch("builtins.open", unittest.mock.mock_open(read_data=test_filename)) as mock_file:
-            result = lfs._LocalFilesystem__read_last_uploaded_filename()
+            result = lfs._LocalFilesystem__read_last_uploaded_filename()  # pylint: disable=protected-access
             assert result == test_filename
             mock_file.assert_called_once_with(expected_path, encoding="utf-8")
 
@@ -322,7 +322,7 @@ def test_get_eval_variables(self) -> None:
 
         # Test with empty components and doc_dict
         result = lfs.get_eval_variables()
-        assert result == {}
+        assert not result
 
         # Test with components and doc_dict
         lfs.vehicle_components = {"Components": {"test": "value"}}
@@ -457,7 +457,7 @@ def test_all_intermediate_parameter_file_comments(self) -> None:
             "file2.param": {"PARAM2": MagicMock(comment="Override comment 2"), "PARAM3": MagicMock(comment="Comment 3")},
         }
 
-        result = lfs._LocalFilesystem__all_intermediate_parameter_file_comments()
+        result = lfs._LocalFilesystem__all_intermediate_parameter_file_comments()  # pylint: disable=protected-access
         assert result == {"PARAM1": "Comment 1", "PARAM2": "Override comment 2", "PARAM3": "Comment 3"}
 
 

tests/test_frontend_tkinter_base.py

@@ -16,6 +16,8 @@
 from tkinter import ttk
 from unittest.mock import MagicMock, patch
 
+import pytest
+
 from ardupilot_methodic_configurator.frontend_tkinter_base import (
     AutoResizeCombobox,
     BaseWindow,
@@ -471,7 +473,7 @@ def test_put_image_in_label(self, mock_label, mock_photo, mock_open) -> None:
 
         # Set up PhotoImage mock
         mock_photo_instance = MagicMock()
-        mock_photo_instance._PhotoImage__photo = "photo1"  # Required for Tkinter
+        mock_photo_instance._PhotoImage__photo = "photo1"  # pylint: disable=protected-access
         mock_photo.return_value = mock_photo_instance
 
         # Set up Label mock
@@ -495,6 +497,13 @@ def test_window_title(self) -> None:
         assert self.base_window.root.title() == title
 
 
+@pytest.fixture
+def mock_set_display() -> MagicMock:
+    """Mock the set_display_usage_popup method."""
+    with patch("ardupilot_methodic_configurator.frontend_tkinter_base.ProgramSettings.set_display_usage_popup") as mock_fun:
+        yield mock_fun
+
+
 class TestUsagePopupWindow(unittest.TestCase):
     """Test cases for the UsagePopupWindow class."""
 
@@ -513,8 +522,8 @@ def test_should_display(self, mock_display_popup) -> None:
         mock_display_popup.assert_called_once_with("test_type")
 
     @patch("tkinter.BooleanVar")
-    @patch("ardupilot_methodic_configurator.frontend_tkinter_base.ProgramSettings.set_display_usage_popup")
-    def test_display_popup(self, mock_set_display, mock_bool_var) -> None:
+    @pytest.mark.usefixtures("mock_set_display")
+    def test_display_popup(self, mock_bool_var) -> None:
         """Test display method."""
         mock_bool_var.return_value.get.return_value = True
         usage_window = BaseWindow(self.root)

tests/test_param_pid_adjustment_update.py

@@ -74,7 +74,7 @@ def test_invalid_input(self) -> None:
 
     def test_empty_file(self) -> None:
         # Create an empty temporary file
-        with open("temp.param", "w", encoding="utf-8") as f:  # noqa: F841
+        with open("temp.param", "w", encoding="utf-8") as _f:
             pass
 
         # Call the function and check the result
@@ -274,9 +274,9 @@ def test_parameter_missing_from_optimized_file(self) -> None:
 
     def test_empty_files(self) -> None:
         # Both the default and optimized parameter files are empty
-        with open(self.default_param_file, "w", encoding="utf-8") as f:  # F841
+        with open(self.default_param_file, "w", encoding="utf-8") as _f:  # F841
             pass
-        with open(self.optimized_param_file, "w", encoding="utf-8") as f:  # noqa: F841
+        with open(self.optimized_param_file, "w", encoding="utf-8") as _f:
             pass
         with pytest.raises(SystemExit) as cm:
             update_pid_adjustment_params(self.test_dir, os.path.basename(self.optimized_param_file), 0.5)
@@ -286,7 +286,7 @@ def test_empty_files(self) -> None:
 
     def test_empty_default_file(self) -> None:
         # Create an empty default parameter file
-        with open(self.default_param_file, "w", encoding="utf-8") as f:  # noqa: F841
+        with open(self.default_param_file, "w", encoding="utf-8") as _f:
             pass
         with pytest.raises(SystemExit) as cm:
             update_pid_adjustment_params(self.test_dir, os.path.basename(self.optimized_param_file), 0.5)
@@ -296,7 +296,7 @@ def test_empty_default_file(self) -> None:
 
     def test_empty_optimized_file(self) -> None:
         # Create an empty optimized parameter file
-        with open(self.optimized_param_file, "w", encoding="utf-8") as f:  # noqa: F841
+        with open(self.optimized_param_file, "w", encoding="utf-8") as _f:
             pass
         with pytest.raises(SystemExit) as cm:
             update_pid_adjustment_params(self.test_dir, os.path.basename(self.optimized_param_file), 0.5)
@@ -307,7 +307,7 @@ def test_empty_optimized_file(self) -> None:
 
     def test_empty_adjustment_file(self) -> None:
         # Create an empty adjustment parameter file
-        with open(self.adjustment_param_file, "w", encoding="utf-8") as f:  # noqa: F841
+        with open(self.adjustment_param_file, "w", encoding="utf-8") as _f:
             pass
         with pytest.raises(SystemExit) as cm:
             update_pid_adjustment_params(self.test_dir, os.path.basename(self.optimized_param_file), 0.5)