FIX: tests can access private members

Author: amilcarlucas

pyproject.toml

@@ -186,7 +186,7 @@ line-length = 127
 indent-width = 4
 
 [tool.ruff.lint.per-file-ignores]
-"tests/*" = ["D101", "UP031", "ARG002", "ANN001", "S101"]
+"tests/*" = ["D101", "UP031", "ARG002", "ANN001", "S101", "SLF001"]
 "ardupilot_methodic_configurator/backend_mavftp.py" = ["PGH004", "N801", "ANN001"]
 "ardupilot_methodic_configurator/backend_mavftp_example.py" = ["ANN001"]
 "ardupilot_methodic_configurator/tempcal_imu.py" = ["ANN001"]

tests/test_backend_filesystem_configuration_steps.py

@@ -77,13 +77,13 @@ def test_get_seq_tooltip_text(self) -> None:
     def test_missing_new_value(self) -> None:
         file_info = {"forced_parameters": {"PARAM1": {"Change Reason": "Test reason"}}}
         with self.assertLogs(level="ERROR") as log:
-            self.config_steps._ConfigurationSteps__validate_parameters_in_configuration_steps("test_file", file_info, "forced")  # noqa: SLF001 pylint: disable=protected-access
+            self.config_steps._ConfigurationSteps__validate_parameters_in_configuration_steps("test_file", file_info, "forced")  # pylint: disable=protected-access
             assert any("New Value" in message for message in log.output)
 
     def test_missing_change_reason(self) -> None:
         file_info = {"forced_parameters": {"PARAM1": {"New Value": "10"}}}
         with self.assertLogs(level="ERROR") as log:
-            self.config_steps._ConfigurationSteps__validate_parameters_in_configuration_steps("test_file", file_info, "forced")  # noqa: SLF001 pylint: disable=protected-access
+            self.config_steps._ConfigurationSteps__validate_parameters_in_configuration_steps("test_file", file_info, "forced")  # pylint: disable=protected-access
             assert any("Change Reason" in message for message in log.output)
 
     def test_compute_parameters_with_invalid_expression(self) -> None:

tests/test_backend_flightcontroller.py

@@ -120,51 +120,51 @@ def test_download_params_via_mavftp() -> None:
 
 def test_auto_detect_serial() -> None:
     fc = FlightController(reboot_time=7)
-    serial_ports = fc._FlightController__auto_detect_serial()  # noqa: SLF001 pylint: disable=protected-access
+    serial_ports = fc._FlightController__auto_detect_serial()  # pylint: disable=protected-access
     assert isinstance(serial_ports, list)
 
 
 def test_list_serial_ports() -> None:
-    serial_ports = FlightController._FlightController__list_serial_ports()  # noqa: SLF001 pylint: disable=protected-access
+    serial_ports = FlightController._FlightController__list_serial_ports()  # pylint: disable=protected-access
     assert isinstance(serial_ports, list)
 
 
 def test_list_network_ports() -> None:
-    network_ports = FlightController._FlightController__list_network_ports()  # noqa: SLF001 pylint: disable=protected-access
+    network_ports = FlightController._FlightController__list_network_ports()  # pylint: disable=protected-access
     assert isinstance(network_ports, list)
     assert "tcp:127.0.0.1:5760" in network_ports
 
 
 def test_request_banner() -> None:
     fc = FlightController(reboot_time=7)
     fc.connect(device="test")
-    fc._FlightController__request_banner()  # noqa: SLF001 pylint: disable=protected-access
+    fc._FlightController__request_banner()  # pylint: disable=protected-access
     # Since we cannot verify in the mock environment, we will just ensure no exceptions are raised
 
 
 def test_receive_banner_text() -> None:
     fc = FlightController(reboot_time=7)
     fc.connect(device="test")
-    banner_text = fc._FlightController__receive_banner_text()  # noqa: SLF001 pylint: disable=protected-access
+    banner_text = fc._FlightController__receive_banner_text()  # pylint: disable=protected-access
     assert isinstance(banner_text, list)
 
 
 def test_request_message() -> None:
     fc = FlightController(reboot_time=7)
     fc.connect(device="test")
-    fc._FlightController__request_message(1)  # noqa: SLF001 pylint: disable=protected-access
+    fc._FlightController__request_message(1)  # pylint: disable=protected-access
     # Since we cannot verify in the mock environment, we will just ensure no exceptions are raised
 
 
 def test_create_connection_with_retry() -> None:
     fc = FlightController(reboot_time=7)
-    result = fc._FlightController__create_connection_with_retry(progress_callback=None, retries=1, timeout=1)  # noqa: SLF001 pylint: disable=protected-access
+    result = fc._FlightController__create_connection_with_retry(progress_callback=None, retries=1, timeout=1)  # pylint: disable=protected-access
     assert result == ""
 
 
 def test_process_autopilot_version() -> None:
     fc = FlightController(reboot_time=7)
     fc.connect(device="test")
     banner_msgs = ["ChibiOS: 123", "ArduPilot"]
-    result = fc._FlightController__process_autopilot_version(None, banner_msgs)  # noqa: SLF001 pylint: disable=protected-access
+    result = fc._FlightController__process_autopilot_version(None, banner_msgs)  # pylint: disable=protected-access
     assert isinstance(result, str)

tests/test_backend_mavftp.py

@@ -226,7 +226,7 @@ def test_decode_ftp_ack_and_nack(self) -> None:
         ]
 
         for case in test_cases:
-            ret = self.mav_ftp._MAVFTP__decode_ftp_ack_and_nack(case["op"])  # noqa: SLF001, pylint: disable=protected-access
+            ret = self.mav_ftp._MAVFTP__decode_ftp_ack_and_nack(case["op"])  # pylint: disable=protected-access
             ret.display_message()
             log_output = self.log_stream.getvalue().strip()
             assert case["expected_message"] in log_output, (
@@ -245,7 +245,7 @@ def test_decode_ftp_ack_and_nack(self) -> None:
 
         # Test for unknown error code in display_message
         op = self.ftp_operation(seq=22, opcode=OP_Nack, req_opcode=OP_ListDirectory, payload=bytes([255]))
-        ret = self.mav_ftp._MAVFTP__decode_ftp_ack_and_nack(op, "ListDirectory")  # noqa: SLF001, pylint: disable=protected-access
+        ret = self.mav_ftp._MAVFTP__decode_ftp_ack_and_nack(op, "ListDirectory")  # pylint: disable=protected-access
         ret.error_code = 125  # Set error code to 125 to trigger unknown error message
         ret.display_message()
         log_output = self.log_stream.getvalue().strip()