pre-commit autoupdate 2025-07-25

Author: cclauss

.github/CODEOWNERS

@@ -7,4 +7,4 @@
 # *.js @username1 @username2
 
 # And you can specify owners for specific directories
-# /docs/ @username
+# /docs/ @username

.github/instructions/codebase_analysis_instructions.md

@@ -38,7 +38,7 @@ The codebase is organized into the following categories:
   ```bash
   # Find all markdown files
   find . -name "*.md" -type f
-  
+
   # Count lines in documentation
   find . -name "*.md" -type f | xargs cloc
   ```
@@ -53,7 +53,7 @@ The codebase is organized into the following categories:
   ```bash
   # Find all JSON files
   find . -name "*.json" -type f
-  
+
   # Count lines in configuration files
   find . -name "*.json" -type f | xargs cloc
   ```
@@ -87,7 +87,7 @@ The codebase is organized into the following categories:
   ```bash
   # Find all Python scripts in root directory
   find . -maxdepth 1 -name "*.py" -type f
-  
+
   # Count lines in root directory scripts
   cloc ./unix2dos.py ./create_pot_file.py ./insert_missing_translations.py \
        ./mavproxy_param.py ./copy_magfit_pdef_to_template_dirs.py ./setup.py \
@@ -98,7 +98,7 @@ The codebase is organized into the following categories:
        ./param_filter.py ./create_mo_files.py ./copy_param_files.py \
        ./update_configuration_steps_translation.py ./merge_pot_file.py \
        ./mavftp.py ./dos2unix.py
-  
+
   # Count lines in scripts directory
   cloc scripts/
   ```

.github/instructions/pytest_testing_instructions.md

@@ -47,9 +47,9 @@ def test_descriptive_behavior_name(self, fixture_name) -> None:
     THEN: Expected outcomes and assertions
     """
     # Arrange (Given): Set up test data and mocks
-    
+
     # Act (When): Execute the behavior being tested
-    
+
     # Assert (Then): Verify expected outcomes
 ```
 
@@ -64,14 +64,14 @@ Create reusable fixtures that eliminate code duplication:
 def mock_vehicle_provider() -> MagicMock:
     """Fixture providing a mock vehicle components provider with realistic test data."""
     provider = MagicMock()
-    
+
     # Create properly structured mock data matching real object interfaces
     template_1 = MagicMock()
     template_1.attributes.return_value = ["name", "fc", "gnss"]
     template_1.name = "QuadCopter X"
-    template_1.fc = "Pixhawk 6C" 
+    template_1.fc = "Pixhawk 6C"
     template_1.gnss = "Here3+"
-    
+
     provider.get_vehicle_components_overviews.return_value = {
         "Copter/QuadX": template_1,
     }
@@ -105,11 +105,11 @@ def configured_window(mock_vehicle_provider) -> ComponentWindow:
 ```python
 class TestUserWorkflow:
     """Test complete user workflows and interactions."""
-    
+
     def test_user_can_complete_primary_task(self, configured_window) -> None:
         """
         User can successfully complete the primary workflow.
-        
+
         GIVEN: A user opens the application
         WHEN: They follow the standard workflow
         THEN: They should achieve their goal without errors
@@ -179,8 +179,8 @@ def test_template_selection(self) -> None:
 # Use template_overview_window_setup fixture for complex UI mocking
 def test_ui_behavior(self, template_overview_window_setup) -> None:
     """Test UI behavior without full window creation."""
-    
-# Use template_window fixture for component testing  
+
+# Use template_window fixture for component testing
 def test_component_behavior(self, template_window) -> None:
     """Test component behavior with configured window."""
 ```
@@ -191,7 +191,7 @@ def test_component_behavior(self, template_window) -> None:
 # Use minimal mocking for business logic
 def test_business_logic(self, mock_data_provider) -> None:
     """Test core logic with realistic data."""
-    
+
 # Mock only external dependencies
 @patch('module.external_api_call')
 def test_integration_behavior(self, mock_api) -> None:
@@ -203,7 +203,7 @@ def test_integration_behavior(self, mock_api) -> None:
 ### Required Test Types
 
 1. **User Workflow Tests** - Complete user journeys
-2. **Component Behavior Tests** - Individual component functionality  
+2. **Component Behavior Tests** - Individual component functionality
 3. **Error Handling Tests** - Graceful failure scenarios
 4. **Integration Tests** - Component interaction validation
 5. **Edge Case Tests** - Boundary conditions and unusual inputs
@@ -213,7 +213,7 @@ def test_integration_behavior(self, mock_api) -> None:
 ```text
 tests/
 ├── test_frontend_tkinter_component.py      # UI component tests
-├── test_backend_logic.py                   # Business logic tests  
+├── test_backend_logic.py                   # Business logic tests
 ├── test_integration_workflows.py           # End-to-end scenarios
 └── conftest.py                             # Shared fixtures
 ```
@@ -242,11 +242,11 @@ tests/
 ```python
 class TestTemplateSelection:
     """Test user template selection workflows."""
-    
+
     def test_user_can_select_template_by_double_clicking(self, template_window) -> None:
         """
         User can select a vehicle template by double-clicking on the tree item.
-        
+
         GIVEN: A user views available vehicle templates
         WHEN: They double-click on a specific template row
         THEN: The template should be selected and stored
@@ -255,33 +255,33 @@ class TestTemplateSelection:
         # Arrange: Configure template selection behavior
         template_window.tree.identify_row.return_value = "template_item"
         template_window.tree.item.return_value = {"text": "Copter/QuadX"}
-        
+
         # Act: User double-clicks on template
         mock_event = MagicMock(y=100)
         template_window._on_row_double_click(mock_event)
-        
+
         # Assert: Template selected and workflow completed
         template_window.program_settings_provider.store_template_dir.assert_called_once_with("Copter/QuadX")
         template_window.root.destroy.assert_called_once()
-    
+
     def test_user_sees_visual_feedback_during_selection(self, template_window) -> None:
         """
         User receives immediate visual feedback when selecting templates.
-        
+
         GIVEN: A user is browsing available templates
         WHEN: They click on a template row
         THEN: The corresponding vehicle image should be displayed immediately
         """
         # Arrange: Set up selection behavior
         template_window.tree.selection.return_value = ["selected_item"]
         template_window.tree.item.return_value = {"text": "Plane/FixedWing"}
-        
+
         with patch.object(template_window, "_display_vehicle_image") as mock_display:
             # Act: User selects template
             mock_event = MagicMock()
             template_window._on_row_selection_change(mock_event)
             template_window._update_selection()  # Simulate callback
-            
+
             # Assert: Visual feedback provided
             mock_display.assert_called_once_with("Plane/FixedWing")
 ```
@@ -345,7 +345,7 @@ Before submitting any test changes:
 ### Success Criteria
 
 - ✅ All tests pass consistently
-- ✅ Coverage ≥ 80% on modified modules  
+- ✅ Coverage ≥ 80% on modified modules
 - ✅ Zero ruff/mypy violations
 - ✅ Tests follow behavior-driven structure
 - ✅ Fixtures eliminate code duplication

.github/instructions/update_motor_diagrams.md

@@ -81,7 +81,7 @@ scripts/
 The motor diagrams are categorized by frame type:
 
 - **QUAD FRAMES** (m_01_*): Standard quadcopter configurations
-- **HEXA FRAMES** (m_02_*): Hexacopter configurations  
+- **HEXA FRAMES** (m_02_*): Hexacopter configurations
 - **OCTO FRAMES** (m_03_*): Octocopter configurations
 - **OCTO QUAD FRAMES** (m_04_*): Octo-quad configurations
 - **Y6 FRAMES** (m_05_*): Y6 configurations

.github/workflows/update_motor_diagrams.yml

@@ -79,10 +79,10 @@ jobs:
           commit-message: "chore(images): Updated ArduPilot motor diagram SVG files"
           body: |
             This PR updates the ArduPilot motor diagram SVG files from the upstream ArduPilot documentation.
-            
+
             Changes include:
             - Updated motor diagram SVG files from https://ardupilot.org/copter/docs/connect-escs-and-motors.html
             - Ensures diagrams are current with latest ArduPilot documentation
-            
+
             These diagrams are used in the Motor Test sub-application to help users understand correct motor order and rotation.
           delete-branch: true

.github/workflows/update_vehicle_components_translation.yaml

@@ -31,7 +31,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       STRINGS_CHANGED: false
-    
+
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
@@ -40,16 +40,16 @@ jobs:
 
       - name: Checkout repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      
+
       - name: Set up Python
         uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
           python-version: '3.10'
-      
+
       - name: Generate vehicle components strings
         run: |
           python update_vehicle_components_translation.py
-      
+
       - name: Check for changes
         run: |
           git add ardupilot_methodic_configurator/vehicle_components.py
@@ -58,7 +58,7 @@ jobs:
           else
             echo "No changes to commit"
           fi
-      
+
       - name: Create Pull Request
         if: env.STRINGS_CHANGED == 'true'
         uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
@@ -68,12 +68,12 @@ jobs:
           title: 'Update vehicle components translatable strings'
           body: |
             This PR updates the vehicle_components.py file with new translatable strings.
-            
+
             These strings were automatically extracted from the vehicle_components.json template files
             and the vehicle_components_schema.json schema file.
-            
+
             This PR was triggered by changes to one or more files.
           branch: update-vehicle-components-strings
           delete-branch: true
           labels: automated-pr, i18n
-          reviewers: ${{ github.actor }}
+          reviewers: ${{ github.actor }}

ARCHITECTURE_1_software_update.md

@@ -11,7 +11,7 @@ This ensures users always have access to the latest features, bug fixes, and sec
 ### Functional Requirements - Implementation Status
 
 1. **Version Check** ✅ **IMPLEMENTED**
-   - ✅ Checks current version against latest via GitHub releases API  
+   - ✅ Checks current version against latest via GitHub releases API
    - ✅ Handles network connectivity issues with proper exception handling
    - ✅ Validates version format using `packaging.version.parse()`
    - ✅ Supports semantic versioning and prerelease versions
@@ -44,7 +44,7 @@ This ensures users always have access to the latest features, bug fixes, and sec
 6. **Error Handling** ⚠️ **PARTIALLY IMPLEMENTED**
    - ✅ Network failures handled with appropriate error messages
    - ❌ **TODO**: No recovery from corrupted downloads
-   - ❌ **TODO**: No rollback for failed installations  
+   - ❌ **TODO**: No rollback for failed installations
    - ✅ Clear error messages displayed to users
 
 ### Non-Functional Requirements - Implementation Status
@@ -157,7 +157,7 @@ This ensures users always have access to the latest features, bug fixes, and sec
 
 - ✅ **Main Application**: Called from `__main__.py` during startup before other sub-applications
 - ❌ **TODO: Configuration System**: No update preferences stored - uses hardcoded behavior (stable releases only)
-- ✅ **Logging System**: Uses standard Python logging for all update activities and errors  
+- ✅ **Logging System**: Uses standard Python logging for all update activities and errors
 - ✅ **File System**:
   - Windows: Uses `tempfile.TemporaryDirectory()` for secure temporary file handling
   - Both platforms: Manages installer/package downloads and cleanup
@@ -176,7 +176,7 @@ This ensures users always have access to the latest features, bug fixes, and sec
 ### Error Handling Strategy
 
 - ✅ **Network Errors**: Comprehensive handling of `RequestException`, `Timeout`, and connection errors
-- ✅ **Download Corruption**: Validates response status codes and handles stream errors  
+- ✅ **Download Corruption**: Validates response status codes and handles stream errors
 - ✅ **Installation Failures**: Exception handling with logging for Windows and pip installation failures
 - ✅ **Permission Errors**: Catches `OSError` for file system permission issues
 - ✅ **User Feedback**: Clear error messages logged and displayed to users
@@ -199,7 +199,7 @@ This ensures users always have access to the latest features, bug fixes, and sec
 
 ```text
 middleware_software_updates.py          # Core update logic and orchestration ✅
-frontend_tkinter_software_update.py     # GUI dialog interface ✅  
+frontend_tkinter_software_update.py     # GUI dialog interface ✅
 backend_internet.py                     # Download and installation backend ✅
 tests/test_middleware_software_updates.py        # Unit tests for core logic ✅
 tests/test_frontend_tkinter_software_update.py   # UI dialog tests ✅
@@ -286,7 +286,7 @@ tests/test_frontend_tkinter_software_update.py   # UI dialog tests ✅
 ### Medium Priority TODO Items
 
 1. **Add installation validation** to verify successful updates
-2. **Implement resume capability** for interrupted downloads  
+2. **Implement resume capability** for interrupted downloads
 3. **Add user configuration** for update preferences
 4. **Enhance Windows security** by validating temp directory permissions
 

ARCHITECTURE_motor_test.md

@@ -3,7 +3,7 @@
 ## Status Legend
 
 - ✅ **Green Check**: Fully implemented and tested with BDD pytest
-- 🟡 **Yellow Check**: Implemented but not yet tested with BDD pytest  
+- 🟡 **Yellow Check**: Implemented but not yet tested with BDD pytest
 - ❌ **Red Cross**: Not implemented
 
 ## Overview

ardupilot_methodic_configurator/AP_Motors_test_schema.json

@@ -39,7 +39,7 @@
           "description": "Human-readable frame class name",
           "enum": [
             "QUAD",
-            "HEXA", 
+            "HEXA",
             "OCTA",
             "OCTAQUAD",
             "Y6",