Merge branch 'master' into macOS_tests

Signed-off-by: Amilcar Lucas <[email protected]>

Author: amilcarlucas

.gitattributes

@@ -1,6 +1,6 @@
 # AI translation prompt templates should be treated as YAML
 #
-# SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <[email protected]>
+# SPDX-FileCopyrightText: 2024-2026 Amilcar do Carmo Lucas <[email protected]>
 #
 # SPDX-License-Identifier: GPL-3.0-or-later
 *.prompt.yml linguist-language=YAML

.github/copilot-instructions.md

@@ -4,46 +4,69 @@ This is a Python GUI application for configuring ArduPilot flight controller par
 
 ## Code Style and Standards
 
-We follow PEP 8 Python style guidelines with strict linting using ruff, pylint, mypy, and pyright.
-All code must pass these checks before merging.
+- Follow PEP 8 Python style guidelines with strict linting (ruff, pylint, mypy, pyright)
+- Use type hints for all function parameters and return values (PEP 484)
+- Use ruff only for Python files (*.py); use `npx markdownlint-cli2` for markdown files (*.md)
+- All code must pass pre-commit checks before merging
 
-**Important**: Use ruff only for Python files (*.py).
-For markdown files (*.md), use `npx markdownlint-cli2` or similar markdown-specific linting tools.
+## Testing
 
-When writing code, use type hints for all function parameters and return values following PEP 484 standards.
+- Use pytest with behavior-driven development (BDD) approach
+- Test structure: Given-When-Then pattern with descriptive names like `test_user_can_select_template_by_double_clicking`
+- Focus on user behavior and business value, not implementation details
 
-## Testing Philosophy
+## Architecture
 
-We use pytest for testing with a behavior-driven development (BDD) approach.
-Tests should focus on user behavior and business value, not implementation details.
+Clean architecture with separation of concerns:
 
-Test structure follows Given-When-Then pattern with descriptive names like `test_user_can_select_template_by_double_clicking`.
+- **Frontend**: tkinter-based GUI (inherit from `BaseWindow`, use `ScrollFrame` for scrollable areas)
+- **Business logic**: Vehicle templates, configuration steps, parameter management
+- **Backend**: Filesystem operations (`backend_filesystem.py`), flight controller communication (`backend_flightcontroller.py`)
 
-For detailed testing guidelines, see `.github/instructions/pytest_testing_instructions.md`.
+## Dependencies and Tools
 
-## Architecture
+- **Dependency management**: Use `uv`, not `pip` directly. Update `pyproject.toml` and `credits/CREDITS.md` when adding dependencies
+- **Pre-commit hooks**: Run `pre-commit install` after cloning
 
-The project uses a clean architecture with separation of concerns:
+## Key File Conventions
 
-- Frontend: tkinter-based GUI
-- Business logic: vehicle templates, configuration steps and parameter management
-- Backend: Filesystem operations, Flightcontroller integration and communication
+- **Parameter files**: Use `.param` extension with numbered prefixes (e.g., `01_first_setup.param`)
+- **Vehicle templates**: Located in `ardupilot_methodic_configurator/vehicle_templates/` with subdirectories for each vehicle type (ArduCopter, ArduPlane, Rover, Heli)
+- **Internationalization**: Wrap all user-facing strings with `_()` for gettext translation
 
-## Dependencies and Tools
+## Development Workflow
+
+**Setup**: Run `SetupDeveloperPC.bat` (Windows) or `SetupDeveloperPC.sh` (Linux/macOS)
+
+**Run app**: Activate `.venv` then `python -m ardupilot_methodic_configurator`
+
+**Code quality**: `ruff format`, `ruff check --fix`, `mypy`, `pyright`, `pylint $(git ls-files '*.py')`
+
+**Testing**: `pytest tests/ -v` or `pytest tests/ --cov=ardupilot_methodic_configurator`
+
+## Common Patterns
+
+- **Error Handling**: Use the project's logging system (5 verbosity levels); catch specific exceptions; provide user-friendly GUI messages
+- **Parameter Management**: Validate parameter values before applying to flight controller
+- **Backend Communication**: Use `backend_flightcontroller.py` facade; implement progress callbacks for long operations
 
-We use uv for dependency management, not pip directly.
-Always update `pyproject.toml` when adding dependencies.
+## Security
 
-Pre-commit hooks ensure code quality - run `pre-commit install` after cloning.
+- Never commit secrets or credentials
+- Use SSL verification for network requests
+- Validate all user inputs before processing
 
-## File Structure
+## Contributing
 
-Parameter files use `.param` extension and are numbered (e.g., `01_first_setup.param`).
+- All commits must be signed off (DCO requirements)
+- Use Conventional Commits format for commit messages
+- See CONTRIBUTING.md for full details
 
-Vehicle templates are organized in `ardupilot_methodic_configurator/vehicle_templates/` with subdirectories
-for each vehicle type (ArduCopter, ArduPlane, Rover, Heli).
+## Additional Documentation
 
-## Internationalization
+When needed for specific tasks, refer to:
 
-The application supports multiple languages using gettext.
-All user-facing strings should be wrapped with `_()` for translation.
+- Architecture details: ARCHITECTURE*.md files in project root
+- Testing guidelines: .github/instructions/pytest_testing_instructions.md
+- Translation workflow: .github/instructions/gui_translation_instructions.md
+- Other specialized instructions: .github/instructions/ directory

.github/instructions/pytest_testing_instructions.md

@@ -214,11 +214,12 @@ Test files follow specific naming conventions to clearly indicate their purpose
 
 ```text
 tests/
-├── test_frontend_tkinter_component.py      # UI component unit tests
-├── test_backend_logic.py                   # Business logic unit tests
-├── gui_*.py                                # GUI-focused tests (prefixed with gui_)
-├── integration_*.py                        # Integration tests (prefixed with integration_)
-├── test_integration_workflows.py           # End-to-end scenarios
+├── test_frontend_tkinter_component.py      # BDD UI component unit tests
+├── test_backend_logic.py                   # BDD Business logic unit tests
+├── gui_*.py                                # pyautogui GUI-focused tests (prefixed with gui_)
+├── integration_*.py                        # End-to-end integration tests (prefixed with integration_)
+├── acceptance_*.py                         # Acceptance tests (prefixed with acceptance_)
+├── unit_*.py                               # Low-level unit tests for coverage purposes (prefixed with unit_)
 └── conftest.py                             # Shared fixtures
 ```
 
@@ -296,10 +297,11 @@ class TestTemplateSelection:
 
 1. **Run tests**: `pytest tests/ -v`
 2. **Check coverage**: `pytest --cov=ardupilot_methodic_configurator --cov-report=term-missing`
-3. **Lint with ruff**: `ruff check --fix`
-4. **Type check with mypy**: `mypy .`
-5. **Advanced type check with pyright**: `pyright`
-6. **Style check with pylint**: `pylint $(git ls-files '*.py')`
+3. **Format with ruff**: `ruff format`
+4. **Lint with ruff**: `ruff check --fix`
+5. **Type check with mypy**: `mypy`
+6. **Advanced type check with pyright**: `pyright`
+7. **Style check with pylint**: `pylint $(git ls-files '*.py')`
 
 ### Test Execution Commands
 
@@ -335,17 +337,6 @@ pytest tests/ -m "slow" -v
 
 ## 🔍 Quality Assurance
 
-### Final Validation Steps
-
-Before submitting any test changes:
-
-1. **Verify all tests pass**: `pytest tests/ -v`
-2. **Confirm coverage maintained**: Check coverage report
-3. **Lint compliance**: `ruff check` (must pass)
-4. **Type safety**: `mypy .` (must pass)
-5. **Pyright validation**: `pyright` (should pass)
-6. **Style compliance**: `pylint $(git ls-files '*.py')` (address major issues)
-
 ### Success Criteria
 
 - ✅ All tests pass consistently
@@ -358,4 +349,4 @@ Before submitting any test changes:
 
 ---
 
-**Remember**: Great tests are an investment in the future. Write tests that make the codebase more maintainable, not just achieve coverage metrics.
+**Remember**: Write tests that make the codebase more maintainable, not just achieve coverage metrics.

.github/prompts/ai-translation-system.prompt.yml

@@ -3,20 +3,20 @@ messages:
     content: |
       You are a professional translator specializing in technical software localization for ArduPilot flight controller configuration software.
 
-      CRITICAL INSTRUCTIONS:
-      1. You will receive a list of English strings to translate in the format "line_number:English text"
-      2. You MUST preserve the exact line number and colon format: "line_number:Translated text"
-      3. Translate ONLY the text after the colon, keeping the line number and colon unchanged
-      4. Preserve all placeholders like {variable_name}, {0}, etc. exactly as they appear
-      5. Consider the technical aviation/drone context when translating
-      6. Use formal register appropriate for technical documentation
-      7. Maintain consistent terminology throughout
+      OUTPUT FORMAT - CRITICAL:
+      - Output ONLY the translated lines, one per line
+      - Each line MUST be in format: "line_number:Translated text"
+      - Do NOT include any markdown formatting, code blocks, explanations, or extra text
+      - Do NOT wrap output in ```
+      - Start your response directly with the first translated line
 
-      CONTEXT AWARENESS:
-      - This may be part of a larger translation batch split into chunks for processing
-      - Maintain consistency with common ArduPilot/flight controller terminology
-      - Common terms: "parameter", "vehicle", "flight controller", "autopilot", "mission", "waypoint", "telemetry"
-      - Use the same translation for recurring technical terms within this batch
+      TRANSLATION RULES:
+      1. Preserve the exact line number and colon format: "line_number:Translated text"
+      2. Translate ONLY the text after the colon, keeping the line number unchanged
+      3. Preserve all placeholders like {variable_name}, {0}, etc. exactly as they appear
+      4. Consider the technical aviation/drone context when translating
+      5. Use formal register appropriate for technical documentation
+      6. Maintain consistent terminology throughout
 
       LANGUAGE-SPECIFIC GUIDELINES:
       - Portuguese (pt): Use European Portuguese (Portugal) conventions, "ficheiro" not "arquivo" for "file", "transferir" not "baixar" for "download", "parâmetro" for "parameter", "veículo" for "vehicle"
@@ -25,8 +25,10 @@ messages:
       - Japanese (ja): Use polite form (です/ます), katakana for foreign technical terms, パラメータ for "parameter", 機体 for "vehicle", フライトコントローラー for "flight controller"
       - Chinese (zh_CN): Use simplified characters, technical aviation terminology in Chinese, "参数" for "parameter", "飞行器" for "vehicle", "飞控" for "flight controller"
 
-      EXAMPLE:
-      Input: "123:Copy vehicle image from template"
-      Output: "123:Copiar imagem do veículo do modelo" (for Portuguese)
+      EXAMPLE INPUT:
+      123:Copy vehicle image from template
+      456:Select flight controller
 
-      Translate all strings while preserving the exact format and maintaining terminological consistency.
+      EXAMPLE OUTPUT (Portuguese):
+      123:Copiar imagem do veículo do modelo
+      456:Selecionar controlador de voo

.github/prompts/ai-translation-user.prompt.yml

@@ -8,3 +8,6 @@ messages:
       Please read the translation file "{{translation_file}}" and translate all the strings from English to {{language}}.
 
       The file contains strings in the format "line_number:English text" - please translate only the text after the colon while preserving the exact line number and colon format.
+
+      Translation strings to process:
+      {{translation_content}}