Skip to content

Commit 20ae001

Browse files
Merge pull request #34 from freddym56/edgar-25.2.u1
2 parents e421ce4 + 2051813 commit 20ae001

File tree

7 files changed

+160
-25
lines changed

7 files changed

+160
-25
lines changed

render/Report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1152,7 +1152,7 @@ def generateBarChart(self):
11521152
factList = []
11531153
yMax = 0.0
11541154
yMin = 0.0
1155-
isOefBarChartFact = re.compile(r'^\{http://xbrl.sec.gov/oef/.*\}AnnlRtrPct$') # WcH in a hurry 4/6/2023
1155+
isOefBarChartFact = re.compile(r'^\{http://xbrl.sec.gov/oef/2023.*\}AnnlRtrPct$')
11561156
for row in self.rowList:
11571157
for fact in row.factList:
11581158
m = Utils.isBarChartFactRegex.match(fact.qname.clarkNotation)

render/Summary.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ def innerWriteMetaFiles(reportsFolder, zipDir="", suplSuffix="", prefix=""):
364364
numList.sort()
365365
tagAa['auth_ref'] = ['r' + str(num) for num in numList]
366366
root['tag'] = s.tagDict
367-
if self.controller.reportZip or self.controller.reportsFolder is not None:
367+
if self.summaryList and (self.controller.reportZip or self.controller.reportsFolder is not None):
368368
file = io.StringIO()
369369
else:
370370
file = None

render/__init__.py

Lines changed: 123 additions & 15 deletions
Large diffs are not rendered by default.

validate/Consts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
(re.compile(r"EX-26.*"), "ex26-validations.json"),
6868
(None, "dei-validations.json")
6969
)
70-
supplementalAttachmentDocumentTypesPattern = re.compile(r"EX-FILING FEES.*|EX-99\.[C-S]\.SBSEF.*|EX-98.*")
70+
supplementalAttachmentDocumentTypesPattern = re.compile(r"EX-FILING FEES.*|EX-99\.[C-S]\.SBSEF.*|EX-98.*|EX-99.4R HISTORIC|EX-26")
7171
exhibitTypesStrippingOnErrorPattern = re.compile(r"EX-26.*|EX-99\.[C-S]\.SBSEF.*|EX-98.*")
7272
exhibitTypesPrivateNotDisseminated = re.compile(r"EX-99\.[DEFHIJKNOPQRS]\.SBSEF")
7373
primaryAttachmentDocumentTypesPattern = re.compile(r"(?!EX-)")

validate/__init__.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,21 @@
129129
ixRedline (when emulating EDGAR workstation, true specifies showing workstation inline XBRL redlines)
130130
Otherwise menu entry view/Workstation Redline Mode, when checked, selects Edgar Workstation xslt's and ixRedline as above.
131131
132+
Test cases can verify via introduce processing flow exceptions, that the exceptions are caught, logged,
133+
and that processing flow completes as expected given the remaining processing which the exception terminated.
134+
135+
A test case inline XBRL document may have a processing instruction of this format:
136+
<?arelle-unit-test location="EFM/Filing.py#validateFiling_start" action="AssertionError"?>
137+
This will cause code in EFM/Filing.py (search on the location string) to raise an assertion error
138+
which would correspond to the expected unit test code (see conformance test i003004gw testcase and
139+
htm files).
140+
141+
The currently implemented assertion test locations are
142+
Filing, before starting first IXDS validation: EFM/Filing.py#validateFiling_start
143+
Filing, after completion of first IXDS validation: EFM/Filing.py#validateFiling_end
144+
Rendering, after pass 1 of all filings EdgarRenderer/__init__.py#filingPass1
145+
Rendering, after completion of all filings EdgarRenderer/__init__.py#filingEnd
146+
132147
'''
133148
import os, io, json, zipfile, logging
134149
jsonIndent = 1 # None for most compact, 0 for left aligned

validate/resources/ft-validations.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4401,6 +4401,18 @@
44014401
"comment-date-requested": "",
44024402
"comment-reason": ""
44034403
},
4404+
{
4405+
"sub-types": ["@G-3-4-5-6-9-10-11-12", "@G-7-8"],
4406+
"xbrl-names": "ffd:NetFeeAmt",
4407+
"efm": "ft.ttlRqdFlds",
4408+
"validation": "fw",
4409+
"comment-validation": "Required, non-negative numeric value.",
4410+
"comment-exception-handling": "",
4411+
"comment-conversion-requested": "",
4412+
"comment-requesting-do": "",
4413+
"comment-date-requested": "",
4414+
"comment-reason": ""
4415+
},
44044416
{
44054417
"sub-types": ["@all-Ixbrl"],
44064418
"xbrl-names": "ffd:TtlPrevslyPdAmt",

validate/resources/taxonomy-compatibility.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,21 +74,21 @@
7474

7575
"comment2": "entries for currently-supported taxonomies. All versions only compatible with same year. No exceptions anymore.",
7676

77-
"us-gaap/2024": ["@stx-2024", "srt/2024", "ifrs/2024", "cef/2024"],
78-
"us-gaap/2025": ["@stx-extended-2025", "srt/2025", "ifrs/2025", "cef/2025"],
77+
"us-gaap/2024": ["@stx-2024", "srt/2024", "ifrs/2024", "cef/2024", "vip/2024", "vip/2024q4"],
78+
"us-gaap/2025": ["@stx-extended-2025", "srt/2025", "ifrs/2025", "cef/2025", "vip/2025"],
7979

8080
"ifrs/2024": ["us-gaap/2024", "srt/2024", "@stx-2024"],
8181
"ifrs/2025": ["us-gaap/2025", "srt/2025", "@stx-extended-2025"],
8282

8383
"cef/2024": ["@stx-2024", "us-gaap/2024", "srt/2024"],
8484
"cef/2025": ["@stx-extended-2025", "us-gaap/2025", "srt/2025"],
8585

86-
"srt/2024": ["@stx-2024"],
87-
"srt/2025": ["@stx-extended-2025"],
86+
"srt/2024": ["@stx-2024", "vip/2024", "vip/2024q4"],
87+
"srt/2025": ["@stx-extended-2025", "vip/2025"],
8888

89-
"vip/2024": ["@stx-2024"],
90-
"vip/2024q4": ["@stx-2024"],
91-
"vip/2025": ["@stx-core-2025"],
89+
"vip/2024": ["@stx-2024", "us-gaap/2024", "srt/2024"],
90+
"vip/2024q4": ["@stx-2024", "us-gaap/2024", "srt/2024"],
91+
"vip/2025": ["@stx-core-2025", "us-gaap/2025", "srt/2025"],
9292

9393
"ffd/2025": ["@stx-core-2025"]
9494
}

0 commit comments

Comments
 (0)