prevent race condition in health check test by setting environment before tests

Author: ddowker

broker/stores/health_check_test.go

@@ -25,6 +25,8 @@ func (errorReader) Read([]byte) (int, error) {
 func TestHealthChecks(t *testing.T) {
 	const testContent = "health-check\n"
 
+	ForceStoreHealthCheckToHealthy = false
+
 	// Channel to coordinate the "Failure Then Success" test
 	var failureThenSuccessCh = make(chan struct{})
 
@@ -199,8 +201,6 @@ func TestHealthChecks(t *testing.T) {
 				"s3": tt.setupStore(server),
 			})
 
-			ForceStoreHealthCheckToHealthy = false
-
 			// Get store - this starts health check
 			store := Get(pb.FragmentStore("s3://test/"))
 			require.NoError(t, store.initErr)