Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

Commit 721f0b4

Browse files
authored
Merge pull request #486 from ArkEcosystem/release/1.7.0
chore: merge 1.7.0 into master
2 parents ea3f7ee + 2a4baa6 commit 721f0b4

File tree

538 files changed

+41709
-30389
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

538 files changed

+41709
-30389
lines changed

.editorconfig

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
# EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs
2-
# editorconfig.org
3-
41
root = true
52

63
[*]
7-
indent_style = space
8-
indent_size = 2
9-
10-
# We recommend you to keep these unchanged
11-
end_of_line = lf
124
charset = utf-8
13-
trim_trailing_whitespace = true
5+
end_of_line = lf
146
insert_final_newline = true
7+
indent_style = tab
8+
indent_size = 4
9+
trim_trailing_whitespace = true
1510

1611
[*.md]
17-
trim_trailing_whitespace = false
12+
trim_trailing_whitespace = false
13+
14+
[*.yml]
15+
trim_trailing_whitespace = false
16+
indent_size = 2
17+
indent_style = space

.github/workflows/lint.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
name: Lint
22

33
on:
4-
push:
5-
branches:
6-
- '**'
7-
pull_request:
8-
types: [ready_for_review, synchronize, opened]
4+
push:
5+
branches:
6+
- "**"
7+
pull_request:
8+
types: [ready_for_review, synchronize, opened]
99

1010
jobs:
1111
source:
1212
runs-on: ubuntu-latest
1313

1414
strategy:
1515
matrix:
16-
node-version: [10.x, 12.x]
16+
node-version: [12.x]
1717

1818
steps:
1919
- uses: actions/checkout@v1
2020
- name: Use Node.js ${{ matrix.node-version }}
2121
uses: actions/setup-node@v1
2222
with:
23-
node-version: ${{ matrix.node-version }}
23+
node-version: ${{ matrix.node-version }}
2424
- name: Install pre dependencies
25-
run: yarn global add ionic@4.x cordova@8.x
25+
run: npm install -g ionic cordova
2626
- name: Install
27-
run: npm rebuild node-sass && yarn install --frozen-lockfile
27+
run: npm rebuild node-sass && npm install
2828
- name: Lint
29-
run: npm run lint --bailOnLintError true
29+
run: npm run lint

.github/workflows/test.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
name: Test
22

33
on:
4-
push:
5-
branches:
6-
- '**'
7-
pull_request:
8-
types: [ready_for_review, synchronize, opened]
4+
push:
5+
branches:
6+
- "**"
7+
pull_request:
8+
types: [ready_for_review, synchronize, opened]
99

1010
jobs:
1111
unit:
1212
runs-on: ubuntu-latest
1313

1414
strategy:
1515
matrix:
16-
node-version: [10.x, 12.x]
16+
node-version: [12.x]
1717

1818
steps:
1919
- uses: actions/checkout@v1
@@ -22,9 +22,9 @@ jobs:
2222
with:
2323
node-version: ${{ matrix.node-version }}
2424
- name: Install pre dependencies
25-
run: yarn global add ionic@4.x cordova@8.x
25+
run: npm i -g ionic cordova
2626
- name: Install
27-
run: npm rebuild node-sass && yarn install --frozen-lockfile
27+
run: npm rebuild node-sass && npm install
2828
- name: Test
2929
run: npm run test:coverage
3030
- name: Build
@@ -35,7 +35,7 @@ jobs:
3535

3636
strategy:
3737
matrix:
38-
node-version: [10.x, 11.x, 12.x]
38+
node-version: [12.x]
3939

4040
steps:
4141
- uses: actions/checkout@v1
@@ -44,9 +44,9 @@ jobs:
4444
with:
4545
node-version: ${{ matrix.node-version }}
4646
- name: Install pre dependencies
47-
run: yarn global add ionic@4.x cordova@8.x
47+
run: npm i -g ionic cordova
4848
- name: Install
49-
run: npm rebuild node-sass && yarn install --frozen-lockfile
49+
run: npm rebuild node-sass && npm install
5050
- name: Test
5151
run: npm run test:e2e
5252
- name: Build

.gitignore

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,35 +3,29 @@
33

44
*~
55
*.sw[mnpcod]
6-
*.log
6+
.tmp
77
*.tmp
88
*.tmp.*
9-
log.txt
109
*.sublime-project
1110
*.sublime-workspace
12-
.vscode/
13-
npm-debug.log*
14-
15-
.idea/
16-
.sass-cache/
17-
.tmp/
18-
.versions/
19-
coverage/
20-
dist/
21-
node_modules/
22-
tmp/
23-
temp/
24-
hooks/
25-
platforms/
26-
plugins/
27-
plugins/android.json
28-
plugins/ios.json
29-
www/
30-
$RECYCLE.BIN/
31-
3211
.DS_Store
3312
Thumbs.db
3413
UserInterfaceState.xcuserstate
14+
$RECYCLE.BIN/
15+
16+
*.log
17+
log.txt
18+
npm-debug.log*
3519

36-
.sourcemaps/
37-
.vscode
20+
/.idea
21+
/.ionic
22+
/.sass-cache
23+
/.sourcemaps
24+
/.versions
25+
/.vscode
26+
/coverage
27+
/dist
28+
/node_modules
29+
/platforms
30+
/plugins
31+
/www

.lintstagedrc.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"*.ts": ["tslint -c tslint.json --fix", "prettier --write"],
3+
"src/**/*.ts": ["ng-lint-staged lint --fix --"],
4+
"*.{css,pcss,scss,html,json,md,js}": ["prettier --write"]
5+
}

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
10
1+
12

.prettierrc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"printWidth": 80,
3+
"singleQuote": false,
4+
"tabWidth": 4,
5+
"trailingComma": "all",
6+
"useTabs": true
7+
}

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @luciorubeens @alexbarnsley
1+
* @luciorubeens @alexbarnsley

LICENSE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2017 Ark.io, Lúcio Rubens <lucio@ark.io>, Alex Barnsley <alex@ark.io>
3+
Copyright (c) ARK Ecosystem <info@ark.io>
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal
@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
1818
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
1919
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2020
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21-
SOFTWARE.
21+
SOFTWARE.

README.md

Lines changed: 80 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -13,80 +13,122 @@
1313

1414
> Lead Maintainer: [Lúcio Rubens](https://github.com/luciorubeens)
1515
16-
ARK’s mobile wallet is a hybrid application (using the same codebase for Android and iOS which helps with coordinated development). Created using Ionic framework and ARK’s [TypeScript API](https://github.com/ArkEcosystem/ark-ts) to interact with the ARK network via your mobile phone, anytime, anywhere (as long as you have an internet connection).
16+
ARK’s mobile wallet is a hybrid application (using the same codebase for Android and iOS which helps with coordinated development).
1717

1818
## Download
1919

2020
- [Google Play](https://play.google.com/store/apps/details?id=io.ark.wallet.mobile)
2121
- [App Store](https://itunes.apple.com/us/app/mobile-ark/id1324625967)
2222

23-
## Features
24-
25-
- Import your existing passphrase (import by QR Scanner or write/paste your passphrase).
26-
- Generate a new passphrase.
27-
- Encrypt access to your profile with a custom 6 digit PIN (AES256+PBKDF2).
28-
- Most transaction types are available: send, receive, vote, unvote, register a delegate.
29-
- Connects to both mainnet and devnet.
30-
- Option for additional profiles (separate profiles for different ARK addresses or networks).
31-
- Option to add contacts and easily transact with them.
32-
- Total balance of your combined ARK addresses.
33-
- Wallet backup - input your selected PIN to decrypt your wallet and gain view of your private data.
34-
- Change PIN - if you want to change your encryption/decryption PIN you can easily do so.
35-
- Clear Data - you can clear all your data from the phone.
36-
- Overview of network status with an option to change peer.
37-
- Current market value, along with weekly movements.
38-
- Support for showing data in different FIAT currencies.
23+
## Installation
3924

40-
## Build
25+
### Node Setup
26+
27+
Download and install [Node.js](https://nodejs.org/).
4128

42-
First follow the steps below to install the dependencies:
29+
Then follow the steps below:
4330

4431
```bash
45-
$ npm install -g ionic cordova@7.1.0
46-
$ npm install
47-
$ ionic cordova prepare
32+
npm install -g ionic cordova
33+
npm install -g cordova-res native-run
34+
npm install
35+
ionic cordova prepare
4836
```
4937

50-
Run on device:
38+
### iOS Setup
39+
40+
Download and install [Xcode](https://developer.apple.com/xcode/).
41+
42+
Then make sure the command-line tools are selected for use:
5143

5244
```bash
53-
$ ionic cordova run ios
54-
$ ionic cordova run android
45+
xcode-select --install
5546
```
5647

57-
Debug in browser:
48+
And you need to install some utilities:
5849

5950
```bash
60-
$ npm run ionic:serve
51+
npm install -g ios-sim
52+
npm install -g ios-deploy
6153
```
6254

63-
## Testing
55+
### Android Setup
56+
57+
Download and install:
58+
59+
- [JDK8](https://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html)
60+
- [Gradle](https://gradle.org/install/)
61+
- [Android Studio](https://developer.android.com/studio/)
62+
63+
Then install Android SDK (API 28) on Android Studio and configure the [environment variables](https://developer.android.com/studio/command-line/variables) (`ANDROID_SDK_ROOT`).
64+
65+
## Usage
66+
67+
Debug in device:
68+
69+
```bash
70+
npm run debug:ios
71+
npm run debug:android
72+
```
73+
74+
Debug in browser (without Cordova plugins):
75+
76+
```bash
77+
npm start
78+
```
79+
80+
## Build
81+
82+
Run the command to create a build for the specific platform:
83+
84+
```bash
85+
npm run build:ios
86+
npm run build:android
87+
```
88+
89+
### iOS Deploy
90+
91+
- Download the `Development` and `Distribution` certificates in [Apple's member center](https://developer.apple.com/membercenter)
92+
- Open Xcode and import the workspace file in `/platforms/ios`
93+
- Check the `Signing and Capabilities` tab to ensure that the `Provisioning Profile` is set correctly
94+
- Go to `Product` > `Archive` in menu.
95+
- Proceed in `Distribute App` wizard.
96+
- `App Store Connect` > `Upload`. Then it will be listed on [iTunes Connect](https://itunesconnect.apple.com/)
97+
- `App Store Connect` > `Export` to create the `.ipa` file
98+
99+
### Android Deploy
100+
101+
- Open the output directory `cd platforms/android/build/outputs/apk`
102+
- Generate a private key to sign the APK (skip this if you already have one):
64103

65-
To run the unit tests:
66104
```bash
67-
$ npm test
105+
keytool -genkey -v -keystore release-key.keystore -alias ark -keyalg RSA -keysize 2048 -validity 10000
68106
```
69107

70-
To run the unit tests and watch them:
108+
- Sign the unsigned APK:
109+
71110
```bash
72-
$ npm run test:unit
111+
jarsigner -verbose -sigalg SHA1withRSA -digestalg SHA1 -keystore ./release-key.keystore app-release-unsigned.apk mobile-app
73112
```
74113

75-
To run the unit tests and generate a coverage report:
114+
- Optimize the APK:
115+
76116
```bash
77-
$ npm run test:coverage
117+
zipalign -v 4 app-release-unsigned.apk AppRelease.apk
78118
```
79119

80-
To run the E2E (end to end) tests:
120+
- Open the [Google Play Store Developer Console](https://play.google.com/apps/publish) and upload the `AppRelease.apk`
121+
122+
## Testing
123+
81124
```bash
82-
$ npm run test:e2e
125+
npm test
83126
```
84127

85128
## Contributing
86129

87130
- If you find any bugs, submit an [issue](../../issues) or open [pull-request](../../pulls), helping us catch and fix them.
88131
- Engage with other users and developers on [ARK Slack](https://ark.io/slack/).
89-
- Join to our [gitter](https://gitter.im/ark-developers/Lobby).
90132
- [Contribution bounties](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html).
91133
- [Help translate](./TRANSLATING.md).
92134

@@ -100,4 +142,4 @@ This project exists thanks to all the people who [contribute](../../contributors
100142

101143
## License
102144

103-
[MIT](LICENSE) © [ARK Ecosystem](https://ark.io)
145+
[MIT](LICENSE) © [ARK Ecosystem](https://ark.io)

0 commit comments

Comments
 (0)