Skip to content

Commit d834367

Browse files
authored
Merge pull request #2163 from armwaheed/main
Peer review changes
2 parents dc06dba + 7f7c26d commit d834367

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

content/learning-paths/automotive/openadkit2_safetyisolation/3_container_spliting.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ To enable ROS 2 and DDS communication between the two nodes, configure network a
5555
If you are using AWS EC2, both instances should be assigned to the same Security Group.
5656

5757
Within the EC2 Security Group settings:
58-
- Add an inbound rule that allows all traffic from the same Security Group by setting he source to the security group itself.
58+
- Add an inbound rule that allows all traffic from the same Security Group by setting the source to the security group itself.
5959
- Outbound traffic is typically allowed by default and usually does not require changes.
6060

6161
![img2 alt-text#center](security_group.jpg "Figure 2: AWS Security Group Setting")
@@ -185,7 +185,7 @@ To ensure that each container uses your custom DDS configuration, mount the curr
185185
186186
Add this to every container definition to ensure consistent behavior across the deployment.
187187
188-
Here is the complete XML file:
188+
Here is the complete YAML file:
189189
190190
```YAML
191191
services:
@@ -353,7 +353,7 @@ export TIMEOUT=300
353353
docker compose -f docker-compose-2ins.yml run --rm simulator bash
354354
```
355355

356-
Once inside the container shell, activate the ROS 2 environment and start publishing to the /hello topic:
356+
Once inside the container shell, activate the ROS 2 environment and start listening to the /hello topic:
357357

358358
```bash
359359
# Inside the container:

content/learning-paths/automotive/openadkit2_safetyisolation/4_multiinstance_executing.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au
2727
!/bin/bash
2828
# Configure the environment variables
2929
export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker
30-
CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml
31-
CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml
30+
export CONF_FILE_PASS=$SCRIPT_DIR/etc/simulation/config/pass_static_obstacle_avoidance.param.yaml
31+
export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml
3232

3333
export CONF_FILE=$CONF_FILE_FAIL
3434
export COMMON_FILE=$SCRIPT_DIR/etc/simulation/config/common.param.yaml
@@ -42,7 +42,7 @@ On each instance, copy the appropriate launch script into the `openadkit_demo.au
4242

4343
{{< tab header="Visualizer & Simulator" language="bash">}}
4444
#!/bin/bash
45-
SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker
45+
export SCRIPT_DIR=/home/ubuntu/openadkit_demo.autoware/docker
4646

4747
export CONF_FILE_FAIL=$SCRIPT_DIR/etc/simulation/config/fail_static_obstacle_avoidance.param.yaml
4848
export CONF_FILE=$CONF_FILE_FAIL

0 commit comments

Comments
 (0)