fix all elixir warnings

Author: ArneVogel

MnesiaCore.nonode@nohost_1771_775270_959299

@@ -47,7 +47,7 @@ config :listudy, :pow,
   cache_store_backend: Pow.Store.Backend.MnesiaCache,
   messages_backend: ListudyWeb.Pow.Messages
 
-config :mnesia, dir: 'priv/mnesia'
+config :mnesia, dir: ~c"priv/mnesia"
 
 config :gettext, :default_locale, "en"
 

config/config.exs

@@ -28,8 +28,6 @@ defmodule Listudy.Users.User do
   end
 
   def admin_changeset(user_or_changeset, attrs) do
-    import Ecto.Changeset
-
     user_or_changeset
     |> Ecto.Changeset.cast(attrs, [:username, :email])
   end

lib/listudy/users/user.ex

@@ -3,7 +3,7 @@ defmodule ListudyWeb.PageController do
   alias Listudy.Books
   alias Listudy.Content
 
-  @languages Application.get_env(:listudy, :languages)[:translations]
+  @languages Application.compile_env(:listudy, [:languages, :translations])
   @pages [
     "privacy",
     "terms-of-service",

lib/listudy_web/controllers/page_controller.ex

@@ -1,8 +1,8 @@
 defmodule ListudyWeb.Plugs.Locale do
   import Plug.Conn
 
-  @locales Application.get_env(:listudy, :languages)[:translations]
-  @default Application.get_env(:listudy, :languages)[:default]
+  @locales Application.compile_env(:listudy, [:languages, :translations])
+  @default Application.compile_env(:listudy, [:languages, :default])
 
   def init(default), do: default
 

lib/listudy_web/plugs/locale.ex

@@ -55,7 +55,6 @@ defmodule ListudyWeb.Router do
     post "/blog", PostController, :create
     put "/blog/:id", PostController, :update
     delete "/blog/:id", PostController, :delete
-    get "/", PageController, :index
 
     get "/update-email/:username", UserAdministrationController, :email
     put "/update-email/:username", UserAdministrationController, :update_email

lib/listudy_web/router.ex

@@ -39,8 +39,8 @@
   <input type="text" id="last_move" value="">
 </form>
 <script <%= raw ListudyWeb.Plugs.CSP.put_nonce(@conn) %>>
-<%# CAREFUL! the hash is user supplies and its values can only be used in %>
-<%# save javascript functions! %>
+<%!-- CAREFUL! the hash is user supplies and its values can only be used in --%>
+<%!-- save javascript functions! --%>
 function clean_input(i) {
   if (i == undefined) {
     return "";

lib/listudy_web/templates/iframe/custom_tactic.html.eex

@@ -35,8 +35,8 @@
 
     <script defer type="text/javascript" src="<%= Routes.static_path(@conn, "/js/app.js") %>"></script>
     <script <%= raw ListudyWeb.Plugs.CSP.put_nonce(@conn) %>>
-      <%# This is here to stop the default white theme to flash on load %>
-      <%# In the defered app.js script it would only switch after the page is loaded %>
+      <%!-- This is here to stop the default white theme to flash on load --%>
+      <%!-- In the defered app.js script it would only switch after the page is loaded --%>
       let theme = localStorage.getItem("data-theme") || "light";
       localStorage.setItem("data-theme", theme);
       document.documentElement.setAttribute('data-theme', theme);
@@ -56,12 +56,12 @@
 
     </script>
 
-    <%# Favicon start, generated with https://realfavicongenerator.net/%>
+    <%!-- Favicon start, generated with https://realfavicongenerator.net/ --%>
     <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
     <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
     <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
     <link rel="manifest" href="/site.webmanifest">
     <link rel="mask-icon" href="/safari-pinned-tab.svg" color="#5bbad5">
     <meta name="msapplication-TileColor" content="#2b5797">
     <meta name="theme-color" content="#ffffff">
-    <%# Favicon end %>
+    <%!-- Favicon end --%>

lib/listudy_web/templates/layout/_head.html.eex

@@ -6,7 +6,7 @@
 <% end %>
 </p>
 
-<%# required by PgnViewerJS, has to be set before the include of pgnv.js %>
+<%!-- required by PgnViewerJS, has to be set before the include of pgnv.js --%>
 <script <%= raw ListudyWeb.Plugs.CSP.put_nonce(@conn) %>>__globalCustomDomain = '/js/pgnviewer/';</script>
 
 <%= raw ListudyWeb.EexMarkdown.as_html(@post.body, @conn)%>

lib/listudy_web/templates/post/show.html.eex

@@ -33,7 +33,7 @@
     <%= if !@study.favorites do %>
       <%= link dgettext("study", "Favorite study"), to: Routes.study_path(@conn, :favorite_study, @study.slug), method: :post, class: "icon", "data-icon": "#" %>
     <% else %>
-      <%= link dgettext("study" ,"Unfavorite study"), to: Routes.study_path(@conn, :unfavorite_study, @study.slug), method: :post, class: "icon", "data-icon": '"' %>
+      <%= link dgettext("study" ,"Unfavorite study"), to: Routes.study_path(@conn, :unfavorite_study, @study.slug), method: :post, class: "icon", "data-icon": "\"" %>
     <% end %>
   </div>
   <div class="option_item">