Merge branch 'KomputeProject:master' into master

ArnoChenFx · web-flow · commit 940ce3278348 · 2025-02-27T00:18:37.000+08:00
diff --git a/src/Algorithm.cpp b/src/Algorithm.cpp
@@ -6,7 +6,7 @@
 
 namespace kp {
 
-Algorithm::~Algorithm()
+Algorithm::~Algorithm() noexcept
 {
     KP_LOG_DEBUG("Kompute Algorithm Destructor started");
 
diff --git a/src/OpAlgoDispatch.cpp b/src/OpAlgoDispatch.cpp
@@ -4,7 +4,7 @@
 
 namespace kp {
 
-OpAlgoDispatch::~OpAlgoDispatch()
+OpAlgoDispatch::~OpAlgoDispatch() noexcept
 {
     KP_LOG_DEBUG("Kompute OpAlgoDispatch destructor started");
 
diff --git a/src/OpCopy.cpp b/src/OpCopy.cpp
@@ -18,7 +18,7 @@ OpCopy::OpCopy(const std::vector<std::shared_ptr<Memory>>& memObjects)
     this->mMemObjects = memObjects;
 }
 
-OpCopy::~OpCopy()
+OpCopy::~OpCopy() noexcept
 {
     KP_LOG_DEBUG("Kompute OpCopy destructor started");
 }
diff --git a/src/OpMemoryBarrier.cpp b/src/OpMemoryBarrier.cpp
@@ -10,7 +10,7 @@ OpMemoryBarrier::OpMemoryBarrier(
   const vk::AccessFlagBits& dstAccessMask,
   const vk::PipelineStageFlagBits& srcStageMask,
   const vk::PipelineStageFlagBits& dstStageMask,
-  bool barrierOnPrimary)
+  bool barrierOnPrimary) noexcept
   : mSrcAccessMask(srcAccessMask)
   , mDstAccessMask(dstAccessMask)
   , mSrcStageMask(srcStageMask)
@@ -21,7 +21,7 @@ OpMemoryBarrier::OpMemoryBarrier(
     KP_LOG_DEBUG("Kompute OpMemoryBarrier constructor");
 }
 
-OpMemoryBarrier::~OpMemoryBarrier()
+OpMemoryBarrier::~OpMemoryBarrier() noexcept
 {
     KP_LOG_DEBUG("Kompute OpMemoryBarrier destructor started");
 }
diff --git a/src/OpSyncDevice.cpp b/src/OpSyncDevice.cpp
@@ -17,7 +17,7 @@ OpSyncDevice::OpSyncDevice(
     this->mMemObjects = memObjects;
 }
 
-OpSyncDevice::~OpSyncDevice()
+OpSyncDevice::~OpSyncDevice() noexcept
 {
     KP_LOG_DEBUG("Kompute OpSyncDevice destructor started");
 
diff --git a/src/OpSyncLocal.cpp b/src/OpSyncLocal.cpp
@@ -18,7 +18,7 @@ OpSyncLocal::OpSyncLocal(const std::vector<std::shared_ptr<Memory>>& memObjects)
     this->mMemObjects = memObjects;
 }
 
-OpSyncLocal::~OpSyncLocal()
+OpSyncLocal::~OpSyncLocal() noexcept
 {
     KP_LOG_DEBUG("Kompute OpSyncLocal destructor started");
 }
diff --git a/src/Sequence.cpp b/src/Sequence.cpp
@@ -8,7 +8,7 @@ Sequence::Sequence(std::shared_ptr<vk::PhysicalDevice> physicalDevice,
                    std::shared_ptr<vk::Device> device,
                    std::shared_ptr<vk::Queue> computeQueue,
                    uint32_t queueIndex,
-                   uint32_t totalTimestamps)
+                   uint32_t totalTimestamps) noexcept
 {
     KP_LOG_DEBUG("Kompute Sequence Constructor with existing device & queue");
 
@@ -25,7 +25,7 @@ Sequence::Sequence(std::shared_ptr<vk::PhysicalDevice> physicalDevice,
                                        1); //+1 for the first one
 }
 
-Sequence::~Sequence()
+Sequence::~Sequence() noexcept
 {
     KP_LOG_DEBUG("Kompute Sequence Destructor started");
 
diff --git a/src/include/kompute/Algorithm.hpp b/src/include/kompute/Algorithm.hpp
@@ -40,7 +40,7 @@ class Algorithm
               const std::vector<uint32_t>& spirv = {},
               const Workgroup& workgroup = {},
               const std::vector<S>& specializationConstants = {},
-              const std::vector<P>& pushConstants = {})
+              const std::vector<P>& pushConstants = {}) noexcept
     {
         KP_LOG_DEBUG("Kompute Algorithm Constructor with device");
 
@@ -136,11 +136,21 @@ class Algorithm
         this->createPipeline();
     }
 
+    /**
+     * @brief Make Algorithm uncopyable
+     *
+     */
+    Algorithm(const Algorithm&) = delete;
+    Algorithm(const Algorithm&&) = delete;
+    Algorithm& operator=(const Algorithm&) = delete;
+    Algorithm& operator=(const Algorithm&&) = delete;
+
+
     /**
      * Destructor for Algorithm which is responsible for freeing and desroying
      * respective pipelines and owned parameter groups.
      */
-    ~Algorithm();
+    ~Algorithm() noexcept;
 
     /**
      * Records the dispatch function with the provided template parameters or
diff --git a/src/include/kompute/Image.hpp b/src/include/kompute/Image.hpp
@@ -164,6 +164,16 @@ class Image : public Memory
     {
     }
 
+
+    /**
+     * @brief Make Image uncopyable
+     *
+     */
+    Image(const Image&) = delete;
+    Image(const Image&&) = delete;
+    Image& operator=(const Image&) = delete;
+    Image& operator=(const Image&&) = delete;
+
     /**
      * Destructor which is in charge of freeing vulkan resources unless they
      * have been provided externally.
diff --git a/src/include/kompute/Manager.hpp b/src/include/kompute/Manager.hpp
@@ -50,6 +50,16 @@ class Manager
             std::shared_ptr<vk::PhysicalDevice> physicalDevice,
             std::shared_ptr<vk::Device> device);
 
+
+    /**
+     * @brief Make Manager uncopyable
+     *
+     */
+    Manager(const Manager&) = delete;
+    Manager(const Manager&&) = delete;
+    Manager& operator=(const Manager&) = delete;
+    Manager& operator=(const Manager&&) = delete;
+
     /**
      * Manager destructor which would ensure all owned resources are destroyed
      * unless explicitly stated that resources should not be destroyed or freed.
diff --git a/src/include/kompute/Memory.hpp b/src/include/kompute/Memory.hpp
@@ -63,6 +63,16 @@ class Memory
            uint32_t x,
            uint32_t y);
 
+
+    /**
+     * @brief Make Memory uncopyable
+     *
+     */
+    Memory(const Memory&) = delete;
+    Memory(const Memory&&) = delete;
+    Memory& operator=(const Memory&) = delete;
+    Memory& operator=(const Memory&&) = delete;
+
     /**
      * Destructor which is in charge of freeing vulkan resources unless they
      * have been provided externally.
diff --git a/src/include/kompute/Sequence.hpp b/src/include/kompute/Sequence.hpp
@@ -28,12 +28,22 @@ class Sequence : public std::enable_shared_from_this<Sequence>
              std::shared_ptr<vk::Device> device,
              std::shared_ptr<vk::Queue> computeQueue,
              uint32_t queueIndex,
-             uint32_t totalTimestamps = 0);
+             uint32_t totalTimestamps = 0) noexcept;
+
+    /**
+     * @brief Make Sequence uncopyable
+     *
+     */
+    Sequence(const Sequence&) = delete;
+    Sequence(const Sequence&&) = delete;
+    Sequence& operator=(const Sequence&) = delete;
+    Sequence& operator=(const Sequence&&) = delete;
+
     /**
      * Destructor for sequence which is responsible for cleaning all subsequent
      * owned operations.
      */
-    ~Sequence();
+    ~Sequence() noexcept;
 
     /**
      * Record function for operation to be added to the GPU queue in batch. This
diff --git a/src/include/kompute/Tensor.hpp b/src/include/kompute/Tensor.hpp
@@ -57,6 +57,15 @@ class Tensor : public Memory
            const DataTypes& dataType,
            const MemoryTypes& memoryType = MemoryTypes::eDevice);
 
+    /**
+     * @brief Make Tensor uncopyable
+     *
+     */
+    Tensor(const Tensor&) = delete;
+    Tensor(const Tensor&&) = delete;
+    Tensor& operator=(const Tensor&) = delete;
+    Tensor& operator=(const Tensor&&) = delete;
+
     /**
      * Destructor which is in charge of freeing vulkan resources unless they
      * have been provided externally.
@@ -250,6 +259,16 @@ class TensorT : public Tensor
                      data.size());
     }
 
+    /**
+     * @brief Make TensorT uncopyable
+     *
+     */
+    TensorT(const TensorT&) = delete;
+    TensorT(const TensorT&&) = delete;
+    TensorT& operator=(const TensorT&) = delete;
+    TensorT& operator=(const TensorT&&) = delete;
+
+
     ~TensorT() { KP_LOG_DEBUG("Kompute TensorT destructor"); }
 
     DataTypes dataType() { return Memory::dataType<T>(); }
diff --git a/src/include/kompute/operations/OpAlgoDispatch.hpp b/src/include/kompute/operations/OpAlgoDispatch.hpp
@@ -26,7 +26,7 @@ class OpAlgoDispatch : public OpBase
      */
     template<typename T = float>
     OpAlgoDispatch(const std::shared_ptr<kp::Algorithm>& algorithm,
-                   const std::vector<T>& pushConstants = {})
+                   const std::vector<T>& pushConstants = {}) noexcept
     {
         KP_LOG_DEBUG("Kompute OpAlgoDispatch constructor");
 
@@ -43,11 +43,21 @@ class OpAlgoDispatch : public OpBase
         }
     }
 
+    /**
+     * @brief Make OpAlgoDispatch non-copyable
+     *
+     */
+    OpAlgoDispatch(const OpAlgoDispatch&) = delete;
+    OpAlgoDispatch(const OpAlgoDispatch&&) = delete;
+    OpAlgoDispatch& operator=(const OpAlgoDispatch&) = delete;
+    OpAlgoDispatch& operator=(const OpAlgoDispatch&&) = delete;
+
+
     /**
      * Default destructor, which is in charge of destroying the algorithm
      * components but does not destroy the underlying tensors
      */
-    virtual ~OpAlgoDispatch() override;
+    virtual ~OpAlgoDispatch() noexcept override;
 
     /**
      * This records the commands that are to be sent to the GPU. This includes
diff --git a/src/include/kompute/operations/OpBase.hpp b/src/include/kompute/operations/OpBase.hpp
@@ -19,12 +19,27 @@ namespace kp {
 class OpBase
 {
   public:
+      /**
+     * @brief Construct a new OpBase object
+     *
+     */
+    OpBase() = default;
+
+    /**
+     * @brief Make OpBase non-copyable
+     *
+     */
+    OpBase(const OpBase&) = delete;
+    OpBase(const OpBase&&) = delete;
+    OpBase& operator=(const OpBase&) = delete;
+    OpBase& operator=(const OpBase&&) = delete;
+
     /**
      * Default destructor for OpBase class. This OpBase destructor class should
      * always be called to destroy and free owned resources unless it is
      * intended to destroy the resources in the parent class.
      */
-    virtual ~OpBase() { KP_LOG_DEBUG("Kompute OpBase destructor started"); }
+    virtual ~OpBase() noexcept { KP_LOG_DEBUG("Kompute OpBase destructor started"); }
 
     /**
      * The record function is intended to only send a record command or run
diff --git a/src/include/kompute/operations/OpCopy.hpp b/src/include/kompute/operations/OpCopy.hpp
@@ -26,11 +26,20 @@ class OpCopy : public OpBase
      */
     OpCopy(const std::vector<std::shared_ptr<Memory>>& memObjects);
 
+    /**
+     * @brief Make OpCopy non-copyable
+     *
+     */
+    OpCopy(const OpCopy&) = delete;
+    OpCopy(const OpCopy&&) = delete;
+    OpCopy& operator=(const OpCopy&) = delete;
+    OpCopy& operator=(const OpCopy&&) = delete;
+
     /**
      * Default destructor. This class does not manage memory so it won't be
      * expecting the parent to perform a release.
      */
-    ~OpCopy() override;
+    ~OpCopy() noexcept override;
 
     /**
      * Records the copy commands from the first memory object into all the other
diff --git a/src/include/kompute/operations/OpMemoryBarrier.hpp b/src/include/kompute/operations/OpMemoryBarrier.hpp
@@ -39,7 +39,16 @@ class OpMemoryBarrier : public OpBase
                     const vk::AccessFlagBits& dstAccessMask,
                     const vk::PipelineStageFlagBits& srcStageMask,
                     const vk::PipelineStageFlagBits& dstStageMask,
-                    bool barrierOnPrimary = true);
+                    bool barrierOnPrimary = true) noexcept;
+
+    /**
+     * @brief Make OpMemoryBarrier non-copyable
+     *
+     */
+    OpMemoryBarrier(const OpMemoryBarrier&) = delete;
+    OpMemoryBarrier(const OpMemoryBarrier&&) = delete;
+    OpMemoryBarrier& operator=(const OpMemoryBarrier&) = delete;
+    OpMemoryBarrier& operator=(const OpMemoryBarrier&&) = delete;
 
     /**
      * Default destructor, which is in charge of destroying the reference to the
diff --git a/src/include/kompute/operations/OpMult.hpp b/src/include/kompute/operations/OpMult.hpp
@@ -48,11 +48,20 @@ class OpMult : public OpAlgoDispatch
         algorithm->rebuild<>(memObjects, spirv);
     }
 
+    /**
+     * @brief Make OpMult non-copyable
+     *
+     */
+    OpMult(const OpMult&) = delete;
+    OpMult(const OpMult&&) = delete;
+    OpMult& operator=(const OpMult&) = delete;
+    OpMult& operator=(const OpMult&&) = delete;
+
     /**
      * Default destructor, which is in charge of destroying the algorithm
      * components but does not destroy the underlying tensors
      */
-    ~OpMult() override { KP_LOG_DEBUG("Kompute OpMult destructor started"); }
+    ~OpMult() noexcept override { KP_LOG_DEBUG("Kompute OpMult destructor started"); }
 };
 
 } // End namespace kp
diff --git a/src/include/kompute/operations/OpSyncDevice.hpp b/src/include/kompute/operations/OpSyncDevice.hpp
@@ -28,11 +28,21 @@ class OpSyncDevice : public OpBase
      */
     OpSyncDevice(const std::vector<std::shared_ptr<Memory>>& memObjects);
 
+    /**
+     * @brief Make OpSyncDevice non-copyable
+     *
+     */
+    OpSyncDevice(const OpSyncDevice&) = delete;
+    OpSyncDevice(const OpSyncDevice&&) = delete;
+    OpSyncDevice& operator=(const OpSyncDevice&) = delete;
+    OpSyncDevice& operator=(const OpSyncDevice&&) = delete;
+
+
     /**
      * Default destructor. This class does not manage memory so it won't be
      * expecting the parent to perform a release.
      */
-    ~OpSyncDevice() override;
+    ~OpSyncDevice() noexcept override;
 
     /**
      * For device memory objects, it records the copy command for the memory
diff --git a/src/include/kompute/operations/OpSyncLocal.hpp b/src/include/kompute/operations/OpSyncLocal.hpp
@@ -30,11 +30,20 @@ class OpSyncLocal : public OpBase
      */
     OpSyncLocal(const std::vector<std::shared_ptr<Memory>>& memObjects);
 
+    /**
+     * @brief Make OpSyncLocal non-copyable
+     *
+     */
+    OpSyncLocal(const OpSyncLocal&) = delete;
+    OpSyncLocal(const OpSyncLocal&&) = delete;
+    OpSyncLocal& operator=(const OpSyncLocal&) = delete;
+    OpSyncLocal& operator=(const OpSyncLocal&&) = delete;
+
     /**
      * Default destructor. This class does not manage memory so it won't be
      * expecting the parent to perform a release.
      */
-    ~OpSyncLocal() override;
+    ~OpSyncLocal() noexcept override;
 
     /**
      * For device memory objects, it records the copy command for the tensor to

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace kp {`
`8`	`8`
`9`		`-Algorithm::~Algorithm()`
	`9`	`+Algorithm::~Algorithm() noexcept`
`10`	`10`	`{`
`11`	`11`	`KP_LOG_DEBUG("Kompute Algorithm Destructor started");`
`12`	`12`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace kp {`
`6`	`6`
`7`		`-OpAlgoDispatch::~OpAlgoDispatch()`
	`7`	`+OpAlgoDispatch::~OpAlgoDispatch() noexcept`
`8`	`8`	`{`
`9`	`9`	`KP_LOG_DEBUG("Kompute OpAlgoDispatch destructor started");`
`10`	`10`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ OpCopy::OpCopy(const std::vector<std::shared_ptr<Memory>>& memObjects)`
`18`	`18`	`this->mMemObjects = memObjects;`
`19`	`19`	`}`
`20`	`20`
`21`		`-OpCopy::~OpCopy()`
	`21`	`+OpCopy::~OpCopy() noexcept`
`22`	`22`	`{`
`23`	`23`	`KP_LOG_DEBUG("Kompute OpCopy destructor started");`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ OpMemoryBarrier::OpMemoryBarrier(`
`10`	`10`	`const vk::AccessFlagBits& dstAccessMask,`
`11`	`11`	`const vk::PipelineStageFlagBits& srcStageMask,`
`12`	`12`	`const vk::PipelineStageFlagBits& dstStageMask,`
`13`		`- bool barrierOnPrimary)`
	`13`	`+ bool barrierOnPrimary) noexcept`
`14`	`14`	`: mSrcAccessMask(srcAccessMask)`
`15`	`15`	`, mDstAccessMask(dstAccessMask)`
`16`	`16`	`, mSrcStageMask(srcStageMask)`
`@@ -21,7 +21,7 @@ OpMemoryBarrier::OpMemoryBarrier(`
`21`	`21`	`KP_LOG_DEBUG("Kompute OpMemoryBarrier constructor");`
`22`	`22`	`}`
`23`	`23`
`24`		`-OpMemoryBarrier::~OpMemoryBarrier()`
	`24`	`+OpMemoryBarrier::~OpMemoryBarrier() noexcept`
`25`	`25`	`{`
`26`	`26`	`KP_LOG_DEBUG("Kompute OpMemoryBarrier destructor started");`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ OpSyncDevice::OpSyncDevice(`
`17`	`17`	`this->mMemObjects = memObjects;`
`18`	`18`	`}`
`19`	`19`
`20`		`-OpSyncDevice::~OpSyncDevice()`
	`20`	`+OpSyncDevice::~OpSyncDevice() noexcept`
`21`	`21`	`{`
`22`	`22`	`KP_LOG_DEBUG("Kompute OpSyncDevice destructor started");`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ OpSyncLocal::OpSyncLocal(const std::vector<std::shared_ptr<Memory>>& memObjects)`
`18`	`18`	`this->mMemObjects = memObjects;`
`19`	`19`	`}`
`20`	`20`
`21`		`-OpSyncLocal::~OpSyncLocal()`
	`21`	`+OpSyncLocal::~OpSyncLocal() noexcept`
`22`	`22`	`{`
`23`	`23`	`KP_LOG_DEBUG("Kompute OpSyncLocal destructor started");`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ Sequence::Sequence(std::shared_ptr<vk::PhysicalDevice> physicalDevice,`
`8`	`8`	`std::shared_ptr<vk::Device> device,`
`9`	`9`	`std::shared_ptr<vk::Queue> computeQueue,`
`10`	`10`	`uint32_t queueIndex,`
`11`		`- uint32_t totalTimestamps)`
	`11`	`+ uint32_t totalTimestamps) noexcept`
`12`	`12`	`{`
`13`	`13`	`KP_LOG_DEBUG("Kompute Sequence Constructor with existing device & queue");`
`14`	`14`
`@@ -25,7 +25,7 @@ Sequence::Sequence(std::shared_ptr<vk::PhysicalDevice> physicalDevice,`
`25`	`25`	`1); //+1 for the first one`
`26`	`26`	`}`
`27`	`27`
`28`		`-Sequence::~Sequence()`
	`28`	`+Sequence::~Sequence() noexcept`
`29`	`29`	`{`
`30`	`30`	`KP_LOG_DEBUG("Kompute Sequence Destructor started");`
`31`	`31`