-fixed broken test

-added more tests

Author: AronDavis

FInt/FInt.cs

@@ -300,10 +300,15 @@ old method (so we can compare in tests)
 
 	public static FInt operator / (FInt left, FInt right)
 	{
-		//TODO: overflow check on right being < 0?
+		if(right._value == 0)
+		{
+			throw new DivideByZeroException();
+		}
+
+		//TODO: overflow check +/- values that approach min/max values (like +right < 1)?
 
 		long whole = left._value / right._value;
-		long remainder = _SCALE * (left._value - whole * right._value);
+		long remainder = _SCALE * (left._value - (whole * right._value));  //TODO: if we wanted to round the last digit, we could * 10, round based on the last digit, then truncate the last digit (e.g. 2/3 -> 6666666 -> 6666670 -> 666667)
 		remainder /= right._value;
 
 		return new FInt(whole * _SCALE + remainder, UseScale.None);

Tests/ConstructorTests.cs

@@ -36,7 +36,7 @@ public void LongConstructor_ShouldEqualLong()
         [TestMethod]
         public void LongConstructor_ThrowsOnOverflow()
         {
-            Assert.ThrowsException<ArgumentException>(() => new FInt(long.MaxValue));
+            Assert.ThrowsException<OverflowException>(() => new FInt(long.MaxValue));
         }
     }
 }

Tests/DivisionTests.cs

@@ -6,7 +6,6 @@ namespace Tests
     public class DivisionTests
     {
         [DataTestMethod]
-        [DataRow(0, 1, 0, 0)]
         [DataRow(1, 2, 0, 5)]
         [DataRow(1, 4, 0, 25)]
         [DataRow(3, 2, 1, 5)]
@@ -53,5 +52,40 @@ void assertDivision(int l, int r, int e)
             assertDivision(left, -right, -expectedResult);
             assertDivision(-left, -right, expectedResult);
         }
+
+        [DataTestMethod]
+        [DataRow(1, 2, 1, 4, 2, 0)]
+        [DataRow(2, 10, 3, 10, 0, 666666)]
+        public void DivisionWithFractions_ShouldWorkAsExpected(int left, int right, int left2, int right2, int expectedWhole, int expectedDecimal)
+        {
+            void assertDivision(FInt l, FInt r, int ew, int ed)
+            {
+                FInt result = l / r;
+
+                FInt shiftedDecimal = ed;
+
+                while (shiftedDecimal.Decimal != 0)
+                {
+                    shiftedDecimal *= 10;
+                }
+
+                Assert.AreEqual(ew.FI(), result.Sign * ((result.Sign * result) - result.Decimal));
+                Assert.AreEqual(ed.FI(), shiftedDecimal);
+            }
+
+            FInt numerator = left.FI() / right.FI();
+            FInt denominator = left2.FI() / right2.FI();
+
+            assertDivision(numerator, denominator, expectedWhole, expectedDecimal);
+            assertDivision(-numerator, denominator, -expectedWhole, expectedDecimal);
+            assertDivision(numerator, -denominator, -expectedWhole, expectedDecimal);
+            assertDivision(-numerator, -denominator, expectedWhole, expectedDecimal);
+        }
+
+        [TestMethod]
+        public void DivisionByZero_ShouldThrowException()
+        {
+            Assert.ThrowsException<DivideByZeroException>(() => 1.FI() / 0.FI());
+        }
     }
 }