3.0.2

Power display fix (Faction.java, AdminCommand.java) — Added fillBasePower() and /f admin power recalc to reset all factions' stored base power to the current config max, fixing old factions showing stale power values after a config change.

Max power display fix — Was missing the max fame value.

Special character validation (CreateCommand.java, ModifyCommand.java) — Faction names now reject *, ", \, and § to prevent command parsing failures like "The Boot *Stink Warning*".

Suggestion filtering fix (Command.java) — Fixed greedyString() suggestions always showing all results by computing the correct remaining text from parsed context nodes instead of relying on builder.getStart(), which points to the end of input for greedy arguments.

Author: Arona74

gradle.properties

@@ -6,7 +6,7 @@ yarn_mappings=1.20.1+build.10
 loader_version=0.14.22
 
 # Mod Properties
-mod_version = 3.0.1
+mod_version = 3.0.2
 maven_group = io.icker
 archives_base_name = factions
 

src/main/java/io/icker/factions/api/persistents/Faction.java

@@ -672,8 +672,12 @@ public static void save() {
         Database.save(Faction.class, STORE.values().stream().toList());
     }
 
+    public void fillBasePower() {
+        power = getBasePowerMax();
+    }
+
     public int calculateMaxPower() {
-        return getBasePowerMax() + adminPower + FactionsMod.CONFIG.POWER.WEALTH.MAX_VALUE + FactionsMod.CONFIG.POWER.WAR.MAX_VALUE + getVassalPowerBonus();
+        return getBasePowerMax() + adminPower + FactionsMod.CONFIG.POWER.WEALTH.MAX_VALUE + FactionsMod.CONFIG.POWER.WAR.MAX_VALUE + FactionsMod.CONFIG.POWER.FAME.MAX_VALUE + getVassalPowerBonus();
     }
 
     public Collection<User> getRelationships() {

src/main/java/io/icker/factions/command/AdminCommand.java

@@ -72,6 +72,17 @@ private int power(CommandContext<ServerCommandSource> context) throws CommandSyn
         return 1;
     }
 
+    private int powerRecalc(CommandContext<ServerCommandSource> context) throws CommandSyntaxException {
+        ServerPlayerEntity player = context.getSource().getPlayerOrThrow();
+        int count = 0;
+        for (Faction faction : Faction.all()) {
+            faction.fillBasePower();
+            count++;
+        }
+        new Message("Recalculated base power for %d factions", count).send(player, false);
+        return 1;
+    }
+
     private int spoof(CommandContext<ServerCommandSource> context) throws CommandSyntaxException {
         ServerCommandSource source = context.getSource();
         ServerPlayerEntity player = source.getPlayerOrThrow();
@@ -625,6 +636,8 @@ public LiteralCommandNode<ServerCommandSource> getNode() {
                         .requires(
                                 Requires.hasPerms("factions.admin.power",
                                         FactionsMod.CONFIG.REQUIRED_BYPASS_LEVEL))
+                        .then(CommandManager.literal("recalc")
+                                .executes(this::powerRecalc))
                         .then(CommandManager.argument("power", IntegerArgumentType.integer())
                                 .then(CommandManager
                                         .argument("faction", StringArgumentType.greedyString())

src/main/java/io/icker/factions/command/CreateCommand.java

@@ -1,6 +1,7 @@
 package io.icker.factions.command;
 
 import java.util.Locale;
+import java.util.regex.Pattern;
 import com.mojang.brigadier.arguments.StringArgumentType;
 import com.mojang.brigadier.context.CommandContext;
 import com.mojang.brigadier.exceptions.CommandSyntaxException;
@@ -16,12 +17,20 @@
 import net.minecraft.util.Formatting;
 
 public class CreateCommand implements Command {
+    private static final Pattern ILLEGAL_NAME_CHARS = Pattern.compile("[*\"\\\\§]");
+
     private int run(CommandContext<ServerCommandSource> context) throws CommandSyntaxException {
         String name = StringArgumentType.getString(context, "name");
 
         ServerCommandSource source = context.getSource();
         ServerPlayerEntity player = source.getPlayerOrThrow();
 
+        if (ILLEGAL_NAME_CHARS.matcher(name).find()) {
+            new Message("Faction name cannot contain special characters: * \" \\ §").fail()
+                    .send(player, false);
+            return 0;
+        }
+
         if (FactionsMod.CONFIG.DISPLAY.NAME_BLACKLIST.contains(name.toLowerCase(Locale.ROOT))) {
             new Message("Cannot create a faction with this name as it is on the blacklist").fail()
                     .send(player, false);

src/main/java/io/icker/factions/command/ModifyCommand.java

@@ -1,6 +1,7 @@
 package io.icker.factions.command;
 
 import java.util.Locale;
+import java.util.regex.Pattern;
 import com.mojang.brigadier.arguments.BoolArgumentType;
 import com.mojang.brigadier.arguments.StringArgumentType;
 import com.mojang.brigadier.context.CommandContext;
@@ -17,12 +18,20 @@
 import net.minecraft.util.Formatting;
 
 public class ModifyCommand implements Command {
+    private static final Pattern ILLEGAL_NAME_CHARS = Pattern.compile("[*\"\\\\§]");
+
     private int name(CommandContext<ServerCommandSource> context) throws CommandSyntaxException {
         String name = StringArgumentType.getString(context, "name");
 
         ServerCommandSource source = context.getSource();
         ServerPlayerEntity player = source.getPlayerOrThrow();
 
+        if (ILLEGAL_NAME_CHARS.matcher(name).find()) {
+            new Message("Faction name cannot contain special characters: * \" \\ §").fail()
+                    .send(player, false);
+            return 0;
+        }
+
         if (FactionsMod.CONFIG.DISPLAY.NAME_BLACKLIST.contains(name.toLowerCase(Locale.ROOT))) {
             new Message("Cannot rename a faction to that name as it is on the blacklist").fail()
                     .send(player, false);

src/main/java/io/icker/factions/util/Command.java

@@ -16,6 +16,7 @@
 import net.minecraft.util.UserCache;
 
 import java.util.Arrays;
+import java.util.Locale;
 import java.util.Optional;
 import java.util.function.Predicate;
 
@@ -166,8 +167,26 @@ public static SuggestionProvider<ServerCommandSource> suggest(Suggests sug) {
             return (context, builder) -> {
                 ServerPlayerEntity entity = context.getSource().getPlayerOrThrow();
                 User user = User.get(entity.getUuid());
+
+                // For greedyString arguments, builder.getStart() is positioned at the END of
+                // the parsed input (because greedyString consumes everything), making
+                // builder.getRemaining() return "" and causing all suggestions to always show.
+                // Fix: find the actual start of the last argument from the parsed context nodes.
+                int argStart = builder.getStart();
+                for (com.mojang.brigadier.context.ParsedCommandNode<?> node : context.getNodes()) {
+                    if (node.getNode() instanceof com.mojang.brigadier.tree.ArgumentCommandNode) {
+                        argStart = node.getRange().getStart();
+                    }
+                }
+
+                String remaining = builder.getInput()
+                        .substring(Math.min(argStart, builder.getInput().length()))
+                        .toLowerCase(Locale.ROOT);
+
                 for (String suggestion : sug.run(user)) {
-                    builder.suggest(suggestion);
+                    if (suggestion.toLowerCase(Locale.ROOT).startsWith(remaining)) {
+                        builder.suggest(suggestion);
+                    }
                 }
                 return builder.buildFuture();
             };