v0.10 First release

Author: Arondight

Changes

@@ -1,3 +1,8 @@
+v0.10   2015-11-01
+  * First release
+  * Hide important data
+  * More intuitive output
+
 v0.01   2015-10-22
-  * first version
+  * First version
 

build.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 # ==============================================================================
-# This to build project (but do not install)
+# This to build project
 # ==============================================================================
 
 curdir=$(dirname $(readlink -f $0))

src/config.h

@@ -19,6 +19,8 @@
 #ifndef __CONFIG_H__
 #define __CONFIG_H__
 
+#define VERSION ("0.10")
+
 #define SUDODEV_GROUP ("sudodev")
 #define SUDOERS ("/etc/sudoers")
 #define SUDO_CONF ("/etc/sudoers.d/sudodev")

src/lockfile.c

@@ -71,9 +71,19 @@ hasLockfile (void)
       return 1;   /* A sudodevd is running */
     }
 
-  ftruncate (fd, 0);
+  if (-1 == ftruncate (fd, 0))
+    {
+      say (mode, MSG_E, "ftruncate failed: %s", strerror (errno));
+      // Do nothing but show error message
+    }
+
+  /* Write pid to LOCKFILE */
   sprintf (pid, "%d", getpid ());
-  write (fd, pid, strlen (pid) + 1);
+  if (-1 == write (fd, pid, strlen (pid) + 1))
+    {
+      say (mode, MSG_E, "write failed: %s\n", strerror (errno));
+      return -1;
+    }
 
   return 0;
 }

src/say.c

@@ -23,6 +23,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <syslog.h>
+#include <errno.h>
 #include <sys/param.h>
 #include "say.h"
 #include "config.h"
@@ -76,7 +77,12 @@ getSayMode (saymode_t * const mode)
     {
       memset (file, 0, sizeof (file));
       snprintf (link, MAXPATHLEN - len - 1, "%s/%d", path, index);
-      readlink (link, file, MAXPATHLEN - 1);
+      if (-1 == readlink (link, file, MAXPATHLEN - 1))
+        {
+          fprintf (stderr, "readlink failed: %s\n", strerror (errno));
+          break;
+        }
+
       if (!strcmp (null, file))
         {
           /* If any file descriptor of 0, 1, 2 point to /dev/null,

src/sudodev.c

@@ -62,6 +62,8 @@ usage (const char * const string)
   int line;
   const char * const text[] =
     {
+      "This is sudodev, version ", VERSION, "\n",
+      "\n",
       "Usage: sudodev [add|del]\n",
       "\n",
       "  add:\tadd a device for none-password sudo\n",
@@ -265,7 +267,12 @@ add (void)
   while (1)
     {
       say (mode, MSG_I, "Choose a device (q to quit): ");
-      fgets (buff, (1 << 10) - 1, stdin);
+
+      if (!fgets (buff, (1 << 10) - 1, stdin))
+        {
+          say (mode, MSG_E, "fgets failed: %s\n", strerror (errno));
+          return -1;
+        }
       buff[strlen (buff) - 1] = 0;
 
       if ('q' == *buff)
@@ -442,6 +449,7 @@ del (void)
   for (index = 0; devices[index]; ++index)
     {
       say (mode, MSG_I, "[%3d]  %s", index + 1, devices[index]->name);
+
       if (!(strncmp (UNKNOWNSTR, devices[index]->name, UNKNOWNSTRLEN)))
         {
           strncpy (buff, devices[index]->uuid, 8);
@@ -456,7 +464,11 @@ del (void)
    while (1)
     {
       say (mode, MSG_I, "Choose a device (q to quit): ");
-      fgets (buff, (1 << 10) - 1, stdin);
+      if (!fgets (buff, (1 << 10) - 1, stdin))
+        {
+          say (mode, MSG_E, "fgets failed: %s\n", strerror (errno));
+          return -1;
+        }
       buff[strlen (buff) - 1] = 0;
 
       if ('q' == *buff)

src/sudodevd.c

@@ -417,7 +417,7 @@ main (const int argc, const char * const * const argv)
     }
   if (hasLock)
     {
-      say (mode, MSG_E, "sudodevd is already running\n");
+      say (mode, MSG_E, "sudodevd is already running, quit\n");
       exit (1);
     }
 
@@ -484,6 +484,7 @@ main (const int argc, const char * const * const argv)
     }
 
   /* Loop for event */
+  say (mode, MSG_I, "starting sudodevd, version %s\n", VERSION);
   eventloop ();
 
   say (mode, MSG_E, "Should never reach here, abort\n");