fix more findbugs

Author: BrandonArp

src/main/java/com/arpnetworking/configuration/Listener.java

@@ -15,6 +15,8 @@
  */
 package com.arpnetworking.configuration;
 
+import com.arpnetworking.utility.ConfigurationException;
+
 /**
  * Interface for consumers registered for configuration events.
  *
@@ -30,11 +32,10 @@ public interface Listener {
      * error. Once any listener rejects the {@link Configuration} other
      * listeners may not be offered that instance.
      *
+     * @throws ConfigurationException if the {@link Configuration} is rejected.
      * @param configuration The new {@link Configuration} to be validated.
-     * @throws Exception Thrown if the {@link Configuration} should be
-     * rejected.
      */
-    void offerConfiguration(Configuration configuration) throws Exception;
+    void offerConfiguration(Configuration configuration) throws ConfigurationException;
 
     /**
      * Invoked to apply the most recently offered configuration. Any

src/main/java/com/arpnetworking/metrics/mad/PeriodWorker.java

@@ -124,7 +124,7 @@ public void postStop() throws Exception {
     }
 
     @Override
-    public void preRestart(final Throwable reason, final Optional<Object> message) throws Exception {
+    public void preRestart(final Throwable reason, final Optional<Object> message) {
         _periodicMetrics.recordCounter("actors/period_worker/restarted", 1);
         LOGGER.error()
                 .setMessage("Restarting")

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSinkActor.java

@@ -141,6 +141,7 @@ public void postStop() throws Exception {
         _periodicMetrics.recordCounter("actors/http_post_sink/stopped", 1);
     }
 
+    @SuppressFBWarnings(value = "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION", justification = "Super method throws this")
     @Override
     public void preRestart(final Throwable reason, final Optional<Object> message) throws Exception {
         super.preRestart(reason, message);

src/main/java/com/arpnetworking/utility/ConfigurationException.java

@@ -0,0 +1,66 @@
+/*
+ * Copyright 2025 Brandon Arp
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.arpnetworking.utility;
+
+import com.arpnetworking.logback.annotations.Loggable;
+
+import java.io.Serial;
+
+/**
+ * Exception thrown when a configuration error occurs.
+ *
+ * @author Brandon Arp (brandon dot arp at inscopemetrics dot io)
+ */
+@Loggable
+public class ConfigurationException extends Exception {
+    /**
+     * Public constructor.
+     */
+    public ConfigurationException() {
+        super();
+    }
+
+    /**
+     * Public constructor with a description.
+     *
+     * @param message Describes the exceptional condition.
+     */
+    public ConfigurationException(final String message) {
+        super(message);
+    }
+
+    /**
+     * Public constructor with a description and cause.
+     *
+     * @param message Describes the exceptional condition.
+     * @param cause   Causing exception.
+     */
+    public ConfigurationException(final String message, final Throwable cause) {
+        super(message, cause);
+    }
+
+    /**
+     * Public constructor with cause.
+     *
+     * @param cause Causing exception.
+     */
+    public ConfigurationException(final Throwable cause) {
+        super(cause);
+    }
+
+    @Serial
+    private static final long serialVersionUID = 1L;
+}

src/main/java/com/arpnetworking/utility/Configurator.java

@@ -47,8 +47,19 @@ public Configurator(final ConfiguredLaunchableFactory<T, S> factory, final Class
     }
 
     @Override
-    public synchronized void offerConfiguration(final Configuration configuration) throws Exception {
-        _offeredConfiguration = configuration.getAs(_configurationClass);
+    public synchronized void offerConfiguration(final Configuration configuration) throws ConfigurationException {
+        try {
+            _offeredConfiguration = configuration.getAs(_configurationClass);
+        // CHECKSTYLE.OFF: IllegalCatch - This exception is explicitly thrown by getAs()
+        } catch (final RuntimeException e) {
+        // CHECKSTYLE.ON: IllegalCatch
+            throw new ConfigurationException(
+                    String.format(
+                            "Unable to parse configuration as %s: %s",
+                            _configurationClass.getCanonicalName(),
+                            e.getMessage()),
+                    e);
+        }
     }
 
     @Override

src/main/java/com/arpnetworking/utility/Reconfigurator.java

@@ -47,8 +47,19 @@ public Reconfigurator(final Relaunchable<S> relaunchable, final Class<? extends
     }
 
     @Override
-    public synchronized void offerConfiguration(final Configuration configuration) throws Exception {
-        _offeredConfiguration = configuration.getAs(_configurationClass);
+    public synchronized void offerConfiguration(final Configuration configuration) throws ConfigurationException {
+        try {
+            _offeredConfiguration = configuration.getAs(_configurationClass);
+        // CHECKSTYLE.OFF: IllegalCatch - This exception is explicitly thrown by getAs()
+        } catch (final RuntimeException e) {
+        // CHECKSTYLE.ON: IllegalCatch
+            throw new ConfigurationException(
+                    String.format(
+                            "Unable to parse configuration as %s: %s",
+                            _configurationClass.getCanonicalName(),
+                            e.getMessage()),
+                    e);
+        }
     }
 
     @Override