Skip to content

Commit 41213de

Browse files
committed
use BOM for jackson
1 parent e22e9de commit 41213de

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

pom.xml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0"?>
1+
<?xml version="1.0"?>
22
<!--
33
~ Copyright 2016 Groupon.com
44
~
@@ -81,7 +81,7 @@
8181
<fastutil.version>8.5.16</fastutil.version>
8282
<guava.version>33.5.0-jre</guava.version>
8383
<guice.version>7.0.0</guice.version>
84-
<jackson.version>2.20</jackson.version>
84+
<jackson.version>2.20.0</jackson.version>
8585
<javassist.version>3.30.2-GA</javassist.version>
8686
<javassist.maven.core.version>0.2.9</javassist.maven.core.version>
8787
<jsr305.version>3.0.2</jsr305.version>
@@ -660,17 +660,14 @@
660660
<dependency>
661661
<groupId>com.fasterxml.jackson.core</groupId>
662662
<artifactId>jackson-annotations</artifactId>
663-
<version>${jackson.version}</version>
664663
</dependency>
665664
<dependency>
666665
<groupId>com.fasterxml.jackson.core</groupId>
667666
<artifactId>jackson-core</artifactId>
668-
<version>${jackson.version}</version>
669667
</dependency>
670668
<dependency>
671669
<groupId>com.fasterxml.jackson.core</groupId>
672670
<artifactId>jackson-databind</artifactId>
673-
<version>${jackson.version}</version>
674671
<exclusions>
675672
<!-- TODO(ville): Remove this exclusion once the annotations package is consistently depended upon:
676673
https://github.com/FasterXML/jackson-bom/issues/15
@@ -684,7 +681,6 @@
684681
<dependency>
685682
<groupId>com.fasterxml.jackson.datatype</groupId>
686683
<artifactId>jackson-datatype-guava</artifactId>
687-
<version>${jackson.version}</version>
688684
<scope>runtime</scope>
689685
<exclusions>
690686
<!-- TODO(ville): Jackson has a very slow update policy towards Guava; see:
@@ -701,7 +697,6 @@
701697
<dependency>
702698
<groupId>com.fasterxml.jackson.module</groupId>
703699
<artifactId>jackson-module-guice7</artifactId>
704-
<version>${jackson.version}</version>
705700
<exclusions>
706701
<!-- TODO(ville): Remove this exclusion once the annotations package is consistently depended upon:
707702
https://github.com/FasterXML/jackson-bom/issues/15
@@ -715,13 +710,11 @@
715710
<dependency>
716711
<groupId>com.fasterxml.jackson.datatype</groupId>
717712
<artifactId>jackson-datatype-jdk8</artifactId>
718-
<version>${jackson.version}</version>
719713
<scope>runtime</scope>
720714
</dependency>
721715
<dependency>
722716
<groupId>com.fasterxml.jackson.datatype</groupId>
723717
<artifactId>jackson-datatype-jsr310</artifactId>
724-
<version>${jackson.version}</version>
725718
<scope>runtime</scope>
726719
<exclusions>
727720
<!-- TODO(ville): Remove this exclusion once the annotations package is consistently depended upon:
@@ -736,7 +729,6 @@
736729
<dependency>
737730
<groupId>com.fasterxml.jackson.module</groupId>
738731
<artifactId>jackson-module-afterburner</artifactId>
739-
<version>${jackson.version}</version>
740732
</dependency>
741733
<!-- Pekko -->
742734
<dependency>
@@ -986,6 +978,17 @@
986978
<version>${bouncy.castle.version}</version>
987979
</dependency>
988980
</dependencies>
981+
<dependencyManagement>
982+
<dependencies>
983+
<dependency>
984+
<groupId>com.fasterxml.jackson</groupId>
985+
<artifactId>jackson-bom</artifactId>
986+
<version>${jackson.version}</version>
987+
<scope>import</scope>
988+
<type>pom</type>
989+
</dependency>
990+
</dependencies>
991+
</dependencyManagement>
989992

990993
<profiles>
991994
<profile>

src/test/java/com/arpnetworking/metrics/mad/integration/HealthCheckIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class HealthCheckIT {
3535
public void test() throws IOException {
3636
final JsonNode expectedResponse = OBJECT_MAPPER.readTree("{\"status\":\"HEALTHY\"}");
3737
final JsonNode actualResponse = OBJECT_MAPPER.readTree(
38-
new URL(getEndpoint() + "/ping"));
38+
new URL(getEndpoint() + "/ping").openStream());
3939
Assert.assertEquals(expectedResponse, actualResponse);
4040
}
4141

0 commit comments

Comments
 (0)