Bump com.arpnetworking.build:arpnetworking-parent-pom from 3.3.6 to 3.3.8 (#529)

dependabot[bot] · BrandonArp · web-flow · commit 628a91423253 · 2025-05-28T10:25:31.000Z
* Bump com.arpnetworking.build:arpnetworking-parent-pom Bumps [com.arpnetworking.build:arpnetworking-parent-pom](https://github.com/arpnetworking/arpnetworking-parent-pom) from 3.3.6 to 3.3.8. - [Release notes](https://github.com/arpnetworking/arpnetworking-parent-pom/releases) - [Commits](ArpNetworking/arpnetworking-parent-pom@arpnetworking-parent-pom-3.3.6...arpnetworking-parent-pom-3.3.8) --- updated-dependencies: - dependency-name: com.arpnetworking.build:arpnetworking-parent-pom dependency-version: 3.3.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * add exclusions from updated build resources * cleanup errors * checkstyle * fix more findbugs * last spotbugs issue --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brandon Arp <brandonarp@gmail.com>
diff --git a/pom.xml b/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <groupId>com.arpnetworking.build</groupId>
     <artifactId>arpnetworking-parent-pom</artifactId>
-    <version>3.3.6</version>
+    <version>3.3.8</version>
     <relativePath />
   </parent>
 
diff --git a/spotbugs.exclude.xml b/spotbugs.exclude.xml
@@ -29,6 +29,33 @@
          </Or>
      </Match>
 
+     <!-- Match THROWS_METHOD_THROWS_RUNTIMEEXCEPTION violations. We commonly
+	     use runtime exceptions with lambdas, streams, and promises to indicate
+	     failure
+     -->
+     <Match>
+         <Bug pattern="THROWS_METHOD_THROWS_RUNTIMEEXCEPTION" />
+     </Match>
+
+     <!-- We often throw Exception in tests to indicate an error. The exception itself is the point, not how to handle it
+     -->
+     <Match>
+         <Or>
+             <Bug pattern="THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION" />
+             <Bug pattern="DE_MIGHT_IGNORE" />
+         </Or>
+         <Or>
+             <Class name="~.*\.[^\.]+Test" />
+             <Class name="~.*\.[^\.]+Test\$.*" />
+             <Class name="~.*\.[^\.]+TestPerf" />
+             <Class name="~.*\.[^\.]+TestPerf\$.*" />
+             <Class name="~.*\.[^\.]+IT" />
+             <Class name="~.*\.[^\.]+IT\$.*" />
+             <Class name="~.*\.[^\.]+ITPerf" />
+             <Class name="~.*\.[^\.]+ITPerf\$.*" />
+         </Or>
+     </Match>
+
      <!-- Match all RV_RETURN_VALUE_IGNORED_BAD_PRACTICE violations on all unit
         test files since Mockito usage can cause this violation when stating
         expectations.
diff --git a/src/main/java/com/arpnetworking/configuration/Listener.java b/src/main/java/com/arpnetworking/configuration/Listener.java
@@ -15,6 +15,8 @@
  */
 package com.arpnetworking.configuration;
 
+import com.arpnetworking.utility.ConfigurationException;
+
 /**
  * Interface for consumers registered for configuration events.
  *
@@ -30,11 +32,10 @@ public interface Listener {
      * error. Once any listener rejects the {@link Configuration} other
      * listeners may not be offered that instance.
      *
+     * @throws ConfigurationException if the {@link Configuration} is rejected.
      * @param configuration The new {@link Configuration} to be validated.
-     * @throws Exception Thrown if the {@link Configuration} should be
-     * rejected.
      */
-    void offerConfiguration(Configuration configuration) throws Exception;
+    void offerConfiguration(Configuration configuration) throws ConfigurationException;
 
     /**
      * Invoked to apply the most recently offered configuration. Any
diff --git a/src/main/java/com/arpnetworking/metrics/common/parsers/exceptions/ParsingException.java b/src/main/java/com/arpnetworking/metrics/common/parsers/exceptions/ParsingException.java
@@ -16,7 +16,6 @@
 package com.arpnetworking.metrics.common.parsers.exceptions;
 
 import com.arpnetworking.logback.annotations.Loggable;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.io.Serial;
 
@@ -25,7 +24,6 @@
  *
  * @author Brandon Arp (brandon dot arp at inscopemetrics dot io)
  */
-@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
 @Loggable
 public class ParsingException extends Exception {
     /**
diff --git a/src/main/java/com/arpnetworking/metrics/mad/Aggregator.java b/src/main/java/com/arpnetworking/metrics/mad/Aggregator.java
@@ -40,7 +40,6 @@
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.sf.oval.constraint.NotNull;
 import org.apache.pekko.actor.AbstractActor;
 import org.apache.pekko.actor.ActorRef;
@@ -135,7 +134,6 @@ public synchronized void shutdown() {
     private static final Random R = new Random();
 
     @Override
-    @SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
     public void notify(final Observable observable, final Object event) {
         if (!(event instanceof Record)) {
             LOGGER.error()
diff --git a/src/main/java/com/arpnetworking/metrics/mad/Bucket.java b/src/main/java/com/arpnetworking/metrics/mad/Bucket.java
@@ -364,7 +364,7 @@ private Collection<Calculator<?>> getOrCreateCalculators(
         _dependentStatisticsCache = builder._dependentStatistics;
     }
 
-    private boolean _isOpen = true;
+    private volatile boolean _isOpen = true;
     private Optional<ZonedDateTime> _minRequestTime = Optional.empty();
 
     private final Map<String, Collection<Calculator<?>>> _counterMetricCalculators = Maps.newHashMap();
diff --git a/src/main/java/com/arpnetworking/metrics/mad/PeriodWorker.java b/src/main/java/com/arpnetworking/metrics/mad/PeriodWorker.java
@@ -124,7 +124,7 @@ public void postStop() throws Exception {
     }
 
     @Override
-    public void preRestart(final Throwable reason, final Optional<Object> message) throws Exception {
+    public void preRestart(final Throwable reason, final Optional<Object> message) {
         _periodicMetrics.recordCounter("actors/period_worker/restarted", 1);
         LOGGER.error()
                 .setMessage("Restarting")
diff --git a/src/main/java/com/arpnetworking/metrics/mad/parsers/GraphitePlaintextToRecordParser.java b/src/main/java/com/arpnetworking/metrics/mad/parsers/GraphitePlaintextToRecordParser.java
@@ -28,7 +28,6 @@
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Maps;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.sf.oval.constraint.NotNull;
 
 import java.nio.ByteBuffer;
@@ -141,7 +140,6 @@ public List<Record> parse(final ByteBuffer record) throws ParsingException {
         return recordListBuilder.build();
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private String parseName(final ByteBuffer datagram, @Nullable final String name) throws ParsingException {
         if (Strings.isNullOrEmpty(name)) {
diff --git a/src/main/java/com/arpnetworking/metrics/mad/parsers/StatsdToRecordParser.java b/src/main/java/com/arpnetworking/metrics/mad/parsers/StatsdToRecordParser.java
@@ -30,7 +30,6 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Maps;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
@@ -135,7 +134,6 @@ private StatsdType parseStatsdType(
         return type;
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private String parseName(final ByteBuffer datagram, @Nullable final String name) throws ParsingException {
         if (Strings.isNullOrEmpty(name)) {
@@ -161,7 +159,6 @@ private Number parseValue(
         }
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private ImmutableMap<String, String> parseTags(@Nullable final String tagsAsString) {
         if (null != tagsAsString) {
@@ -170,7 +167,6 @@ private ImmutableMap<String, String> parseTags(@Nullable final String tagsAsStri
         return ImmutableMap.of();
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private ImmutableMap<String, String> parseInfluxStyleTags(@Nullable final String tagsAsString) {
         if (null != tagsAsString) {
diff --git a/src/main/java/com/arpnetworking/metrics/proxy/actors/Telemetry.java b/src/main/java/com/arpnetworking/metrics/proxy/actors/Telemetry.java
@@ -38,7 +38,6 @@
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
 import com.google.inject.Inject;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.pekko.actor.AbstractActor;
 import org.apache.pekko.actor.ActorRef;
 import org.apache.pekko.actor.Cancellable;
@@ -66,8 +65,6 @@ public class Telemetry extends AbstractActor {
      * @param metricsFactory Instance of {@link MetricsFactory}.
      */
     @Inject
-    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
-            justification = "getSelf() and getContext() are safe to call in the constructor.")
     public Telemetry(final MetricsFactory metricsFactory) {
         _metricsFactory = metricsFactory;
         _metrics = metricsFactory.create();
diff --git a/src/main/java/com/arpnetworking/metrics/proxy/models/messages/LogLine.java b/src/main/java/com/arpnetworking/metrics/proxy/models/messages/LogLine.java
@@ -20,7 +20,6 @@
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.google.common.base.MoreObjects;
 import com.google.common.primitives.Bytes;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
@@ -43,7 +42,6 @@ public final class LogLine {
      * @param line The raw log line.
      */
     // TODO(vkoskela): Investigate the use of immutable rotating buffers [MAI-489]
-    @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
     public LogLine(
             final Path file,
             final byte[] line) {
diff --git a/src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSinkActor.java b/src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSinkActor.java
@@ -141,6 +141,7 @@ public void postStop() throws Exception {
         _periodicMetrics.recordCounter("actors/http_post_sink/stopped", 1);
     }
 
+    @SuppressFBWarnings(value = "THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION", justification = "Super method throws this")
     @Override
     public void preRestart(final Throwable reason, final Optional<Object> message) throws Exception {
         super.preRestart(reason, message);
diff --git a/src/main/java/com/arpnetworking/utility/ConfigurationException.java b/src/main/java/com/arpnetworking/utility/ConfigurationException.java
@@ -0,0 +1,66 @@
+/*
+ * Copyright 2025 Brandon Arp
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.arpnetworking.utility;
+
+import com.arpnetworking.logback.annotations.Loggable;
+
+import java.io.Serial;
+
+/**
+ * Exception thrown when a configuration error occurs.
+ *
+ * @author Brandon Arp (brandon dot arp at inscopemetrics dot io)
+ */
+@Loggable
+public class ConfigurationException extends Exception {
+    /**
+     * Public constructor.
+     */
+    public ConfigurationException() {
+        super();
+    }
+
+    /**
+     * Public constructor with a description.
+     *
+     * @param message Describes the exceptional condition.
+     */
+    public ConfigurationException(final String message) {
+        super(message);
+    }
+
+    /**
+     * Public constructor with a description and cause.
+     *
+     * @param message Describes the exceptional condition.
+     * @param cause   Causing exception.
+     */
+    public ConfigurationException(final String message, final Throwable cause) {
+        super(message, cause);
+    }
+
+    /**
+     * Public constructor with cause.
+     *
+     * @param cause Causing exception.
+     */
+    public ConfigurationException(final Throwable cause) {
+        super(cause);
+    }
+
+    @Serial
+    private static final long serialVersionUID = 1L;
+}
diff --git a/src/main/java/com/arpnetworking/utility/Configurator.java b/src/main/java/com/arpnetworking/utility/Configurator.java
@@ -47,8 +47,19 @@ public Configurator(final ConfiguredLaunchableFactory<T, S> factory, final Class
     }
 
     @Override
-    public synchronized void offerConfiguration(final Configuration configuration) throws Exception {
-        _offeredConfiguration = configuration.getAs(_configurationClass);
+    public synchronized void offerConfiguration(final Configuration configuration) throws ConfigurationException {
+        try {
+            _offeredConfiguration = configuration.getAs(_configurationClass);
+        // CHECKSTYLE.OFF: IllegalCatch - This exception is explicitly thrown by getAs()
+        } catch (final RuntimeException e) {
+        // CHECKSTYLE.ON: IllegalCatch
+            throw new ConfigurationException(
+                    String.format(
+                            "Unable to parse configuration as %s: %s",
+                            _configurationClass.getCanonicalName(),
+                            e.getMessage()),
+                    e);
+        }
     }
 
     @Override
diff --git a/src/main/java/com/arpnetworking/utility/Reconfigurator.java b/src/main/java/com/arpnetworking/utility/Reconfigurator.java
@@ -47,8 +47,19 @@ public Reconfigurator(final Relaunchable<S> relaunchable, final Class<? extends
     }
 
     @Override
-    public synchronized void offerConfiguration(final Configuration configuration) throws Exception {
-        _offeredConfiguration = configuration.getAs(_configurationClass);
+    public synchronized void offerConfiguration(final Configuration configuration) throws ConfigurationException {
+        try {
+            _offeredConfiguration = configuration.getAs(_configurationClass);
+        // CHECKSTYLE.OFF: IllegalCatch - This exception is explicitly thrown by getAs()
+        } catch (final RuntimeException e) {
+        // CHECKSTYLE.ON: IllegalCatch
+            throw new ConfigurationException(
+                    String.format(
+                            "Unable to parse configuration as %s: %s",
+                            _configurationClass.getCanonicalName(),
+                            e.getMessage()),
+                    e);
+        }
     }
 
     @Override
diff --git a/src/test/java/com/arpnetworking/metrics/mad/model/statistics/HistogramStatisticTest.java b/src/test/java/com/arpnetworking/metrics/mad/model/statistics/HistogramStatisticTest.java
@@ -22,7 +22,6 @@
 import com.arpnetworking.test.TestBeanFactory;
 import com.arpnetworking.tsdcore.model.CalculatedValue;
 import com.google.common.collect.ImmutableMap;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -172,7 +171,6 @@ public void histogramEnds() {
     }
 
     @Test
-    @SuppressFBWarnings(value = "FL_FLOATS_AS_LOOP_COUNTERS", justification = "Tests the floating point values")
     public void packAndUnpack() {
         final int precision = 7;
         final HistogramStatistic.Histogram histogram = new HistogramStatistic.Histogram(precision);
diff --git a/src/test/java/com/arpnetworking/tsdcore/sinks/AggregationServerSinkTest.java b/src/test/java/com/arpnetworking/tsdcore/sinks/AggregationServerSinkTest.java
@@ -140,7 +140,7 @@ private SocketChannel listenForConnection(
     }
 
     private ServerSocketChannel _serverChannel;
-    private int _port;
+    private volatile int _port;
 
     private static final AtomicInteger NEXT_PORT = new AtomicInteger(17065);
 }

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ private Collection<Calculator<?>> getOrCreateCalculators(`
`364`	`364`	`_dependentStatisticsCache = builder._dependentStatistics;`
`365`	`365`	`}`
`366`	`366`
`367`		`- private boolean _isOpen = true;`
	`367`	`+ private volatile boolean _isOpen = true;`
`368`	`368`	`private Optional<ZonedDateTime> _minRequestTime = Optional.empty();`
`369`	`369`
`370`	`370`	`private final Map<String, Collection<Calculator<?>>> _counterMetricCalculators = Maps.newHashMap();`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public void postStop() throws Exception {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`@Override`
`127`		`- public void preRestart(final Throwable reason, final Optional<Object> message) throws Exception {`
	`127`	`+ public void preRestart(final Throwable reason, final Optional<Object> message) {`
`128`	`128`	`_periodicMetrics.recordCounter("actors/period_worker/restarted", 1);`
`129`	`129`	`LOGGER.error()`
`130`	`130`	`.setMessage("Restarting")`