Bump org.asynchttpclient:async-http-client from 2.12.3 to 3.0.0 (#466)

* Bump org.asynchttpclient:async-http-client from 2.12.3 to 3.0.0

Bumps [org.asynchttpclient:async-http-client](https://github.com/AsyncHttpClient/async-http-client) from 2.12.3 to 3.0.0.
- [Release notes](https://github.com/AsyncHttpClient/async-http-client/releases)
- [Changelog](https://github.com/AsyncHttpClient/async-http-client/blob/main/CHANGES.md)
- [Commits](AsyncHttpClient/async-http-client@async-http-client-project-2.12.3...async-http-client-project-3.0.0)

---
updated-dependencies:
- dependency-name: org.asynchttpclient:async-http-client
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* fixup for update

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brandon Arp <[email protected]>

Author: dependabot[bot]

pom.xml

@@ -75,7 +75,7 @@
     <apache.httpcore.version>4.4.16</apache.httpcore.version>
     <arpnetworking.commons.version>3.1.1</arpnetworking.commons.version>
     <aspectjrt.version>1.9.22.1</aspectjrt.version>
-    <asynchttpclient.version>2.12.3</asynchttpclient.version>
+    <asynchttpclient.version>3.0.0</asynchttpclient.version>
     <bouncy.castle.version>1.78.1</bouncy.castle.version>
     <client.protocol.version>0.12.0</client.protocol.version>
     <fastutil.version>8.5.14</fastutil.version>

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java

@@ -203,7 +203,7 @@ protected void start(final Builder<?, ?> builder) {
     static {
         final DefaultAsyncHttpClientConfig.Builder clientConfigBuilder = new DefaultAsyncHttpClientConfig.Builder();
         clientConfigBuilder.setThreadPoolName("HttpPostSinkWorker")
-                .setConnectionTtl(300000);
+                .setConnectionTtl(Duration.ofSeconds(300));
         final AsyncHttpClientConfig clientConfig = clientConfigBuilder.build();
         CLIENT = new DefaultAsyncHttpClient(clientConfig);
     }

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSinkActor.java

@@ -231,13 +231,15 @@ private void processRejectedRequest(final PostRejected rejected) {
         _inflightRequestsCount--;
         final Response response = rejected.getResponse();
         final Optional<String> responseBody = Optional.ofNullable(response.getResponseBody());
+        final byte[] requestBodyBytes = rejected.getRequest().getByteData();
+        // CHECKSTYLE.OFF: IllegalInstantiation - This is ok for String from byte[]
+        final String requestBody = requestBodyBytes == null ? null : new String(requestBodyBytes, Charsets.UTF_8);
+        // CHECKSTYLE.ON: IllegalInstantiation
         LOGGER.warn()
                 .setMessage("Post rejected")
                 .addData("sink", _sink)
                 .addData("status", response.getStatusCode())
-                // CHECKSTYLE.OFF: IllegalInstantiation - This is ok for String from byte[]
-                .addData("request", new String(rejected.getRequest().getByteData(), Charsets.UTF_8))
-                // CHECKSTYLE.ON: IllegalInstantiation
+                .addData("request", requestBody)
                 .addData("response", responseBody)
                 .addContext("actor", self())
                 .log();