Skip to content

Commit 9f3caed

Browse files
committed
change replaceExisting to overwriteExisting
1 parent 05954a4 commit 9f3caed

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/main/java/com/arpnetworking/metrics/mad/sources/TransformingSource.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ private Key getModifiedDimensions(
216216
transformation.getInject().forEach(
217217
(key, inject) ->
218218
finalTags.compute(key, (k, oldValue) ->
219-
inject.isReplaceExisting() || oldValue == null ? inject.getValue() : oldValue));
219+
inject.isOverwriteExisting() || oldValue == null ? inject.getValue() : oldValue));
220220
finalTags.putAll(add);
221221

222222
return new DefaultKey(ImmutableMap.copyOf(finalTags));
@@ -302,17 +302,17 @@ public String getValue() {
302302
return _value;
303303
}
304304

305-
public boolean isReplaceExisting() {
306-
return _replaceExisting;
305+
public boolean isOverwriteExisting() {
306+
return _overwriteExisting;
307307
}
308308

309309
private DimensionInjection(final Builder builder) {
310310
_value = builder._value;
311-
_replaceExisting = builder._replaceExisting;
311+
_overwriteExisting = builder._overwriteExisting;
312312
}
313313

314314
private final String _value;
315-
private final boolean _replaceExisting;
315+
private final boolean _overwriteExisting;
316316

317317
/**
318318
* Implementation of the <code>Builder</code> pattern for {@link DimensionInjection}.
@@ -344,16 +344,16 @@ public Builder setValue(final String value) {
344344
* @param value true to replace existing dimension value
345345
* @return This instance of {@link Builder}.
346346
*/
347-
public Builder setReplaceExisting(final Boolean value) {
348-
_replaceExisting = value;
347+
public Builder setOverwriteExisting(final Boolean value) {
348+
_overwriteExisting = value;
349349
return this;
350350
}
351351

352352
@NotNull
353353
@NotEmpty
354354
private String _value;
355355
@NotNull
356-
private Boolean _replaceExisting = true;
356+
private Boolean _overwriteExisting = true;
357357
}
358358
}
359359

src/test/java/com/arpnetworking/metrics/mad/sources/TransformingSourceTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ public void testStaticDimensionInjection() {
409409
"injected",
410410
new TransformingSource.DimensionInjection.Builder()
411411
.setValue("value")
412-
.setReplaceExisting(false)
412+
.setOverwriteExisting(false)
413413
.build()));
414414
final Record matchingRecord = TestBeanFactory.createRecordBuilder()
415415
.setMetrics(ImmutableMap.of(
@@ -457,12 +457,12 @@ public void testStaticDimensionInjectionOverwrite() {
457457
"injected",
458458
new TransformingSource.DimensionInjection.Builder()
459459
.setValue("new_value")
460-
.setReplaceExisting(true)
460+
.setOverwriteExisting(true)
461461
.build(),
462462
"injected_no_over",
463463
new TransformingSource.DimensionInjection.Builder()
464464
.setValue("new_value")
465-
.setReplaceExisting(false)
465+
.setOverwriteExisting(false)
466466
.build()));
467467
final Record matchingRecord = TestBeanFactory.createRecordBuilder()
468468
.setMetrics(ImmutableMap.of(

0 commit comments

Comments
 (0)