cleanup errors

Author: BrandonArp

src/main/java/com/arpnetworking/metrics/common/parsers/exceptions/ParsingException.java

@@ -16,7 +16,6 @@
 package com.arpnetworking.metrics.common.parsers.exceptions;
 
 import com.arpnetworking.logback.annotations.Loggable;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.io.Serial;
 
@@ -25,7 +24,6 @@
  *
  * @author Brandon Arp (brandon dot arp at inscopemetrics dot io)
  */
-@SuppressFBWarnings(value = {"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
 @Loggable
 public class ParsingException extends Exception {
     /**

src/main/java/com/arpnetworking/metrics/mad/Aggregator.java

@@ -40,7 +40,6 @@
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.sf.oval.constraint.NotNull;
 import org.apache.pekko.actor.AbstractActor;
 import org.apache.pekko.actor.ActorRef;
@@ -135,7 +134,6 @@ public synchronized void shutdown() {
     private static final Random R = new Random();
 
     @Override
-    @SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
     public void notify(final Observable observable, final Object event) {
         if (!(event instanceof Record)) {
             LOGGER.error()

src/main/java/com/arpnetworking/metrics/mad/Bucket.java

@@ -364,7 +364,7 @@ private Collection<Calculator<?>> getOrCreateCalculators(
         _dependentStatisticsCache = builder._dependentStatistics;
     }
 
-    private boolean _isOpen = true;
+    private volatile boolean _isOpen = true;
     private Optional<ZonedDateTime> _minRequestTime = Optional.empty();
 
     private final Map<String, Collection<Calculator<?>>> _counterMetricCalculators = Maps.newHashMap();

src/main/java/com/arpnetworking/metrics/mad/parsers/GraphitePlaintextToRecordParser.java

@@ -141,7 +141,6 @@ public List<Record> parse(final ByteBuffer record) throws ParsingException {
         return recordListBuilder.build();
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private String parseName(final ByteBuffer datagram, @Nullable final String name) throws ParsingException {
         if (Strings.isNullOrEmpty(name)) {

src/main/java/com/arpnetworking/metrics/mad/parsers/StatsdToRecordParser.java

@@ -135,7 +135,6 @@ private StatsdType parseStatsdType(
         return type;
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private String parseName(final ByteBuffer datagram, @Nullable final String name) throws ParsingException {
         if (Strings.isNullOrEmpty(name)) {
@@ -161,7 +160,6 @@ private Number parseValue(
         }
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private ImmutableMap<String, String> parseTags(@Nullable final String tagsAsString) {
         if (null != tagsAsString) {
@@ -170,7 +168,6 @@ private ImmutableMap<String, String> parseTags(@Nullable final String tagsAsStri
         return ImmutableMap.of();
     }
 
-    @SuppressFBWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
     // See: https://github.com/findbugsproject/findbugs/issues/79
     private ImmutableMap<String, String> parseInfluxStyleTags(@Nullable final String tagsAsString) {
         if (null != tagsAsString) {

src/main/java/com/arpnetworking/metrics/proxy/actors/Telemetry.java

@@ -66,8 +66,6 @@ public class Telemetry extends AbstractActor {
      * @param metricsFactory Instance of {@link MetricsFactory}.
      */
     @Inject
-    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
-            justification = "getSelf() and getContext() are safe to call in the constructor.")
     public Telemetry(final MetricsFactory metricsFactory) {
         _metricsFactory = metricsFactory;
         _metrics = metricsFactory.create();

src/main/java/com/arpnetworking/metrics/proxy/models/messages/LogLine.java

@@ -43,7 +43,6 @@ public final class LogLine {
      * @param line The raw log line.
      */
     // TODO(vkoskela): Investigate the use of immutable rotating buffers [MAI-489]
-    @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"})
     public LogLine(
             final Path file,
             final byte[] line) {

src/test/java/com/arpnetworking/metrics/mad/model/statistics/HistogramStatisticTest.java

@@ -172,7 +172,6 @@ public void histogramEnds() {
     }
 
     @Test
-    @SuppressFBWarnings(value = "FL_FLOATS_AS_LOOP_COUNTERS", justification = "Tests the floating point values")
     public void packAndUnpack() {
         final int precision = 7;
         final HistogramStatistic.Histogram histogram = new HistogramStatistic.Histogram(precision);