Skip to content

Commit d10c0fc

Browse files
authored
fix protobuf v2 parser, update some deps (#72)
1 parent 279be71 commit d10c0fc

File tree

5 files changed

+20
-11
lines changed

5 files changed

+20
-11
lines changed

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<akka.http.version>10.0.11</akka.http.version>
7676
<apache.httpclient.version>4.5.1</apache.httpclient.version>
7777
<apache.httpcore.version>4.4.3</apache.httpcore.version>
78-
<arpnetworking.commons.version>1.9.0</arpnetworking.commons.version>
78+
<arpnetworking.commons.version>1.13.3</arpnetworking.commons.version>
7979
<aspectjrt.version>1.8.9</aspectjrt.version>
8080
<cglib.version>3.2.5</cglib.version>
8181
<client.protocol.version>0.10.0</client.protocol.version>
@@ -98,10 +98,10 @@
9898
<log4j.over.slf4j.version>1.7.12</log4j.over.slf4j.version>
9999
<metrics.aggregator.protocol.version>1.0.3</metrics.aggregator.protocol.version>
100100
<metrics.client.version>0.10.0</metrics.client.version>
101-
<metrics.client.http.version>0.8.2</metrics.client.http.version>
101+
<metrics.client.http.version>0.9.1</metrics.client.http.version>
102102
<metrics.client.incubator.version>0.6.0</metrics.client.incubator.version>
103-
<metrics.generator.version>1.1.0</metrics.generator.version>
104-
<metrics.jvm.extra.version>0.7.0</metrics.jvm.extra.version>
103+
<metrics.generator.version>1.2.0</metrics.generator.version>
104+
<metrics.jvm.extra.version>0.9.0</metrics.jvm.extra.version>
105105
<mockito.version>2.12.0</mockito.version>
106106
<oval.version>1.90</oval.version>
107107
<performance.test.version>1.1.0</performance.test.version>

src/main/java/com/arpnetworking/metrics/mad/Main.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ private Injector launchGuice(final ActorSystem actorSystem) {
255255

256256
// Instantiate the metrics factory
257257
final String sinkHost = "0.0.0.0".equals(_configuration.getHttpHost()) ? "localhost" : _configuration.getHttpHost();
258-
final URI sinkUrl = URI.create("http://" + sinkHost + ":" + _configuration.getHttpPort() + "/metrics/v1/application");
258+
final URI sinkUrl = URI.create("http://" + sinkHost + ":" + _configuration.getHttpPort() + "/metrics/v2/application");
259259
final MetricsFactory metricsFactory = new TsdMetricsFactory.Builder()
260260
.setClusterName(_configuration.getMonitoringCluster())
261261
.setServiceName("mad")

src/main/java/com/arpnetworking/metrics/mad/parsers/ProtobufV2ToRecordParser.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,15 @@ private void processEntries(
8686
.setType(metricType);
8787
final List<Quantity> quantities = Lists.newArrayListWithExpectedSize(metricEntry.getSamplesCount());
8888
for (final ClientV2.Quantity quantity : metricEntry.getSamplesList()) {
89-
quantities.add(
90-
new Quantity.Builder()
91-
.setUnit(baseUnit(quantity.getUnit()))
92-
.setValue(quantity.getDoubleValue())
93-
.build());
89+
final Quantity.Builder builder = new Quantity.Builder()
90+
.setUnit(baseUnit(quantity.getUnit()));
91+
if (quantity.getValueCase().equals(ClientV2.Quantity.ValueCase.DOUBLEVALUE)) {
92+
builder.setValue(quantity.getDoubleValue());
93+
} else if (quantity.getValueCase().equals(ClientV2.Quantity.ValueCase.LONGVALUE)) {
94+
builder.setValue(Long.valueOf(quantity.getLongValue()).doubleValue());
95+
}
96+
97+
quantities.add(builder.build());
9498
}
9599

96100
metricBuilder.setValues(quantities);

src/test/java/com/arpnetworking/metrics/mad/parsers/ProtobufV2ToRecordParserTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void testParseSingleRecord() throws ParsingException, IOException {
6363
Assert.assertEquals(time, record.getTime());
6464

6565
final ImmutableMap<String, ? extends Metric> metrics = record.getMetrics();
66-
Assert.assertEquals(2, metrics.size());
66+
Assert.assertEquals(3, metrics.size());
6767
final Metric counter = metrics.get("counter1");
6868
Assert.assertNotNull(counter);
6969
Assert.assertEquals(1, counter.getValues().size());
@@ -73,6 +73,11 @@ public void testParseSingleRecord() throws ParsingException, IOException {
7373
Assert.assertNotNull(timer);
7474
Assert.assertEquals(1, timer.getValues().size());
7575
Assert.assertEquals(new Quantity.Builder().setUnit(Unit.MILLISECOND).setValue(508d).build(), timer.getValues().get(0));
76+
77+
final Metric longCounter = metrics.get("longCounter1");
78+
Assert.assertNotNull(longCounter);
79+
Assert.assertEquals(1, longCounter.getValues().size());
80+
Assert.assertEquals(new Quantity.Builder().setValue(1d).build(), counter.getValues().get(0));
7681
}
7782

7883
private static List<Record> parseRecords(final String fileName) throws ParsingException, IOException {
20 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)