Cleaned up some deadcode and other warnings caught by vscode. (#127)

* Fixed warnings found by vscode.

* More VSCode fixes

* Fixed checkstyle errors

* Update ProtobufV1ToRecordParserTest.java

* Update MaxStatisticTest.java

* Update TPStatisticTest.java

* Update MinStatisticTest.java

Author: ddimensia

.gitignore

@@ -20,3 +20,7 @@ eclipse-bin/
 
 # Mac
 .DS_Store
+
+# VSCode
+.vscode
+.project

src/main/java/com/arpnetworking/configuration/triggers/DirectoryTrigger.java

@@ -138,7 +138,7 @@ private boolean isFileMonitored(final File file) {
      */
     @LogValue
     public Object toLogValue() {
-        return LogValueMapFactory.<String, Object>builder()
+        return LogValueMapFactory.builder(this)
                 .put("directory", _directory)
                 .put("exists", _exists)
                 .put("fileNames", _fileNames)

src/main/java/com/arpnetworking/http/Routes.java

@@ -125,7 +125,7 @@ public CompletionStage<HttpResponse> apply(final HttpRequest request) {
                 .addData("url", request.getUri())
                 .addData("headers", request.getHeaders())
                 .log();
-        return process(request).<HttpResponse>whenComplete(
+        return process(request).whenComplete(
                 (response, failure) -> {
                     requestTimer.stop();
                     _metrics.recordTimer(

src/main/java/com/arpnetworking/metrics/common/tailer/FilePositionStore.java

@@ -89,7 +89,7 @@ public void close() {
      */
     @LogValue
     public Object toLogValue() {
-        return LogValueMapFactory.<String, Object>builder()
+        return LogValueMapFactory.builder(this)
                 .put("file", _file)
                 .put("flushInterval", _flushInterval)
                 .put("flushThreshold", _flushThreshold)

src/main/java/com/arpnetworking/metrics/common/tailer/StatefulTailer.java

@@ -85,7 +85,7 @@ public void run() {
      */
     @LogValue
     public Object toLogValue() {
-        return LogValueMapFactory.<String, Object>builder()
+        return LogValueMapFactory.builder(this)
                 .put("file", _file)
                 .put("positionStore", _positionStore)
                 .put("listener", _listener)

src/main/java/com/arpnetworking/metrics/proxy/models/protocol/v2/LogMessagesProcessor.java

@@ -222,7 +222,6 @@ private ZonedDateTime extractTimestamp(final String line) {
     private static final String LOG_LINE_COUNTER = METRICS_PREFIX + "log_line";
     private static final String LOGS_LIST_COUNTER = METRICS_PREFIX + "list_log";
     private static final String NEW_LOG_COUNTER = METRICS_PREFIX + "new_log";
-    private static final String LOG_REPORT_COUNTER = METRICS_PREFIX + "log_report";
     private static final String SUBSCRIBE_COUNTER = METRICS_PREFIX + "subscribe";
     private static final String UNSUBSCRIBE_COUNTER = METRICS_PREFIX + "unsubscribe";
     private static final String GET_LOGS_COUNTER = METRICS_PREFIX + "command/get_logs";

src/main/java/com/arpnetworking/tsdcore/sinks/PeriodFilteringSink.java

@@ -53,7 +53,7 @@ public void close() {
     @LogValue
     @Override
     public Object toLogValue() {
-        return LogValueMapFactory.<String, Object>builder()
+        return LogValueMapFactory.builder(this)
                 .put("super", super.toLogValue())
                 .put("include", _include)
                 .put("exclude", _exclude)

src/main/java/com/arpnetworking/tsdcore/sinks/TelemetrySink.java

@@ -45,7 +45,7 @@ public void close() {
     @LogValue
     @Override
     public Object toLogValue() {
-        return LogValueMapFactory.<String, Object>builder()
+        return LogValueMapFactory.builder(this)
                 .put("super", super.toLogValue())
                 .put("telemetryActor", _telemetryActor)
                 .build();

src/main/java/com/arpnetworking/tsdcore/sinks/TimeThresholdSink.java

@@ -120,7 +120,6 @@ private Filter(
         }
 
         public ImmutableMultimap<String, AggregatedData> filter(final PeriodicData periodicData) {
-            final ImmutableMultimap.Builder<String, AggregatedData> retainedDataBuilder = ImmutableMultimap.builder();
             if (!periodicData.getStart().plus(periodicData.getPeriod()).plus(_freshnessThreshold).isAfter(ZonedDateTime.now())
                     && !_excludedServices.contains(periodicData.getDimensions().getService())) {
                 // Exclude all data

src/main/java/com/arpnetworking/utility/Configurator.java

@@ -51,7 +51,6 @@ public synchronized void offerConfiguration(final Configuration configuration) t
         _offeredConfiguration = configuration.getAs(_configurationClass);
     }
 
-    @SuppressWarnings("unchecked")
     @Override
     public synchronized void applyConfiguration() {
         // Shutdown