Skip to content

Commit e5dd317

Browse files
authored
Actually propagate the request time to CAGG >.> (#205)
Co-authored-by: William Ehlhardt <[email protected]>
1 parent fd96573 commit e5dd317

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/main/java/com/arpnetworking/tsdcore/model/PeriodicDataToProtoConverter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ private static Messages.StatisticSetRecord convertAggregatedData(
6868
.setMetric(metricName)
6969
.setPeriod(periodicData.getPeriod().toString())
7070
.setPeriodStart(periodicData.getStart().toString())
71+
.setClientMinimumRequestTime(periodicData.getMinRequestTime().map(t -> t.toString()).orElse(""))
7172
.putAllDimensions(periodicData.getDimensions().getParameters())
7273
.setCluster(periodicData.getDimensions().getCluster())
7374
.setService(periodicData.getDimensions().getService());

src/test/java/com/arpnetworking/tsdcore/model/PeriodicDataToProtoConverterTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public void conversionTest() {
5555
.setPopulationSize((long) 1337).build()))
5656
.setPeriod(Duration.ofMinutes(5))
5757
.setStart(ZonedDateTime.parse("2020-06-04T16:04:38.424-07:00[America/Los_Angeles]"))
58+
.setMinRequestTime(ZonedDateTime.parse("2019-01-03T05:06:07.890-07:00[America/Los_Angeles]"))
5859
.build();
5960

6061
final List<Messages.StatisticSetRecord> converted = PeriodicDataToProtoConverter.convert(data);
@@ -83,7 +84,8 @@ public void conversionTest() {
8384
+ "dimensions {\n"
8485
+ " key: \"cluster\"\n"
8586
+ " value: \"cluster-test\"\n"
86-
+ "}\n",
87+
+ "}\n"
88+
+ "client_minimum_request_time: \"2019-01-03T05:06:07.890-08:00[America/Los_Angeles]\"\n",
8789

8890
converted.get(0).toString());
8991
}

0 commit comments

Comments
 (0)