Monitoring sinks configuration. (#222)

Author: vjkoskela

pom.xml

@@ -92,7 +92,7 @@
     <log4j.over.slf4j.version>1.7.25</log4j.over.slf4j.version>
     <metrics.aggregator.protocol.prometheus.version>1.0.0</metrics.aggregator.protocol.prometheus.version>
     <metrics.aggregator.protocol.version>1.0.10</metrics.aggregator.protocol.version>
-    <metrics.client.version>0.11.2</metrics.client.version>
+    <metrics.client.version>0.11.3</metrics.client.version>
     <metrics.client.http.version>0.11.2</metrics.client.http.version>
     <metrics.client.incubator.version>0.11.2</metrics.client.incubator.version>
     <metrics.jvm.extra.version>0.11.2</metrics.jvm.extra.version>
@@ -465,8 +465,8 @@
                   <KAFKA_SOURCE_BOOTSTRAP_HOST>kafka</KAFKA_SOURCE_BOOTSTRAP_HOST>
                   <!-- TODO(ville): Obtain these from the current user! -->
                   <!-- Ref: https://github.com/rynr/user-id-maven-plugin -->
-                  <KDB_UID>1000</KDB_UID>
-                  <KDB_GID>1000</KDB_GID>
+                  <MAD_UID>1000</MAD_UID>
+                  <MAD_GID>1000</MAD_GID>
                 </env>
                 <volumes>
                   <bind>

src/main/java/com/arpnetworking/metrics/mad/configuration/AggregatorConfiguration.java

@@ -209,10 +209,10 @@ public Builder setMonitoringService(final String value) {
         }
 
         /**
-         * The monitoring sinks. Optional. The default value is the default
-         * instance of {@link com.arpnetworking.metrics.impl.ApacheHttpSink}.
+         * The monitoring sinks. Optional. Cannot be null. The default value is
+         * the default instance of {@link com.arpnetworking.metrics.impl.ApacheHttpSink}.
          *
-         * @param value The monitoring service.
+         * @param value The monitoring sinks.
          * @return This instance of {@link Builder}.
          */
         public Builder setMonitoringSinks(final ImmutableList<JsonNode> value) {
@@ -374,6 +374,7 @@ public Builder setAkkaConfiguration(final Map<String, ?> value) {
         @NotNull
         @NotEmpty
         private String _monitoringService = "mad";
+        // TODO(ville): Apply the default here once we migrate off JsonNode.
         @NotNull
         private ImmutableList<JsonNode> _monitoringSinks;
         @Nullable
@@ -383,7 +384,7 @@ public Builder setAkkaConfiguration(final Map<String, ?> value) {
         @Range(min = 1, max = 65535)
         private Integer _metricsClientPort;
         @NotNull
-        private Duration _jvmMetricsCollectionInterval = Duration.ofMillis(500);
+        private Duration _jvmMetricsCollectionInterval = Duration.ofMillis(1000);
         @NotNull
         private File _logDirectory;
         @NotNull