Fix Maven on GHA by overriding the http wagon with a custom build. (#239)

* Fix Maven on GHA by overriding the http wagon with a custom build.

* Addressed feedback.

Author: vjkoskela

.github/fix-maven.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+MAVEN_HOME=$(./jdk-wrapper.sh ./mvnw -v | awk '/^Maven home:/ { print $3 }')
+if [ -d "$MAVEN_HOME" ]; then
+  echo "Installing custom wagon-http jar to $MAVEN_HOME/lib"
+  ls -l "$MAVEN_HOME/lib/"wagon-http-*-shaded.jar
+  rm "$MAVEN_HOME/lib/"wagon-http-*-shaded.jar
+  cp ./.github/wagon-http-* "$MAVEN_HOME/lib/"
+  ls -l "$MAVEN_HOME/lib/"wagon-http-*-shaded.jar
+else
+  echo "Unable to fix Maven!"
+fi

.github/wagon-http-5ff79d284-shaded.jar

@@ -27,6 +27,12 @@ jobs:
           path: ~/.m2
           key: ${{ runner.os }}-m2-${{ hashFiles('pom.xml') }}
           restore-keys: ${{ runner.os }}-m2-
+# The Maven fix involves replacing an artifact that is in the cache directory;
+# consequently the fix gets cached. The problem arises when we need to remove
+# the fix that we need to do so in a way that keeps the cache from regressing.
+# The easiest way is to change the cache key when deprecating the fix.
+      - name: Fix Maven
+        run: ./.github/fix-maven.sh
       - name: Build Only
         if: startsWith(github.ref, 'refs/tags/metrics-aggregator-daemon-') != true
         run: ./jdk-wrapper.sh ./mvnw clean verify -P rpm -U -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120