refactor emitter initialization

Author: BrandonArp

src/main/java/com/arpnetworking/clusteraggregator/GuiceModule.java

@@ -164,54 +164,39 @@ private ActorSystem provideActorSystem(@Named("akka-config") final Config akkaCo
     @Named("cluster-emitter")
     @SuppressFBWarnings("UPM_UNCALLED_PRIVATE_METHOD") // Invoked reflectively by Guice
     private ActorRef provideClusterEmitter(final Injector injector, final ActorSystem system) {
+        return launchEmitter(injector, system, _configuration.getClusterPipelineConfiguration(), "cluster-emitter-configurator");
+    }
+
+    @Provides
+    @Singleton
+    @Named("host-emitter")
+    @SuppressFBWarnings("UPM_UNCALLED_PRIVATE_METHOD") // Invoked reflectively by Guice
+    private ActorRef provideHostEmitter(final Injector injector, final ActorSystem system) {
+        return launchEmitter(injector, system, _configuration.getHostPipelineConfiguration(), "host-emitter-configurator");
+    }
+
+    private ActorRef launchEmitter(final Injector injector, final ActorSystem system, final File pipelineFile, final String name) {
         final ActorRef emitterConfigurationProxy = system.actorOf(
                 ConfigurableActorProxy.props(new RoundRobinEmitterFactory()),
-                "cluster-emitter-configurator");
+                name);
         final ActorConfigurator<EmitterConfiguration> configurator =
                 new ActorConfigurator<>(emitterConfigurationProxy, EmitterConfiguration.class);
         final ObjectMapper objectMapper = EmitterConfiguration.createObjectMapper(injector);
-        final File configurationFile = _configuration.getClusterPipelineConfiguration();
         final Builder<? extends JsonNodeSource> sourceBuilder;
-        if (configurationFile.getName().toLowerCase(Locale.getDefault()).endsWith(HOCON_FILE_EXTENSION)) {
+        if (pipelineFile.getName().toLowerCase(Locale.getDefault()).endsWith(HOCON_FILE_EXTENSION)) {
             sourceBuilder = new HoconFileSource.Builder()
                     .setObjectMapper(objectMapper)
-                    .setFile(configurationFile);
+                    .setFile(pipelineFile);
         } else {
             sourceBuilder = new JsonNodeFileSource.Builder()
                     .setObjectMapper(objectMapper)
-                    .setFile(configurationFile);
+                    .setFile(pipelineFile);
         }
 
         final DynamicConfiguration configuration = new DynamicConfiguration.Builder()
                 .setObjectMapper(objectMapper)
                 .addSourceBuilder(sourceBuilder)
-                .addTrigger(new FileTrigger.Builder().setFile(_configuration.getClusterPipelineConfiguration()).build())
-                .addListener(configurator)
-                .build();
-
-        configuration.launch();
-
-        return emitterConfigurationProxy;
-    }
-
-    @Provides
-    @Singleton
-    @Named("host-emitter")
-    @SuppressFBWarnings("UPM_UNCALLED_PRIVATE_METHOD") // Invoked reflectively by Guice
-    private ActorRef provideHostEmitter(final Injector injector, final ActorSystem system) {
-        final ActorRef emitterConfigurationProxy = system.actorOf(
-                ConfigurableActorProxy.props(new RoundRobinEmitterFactory()),
-                "host-emitter-configurator");
-        final ActorConfigurator<EmitterConfiguration> configurator =
-                new ActorConfigurator<>(emitterConfigurationProxy, EmitterConfiguration.class);
-        final ObjectMapper objectMapper = EmitterConfiguration.createObjectMapper(injector);
-        final DynamicConfiguration configuration = new DynamicConfiguration.Builder()
-                .setObjectMapper(objectMapper)
-                .addSourceBuilder(
-                        new JsonNodeFileSource.Builder()
-                                .setObjectMapper(objectMapper)
-                                .setFile(_configuration.getHostPipelineConfiguration()))
-                .addTrigger(new FileTrigger.Builder().setFile(_configuration.getHostPipelineConfiguration()).build())
+                .addTrigger(new FileTrigger.Builder().setFile(pipelineFile).build())
                 .addListener(configurator)
                 .build();