Fix failing Dependabot update tests (#571)

* Bump io.netty:netty-codec-http from 4.2.6.Final to 4.2.7.Final

Bumps [io.netty:netty-codec-http](https://github.com/netty/netty) from 4.2.6.Final to 4.2.7.Final.
- [Commits](netty/netty@netty-4.2.6.Final...netty-4.2.7.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-codec-http
  dependency-version: 4.2.7.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix Netty 4.2.7 compatibility by using string literals for HTTP headers

Replace Netty HttpHeaderNames and HttpHeaderValues constants with plain
string literals to avoid compatibility issues with Netty 4.2.7.Final.

Changes:
- Replace HttpHeaderNames.CONTENT_TYPE with "Content-Type"
- Replace HttpHeaderNames.CONTENT_ENCODING with "Content-Encoding"
- Replace HttpHeaderValues.GZIP with "gzip"
- Remove unused Netty header imports

This avoids any potential incompatibilities between AsyncHttpClient 3.0.3
and Netty 4.2.7's header constant implementations.

* Add Netty BOM to dependency management to resolve version conflicts

AsyncHttpClient 3.0.3 brings in various Netty 4.2 modules transitively,
but the project also has old Netty 4.0.x versions defined (netty.version
and netty.all.version). This version mismatch was causing runtime failures
where no HTTP requests were being sent.

By adding the Netty BOM (Bill of Materials) to dependencyManagement, all
Netty modules across the project will be forced to use version 4.2.7.Final
consistently, preventing classpath conflicts.

This should resolve the test failures in KairosDbSinkTest where requests
were not being sent to the mock server.

* Remove unused netty-codec-http dependency

Since we replaced all Netty header constants with string literals,
the explicit netty-codec-http dependency is no longer directly used.
AsyncHttpClient brings in the required Netty dependencies transitively,
and the Netty BOM in dependencyManagement ensures they're all at
version 4.2.7.Final.

This resolves the Maven dependency analyzer warning about unused
declared dependencies.

* Consolidate Netty version properties to use netty.version

Replaced the netty.codec.http.version property with the standard
netty.version property, updating it from 4.0.56.Final to 4.2.7.Final.

This makes the versioning clearer - netty.version is now the single
source of truth for the Netty version used throughout the project,
applied via the Netty BOM in dependencyManagement.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude <[email protected]>

Author: 3 people

pom.xml

@@ -138,9 +138,8 @@
     <metrics.http.extra.version>0.14.1</metrics.http.extra.version>
     <metrics.aggregator.protocol.version>1.3.1</metrics.aggregator.protocol.version>
     <mockito.version>5.20.0</mockito.version>
-    <netty.version>4.0.56.Final</netty.version>
+    <netty.version>4.2.7.Final</netty.version>
     <netty.all.version>4.0.21.Final</netty.all.version>
-    <netty.codec.http.version>4.2.6.Final</netty.codec.http.version>
     <ning.http.client.version>1.9.31</ning.http.client.version>
     <oval.version>3.2.1</oval.version>
     <play.ws.version>3.0.9</play.ws.version>
@@ -860,11 +859,6 @@
       <artifactId>async-http-client</artifactId>
       <version>${asynchttpclient.version}</version>
     </dependency>
-    <dependency>
-      <groupId>io.netty</groupId>
-      <artifactId>netty-codec-http</artifactId>
-      <version>${netty.codec.http.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.playframework</groupId>
       <artifactId>play-ahc-ws-standalone_${scala.version}</artifactId>
@@ -976,6 +970,13 @@
         <scope>import</scope>
         <type>pom</type>
       </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-bom</artifactId>
+        <version>${netty.version}</version>
+        <scope>import</scope>
+        <type>pom</type>
+      </dependency>
     </dependencies>
   </dependencyManagement>
   <profiles>

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java

@@ -25,8 +25,6 @@
 import com.fasterxml.jackson.annotation.JacksonInject;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
-import io.netty.handler.codec.http.HttpHeaderNames;
-import io.netty.handler.codec.http.HttpHeaderValues;
 import net.sf.oval.Validator;
 import net.sf.oval.constraint.CheckWith;
 import net.sf.oval.constraint.CheckWithCheck;
@@ -127,12 +125,12 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
 
         final RequestBuilder requestBuilder = new RequestBuilder()
                 .setUri(getAysncHttpClientUri())
-                .setHeader(HttpHeaderNames.CONTENT_TYPE, MediaTypes.APPLICATION_JSON.toString())
+                .setHeader("Content-Type", MediaTypes.APPLICATION_JSON.toString())
                 .setBody(bodyData)
                 .setMethod(HttpConstants.Methods.POST);
 
         if (_enableCompression) {
-            requestBuilder.setHeader(HttpHeaderNames.CONTENT_ENCODING, HttpHeaderValues.GZIP);
+            requestBuilder.setHeader("Content-Encoding", "gzip");
         }
 
         return new RequestInfo(requestBuilder.build(), serializedData.length, bodyData.length);

src/main/java/com/arpnetworking/tsdcore/sinks/KairosDbSink.java

@@ -35,7 +35,6 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
-import io.netty.handler.codec.http.HttpHeaderNames;
 import it.unimi.dsi.fastutil.doubles.Double2LongMap;
 import net.sf.oval.constraint.Min;
 import net.sf.oval.constraint.NotNull;
@@ -177,7 +176,7 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
 
             final RequestBuilder requestBuilder = new RequestBuilder()
                     .setUri(getAysncHttpClientUri())
-                    .setHeader(HttpHeaderNames.CONTENT_TYPE, "application/gzip")
+                    .setHeader("Content-Type", "application/gzip")
                     .setBody(bodyData)
                     .setMethod(HttpConstants.Methods.POST);