Skip to content

Commit 1ffaeed

Browse files
PhoenixRionBrandonArp
authored andcommitted
Fix map duplicates (#55)
* ensure no duplicates in map * forgot imports chose better variable name * replace putall logic with foreach on stream
1 parent 9ad380d commit 1ffaeed

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/main/java/com/arpnetworking/clusteraggregator/client/AggClientConnection.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,16 @@ private Optional<PeriodicData> buildPeriodicData(final Messages.StatisticSetReco
193193
final CombinedMetricData combinedMetricData = CombinedMetricData.Builder.fromStatisticSetRecord(setRecord).build();
194194
final ImmutableList.Builder<AggregatedData> builder = ImmutableList.builder();
195195
final Map<String, String> dimensionsMap = setRecord.getDimensionsMap();
196-
final ImmutableMap.Builder<String, String> dimensionBuilder = ImmutableMap.<String, String>builder().putAll(dimensionsMap);
196+
final ImmutableMap.Builder<String, String> dimensionBuilder = ImmutableMap.builder();
197+
198+
dimensionsMap.entrySet().stream()
199+
.filter(entry ->
200+
!CombinedMetricData.HOST_KEY.equals(entry.getKey())
201+
&& !CombinedMetricData.SERVICE_KEY.equals(entry.getKey())
202+
&& !CombinedMetricData.CLUSTER_KEY.equals(entry.getKey()))
203+
.forEach(dim ->
204+
dimensionBuilder.put(dim.getKey(), dim.getValue()
205+
));
197206

198207
Optional<String> host = Optional.ofNullable(dimensionsMap.get(CombinedMetricData.HOST_KEY));
199208
Optional<String> service = Optional.ofNullable(dimensionsMap.get(CombinedMetricData.SERVICE_KEY));

0 commit comments

Comments
 (0)