PR feedback

Author: BrandonArp

src/main/java/com/arpnetworking/tsdcore/model/RequestEntry.java

@@ -112,7 +112,7 @@ public Builder setPopulationSize(final Optional<Long> value) {
         }
 
         /**
-         * Set the request body size. Cannot be null.
+         * Set the request body size. Required. Cannot be null.
          *
          * @param value The request body size.
          * @return This {@link Builder} instance.
@@ -123,7 +123,7 @@ public Builder setRequestBodySize(final Long value) {
         }
 
         /**
-         * Set the request body encoded size. Cannot be null.
+         * Set the request body encoded size. Required. Cannot be null.
          *
          * @param value The request body encoded size.
          * @return This {@link Builder} instance.
@@ -140,9 +140,9 @@ public Builder setRequestBodyEncodedSize(final Long value) {
         @NotNull
         private Optional<Long> _populationSize = Optional.empty();
         @NotNull
-        private Long _requestBodySize = null;
+        private Long _requestBodySize;
         @NotNull
-        private Long _requestBodyEncodedSize = null;
+        private Long _requestBodyEncodedSize;
     }
 }
 

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java

@@ -111,11 +111,11 @@ public Object toLogValue() {
     protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] serializedData) {
         final byte[] bodyData;
         if (_enableCompression) {
-            try {
-                final ByteArrayOutputStream bos = new ByteArrayOutputStream();
-                final GZIPOutputStream gzipStream = new GZIPOutputStream(bos);
+            try (ByteArrayOutputStream bos = new ByteArrayOutputStream();
+                 GZIPOutputStream gzipStream = new GZIPOutputStream(bos)) {
+
                 gzipStream.write(serializedData);
-                gzipStream.close();
+                gzipStream.flush();
                 bodyData = bos.toByteArray();
             } catch (final IOException e) {
                 throw new RuntimeException(e);
@@ -440,7 +440,7 @@ public B setRetryableStatusCodes(final ImmutableSet<Integer> value) {
 
         /**
          * Sets whether to enable request compression.
-         * Optional. Defaults to true.
+         * Optional. Defaults to false.
          *
          * @param value true to enable compression
          * @return This instance of {@link Builder}.
@@ -453,7 +453,7 @@ public B setEnableCompression(final Boolean value) {
         /**
          * Protected constructor for subclasses.
          *
-         * @param targetConstructor The constructor for the concrete type to be created by this builder.
+         * @param targetConstructor The constructor for this builder to create the concrete type.
          */
         protected Builder(final Function<B, S> targetConstructor) {
             super(targetConstructor);
@@ -542,7 +542,7 @@ public boolean isSatisfied(
      * @param bodySize The size of the request body in bytes.
      * @param encodedSize The size of the encoded request body in bytes.
      */
-    record RequestInfo(Request request, long bodySize, long encodedSize) { }
+    protected record RequestInfo(Request request, long bodySize, long encodedSize) { }
 
     static final class SerializedDatum {
         SerializedDatum(final byte[] datum, final Optional<Long> populationSize) {