Switched from Java serialization to Kyro serialization for remoting. (#48)

Author: vjkoskela

config/config.hocon

@@ -42,11 +42,25 @@ databaseConfigurations {
 }
 akkaConfiguration {
   akka {
+    extensions=["com.romix.akka.serialization.kryo.KryoSerializationExtension$"]
     loggers=["akka.event.slf4j.Slf4jLogger"]
     loglevel="DEBUG"
     stdout-loglevel="DEBUG"
     logging-filter="akka.event.slf4j.Slf4jLoggingFilter"
     actor {
+      serializers {
+        kryo="com.romix.akka.serialization.kryo.KryoSerializer"
+      }
+      serialization-bindings {
+        "java.lang.Object"="kryo"
+        "java.io.Serializable"="none"
+      }
+      kryo {
+        type="graph"
+        idstrategy="default"
+        buffer-size=4096
+        max-buffer-size=-1
+      }
       debug {
         unhandled="on"
       }

pom.xml

@@ -101,9 +101,10 @@
 
   <properties>
     <!--Dependency versions-->
-    <akka.version>2.4.2</akka.version>
-    <akka.http.version>2.4.2</akka.http.version>
+    <akka.version>2.4.14</akka.version>
+    <akka.http.version>2.4.11</akka.http.version>
     <akka.persistence.cassandra.version>0.6</akka.persistence.cassandra.version>
+    <akka.kryo.version>0.5.0</akka.kryo.version>
     <apache.httpclient.version>4.5.1</apache.httpclient.version>
     <apache.httpcore.version>4.4.3</apache.httpcore.version>
     <arpnetworking.commons.version>1.7.1</arpnetworking.commons.version>
@@ -617,6 +618,12 @@
       <version>${leveldb.jni.version}</version>
       <scope>runtime</scope>
     </dependency>
+    <dependency>
+      <groupId>com.github.romix.akka</groupId>
+      <artifactId>akka-kryo-serialization_${scala.version}</artifactId>
+      <version>${akka.kryo.version}</version>
+      <scope>runtime</scope>
+    </dependency>
     <!-- Database -->
     <dependency>
       <groupId>javax.persistence</groupId>

src/main/java/com/arpnetworking/clusteraggregator/GuiceModule.java

@@ -48,6 +48,7 @@
 import com.arpnetworking.clusteraggregator.http.Routes;
 import com.arpnetworking.clusteraggregator.partitioning.DatabasePartitionSet;
 import com.arpnetworking.commons.builder.Builder;
+import com.arpnetworking.commons.jackson.databind.ObjectMapperFactory;
 import com.arpnetworking.configuration.jackson.DynamicConfiguration;
 import com.arpnetworking.configuration.jackson.HoconFileSource;
 import com.arpnetworking.configuration.jackson.JsonNodeFileSource;
@@ -65,6 +66,7 @@
 import com.arpnetworking.utility.partitioning.PartitionSet;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.base.Optional;
+import com.google.common.base.Throwables;
 import com.google.inject.AbstractModule;
 import com.google.inject.Injector;
 import com.google.inject.Provides;
@@ -73,9 +75,12 @@
 import com.google.inject.name.Names;
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigParseOptions;
+import com.typesafe.config.ConfigSyntax;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.Collections;
 import java.util.Locale;
 import java.util.Map;
@@ -117,7 +122,19 @@ protected void configure() {
     @Named("akka-config")
     @SuppressFBWarnings("UPM_UNCALLED_PRIVATE_METHOD") // Invoked reflectively by Guice
     private Config provideAkkaConfig() {
-        return ConfigFactory.parseMap(_configuration.getAkkaConfiguration(), _configuration.toString());
+        // This is necessary because the keys contain periods which when
+        // transforming from a map are considered compound path elements. By
+        // rendering to JSON and then parsing it this forces the keys to be
+        // quoted and thus considered single path elements even with periods.
+        try {
+            final String akkaJsonConfig = OBJECT_MAPPER.writeValueAsString(_configuration.getAkkaConfiguration());
+            return ConfigFactory.parseString(
+                    akkaJsonConfig,
+                    ConfigParseOptions.defaults()
+                            .setSyntax(ConfigSyntax.JSON));
+        } catch (final IOException e) {
+            throw Throwables.propagate(e);
+        }
     }
 
     @Provides
@@ -362,10 +379,10 @@ private PartitionSet provideDatabasePartitionSet(@Named("metrics_clusteragg") fi
         return new DatabasePartitionSet(database, partitionSet);
     }
 
-
     private final ClusterAggregatorConfiguration _configuration;
 
     private static final String HOCON_FILE_EXTENSION = ".hocon";
+    private static final ObjectMapper OBJECT_MAPPER = ObjectMapperFactory.getInstance();
 
     private static final class RoundRobinEmitterFactory implements ConfiguredLaunchableFactory<Props, EmitterConfiguration> {
 

src/main/java/com/arpnetworking/clusteraggregator/models/StatusResponse.java

@@ -295,13 +295,17 @@ private static final class MemberSerializer extends JsonSerializer<Member> {
          * {@inheritDoc}
          */
         @Override
-        public void serialize(final Member value, final JsonGenerator gen, final SerializerProvider serializers) throws IOException {
+        public void serialize(
+                final Member value,
+                final JsonGenerator gen,
+                final SerializerProvider serializers)
+                throws IOException {
             gen.writeStartObject();
             gen.writeStringField("address", value.address().toString());
             gen.writeObjectField("roles", JavaConversions.setAsJavaSet(value.roles()));
             gen.writeNumberField("upNumber", value.upNumber());
             gen.writeStringField("status", value.status().toString());
-            gen.writeNumberField("uniqueAddress", value.uniqueAddress().uid());
+            gen.writeNumberField("uniqueAddress", value.uniqueAddress().longUid());
             gen.writeEndObject();
         }
     }