Skip to content

Commit 730f4f3

Browse files
committed
Fix Netty 4.2.7 compatibility by converting HttpHeaderNames constants to strings
The netty-codec-http dependency was updated from 4.2.6.Final to 4.2.7.Final. This introduced an incompatibility where HttpHeaderNames and HttpHeaderValues constants (which return AsciiString) need to be explicitly converted to String when passed to AsyncHttpClient's setHeader method. Changes: - Convert HttpHeaderNames.CONTENT_TYPE to string in HttpPostSink and KairosDbSink - Convert HttpHeaderNames.CONTENT_ENCODING to string in HttpPostSink - Convert HttpHeaderValues.GZIP to string in HttpPostSink This ensures compatibility with AsyncHttpClient 3.0.3 and Netty 4.2.7.Final.
1 parent d68dc4e commit 730f4f3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
127127

128128
final RequestBuilder requestBuilder = new RequestBuilder()
129129
.setUri(getAysncHttpClientUri())
130-
.setHeader(HttpHeaderNames.CONTENT_TYPE, MediaTypes.APPLICATION_JSON.toString())
130+
.setHeader(HttpHeaderNames.CONTENT_TYPE.toString(), MediaTypes.APPLICATION_JSON.toString())
131131
.setBody(bodyData)
132132
.setMethod(HttpConstants.Methods.POST);
133133

134134
if (_enableCompression) {
135-
requestBuilder.setHeader(HttpHeaderNames.CONTENT_ENCODING, HttpHeaderValues.GZIP);
135+
requestBuilder.setHeader(HttpHeaderNames.CONTENT_ENCODING.toString(), HttpHeaderValues.GZIP.toString());
136136
}
137137

138138
return new RequestInfo(requestBuilder.build(), serializedData.length, bodyData.length);

src/main/java/com/arpnetworking/tsdcore/sinks/KairosDbSink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
177177

178178
final RequestBuilder requestBuilder = new RequestBuilder()
179179
.setUri(getAysncHttpClientUri())
180-
.setHeader(HttpHeaderNames.CONTENT_TYPE, "application/gzip")
180+
.setHeader(HttpHeaderNames.CONTENT_TYPE.toString(), "application/gzip")
181181
.setBody(bodyData)
182182
.setMethod(HttpConstants.Methods.POST);
183183

0 commit comments

Comments
 (0)