Skip to content

Commit 82905c9

Browse files
committed
use mock for metricsFactory
1 parent e938917 commit 82905c9

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/test/java/com/arpnetworking/tsdcore/sinks/KairosDbSinkTest.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
import akka.http.javadsl.model.MediaTypes;
1919
import com.arpnetworking.commons.jackson.databind.ObjectMapperFactory;
20+
import com.arpnetworking.metrics.Metrics;
2021
import com.arpnetworking.metrics.MetricsFactory;
21-
import com.arpnetworking.metrics.impl.TsdMetricsFactory;
2222
import com.arpnetworking.tsdcore.model.AggregatedData;
2323
import com.arpnetworking.tsdcore.model.Condition;
2424
import com.arpnetworking.tsdcore.model.FQDSN;
@@ -39,6 +39,8 @@
3939
import org.junit.Assert;
4040
import org.junit.Before;
4141
import org.junit.Test;
42+
import org.mockito.Mock;
43+
import org.mockito.Mockito;
4244

4345
import java.io.IOException;
4446
import java.net.URI;
@@ -57,12 +59,12 @@ public void setUp() {
5759
_wireMockServer = new WireMockServer(0);
5860
_wireMockServer.start();
5961
_wireMock = new WireMock(_wireMockServer.port());
60-
6162
_kairosDbSinkBuilder = new KairosDbSink.Builder()
6263
.setName("kairosdb_sink_test")
6364
.setActorSystem(getSystem())
6465
.setUri(URI.create("http://localhost:" + _wireMockServer.port() + PATH))
65-
.setMetricsFactory(METRICS_FACTORY);
66+
.setMetricsFactory(_mockMetricsFactory);
67+
Mockito.doReturn(_mockMetrics).when(_mockMetricsFactory).create();
6668
}
6769

6870
@After
@@ -116,7 +118,6 @@ public void testPost() throws InterruptedException, IOException {
116118
.setPeriod(Period.minutes(1))
117119
.setStart(start)
118120
.build());
119-
120121
// Allow the request/response to complete
121122
Thread.sleep(1000);
122123

@@ -140,7 +141,9 @@ public void testPost() throws InterruptedException, IOException {
140141
private static final String PATH = "/kairos/post/path";
141142
private static final StatisticFactory STATISTIC_FACTORY = new StatisticFactory();
142143
private static final ObjectMapper OBJECT_MAPPER = ObjectMapperFactory.getInstance();
143-
private static final MetricsFactory METRICS_FACTORY = TsdMetricsFactory.newInstance(
144-
"mock_metrics_factory",
145-
"mock_metrics_factory");
144+
145+
@Mock
146+
private Metrics _mockMetrics;
147+
@Mock
148+
private MetricsFactory _mockMetricsFactory;
146149
}

0 commit comments

Comments
 (0)