Add a try/catch and some extra logging around firing requests (#173)

Author: BrandonArp

src/main/java/com/arpnetworking/tsdcore/sinks/HttpSinkActor.java

@@ -152,6 +152,11 @@ public void preRestart(final Throwable reason, final Optional<Object> message) t
         super.preRestart(reason, message);
 
         _periodicMetrics.recordCounter("actors/http_post_sink/restarted", 1);
+        LOGGER.error()
+                .setMessage("Actor restarted")
+                .addData("sink", _sink)
+                .setThrowable(reason)
+                .log();
     }
 
     /**
@@ -385,7 +390,21 @@ private void fireNextRequest() {
             _periodicMetrics.recordTimer(_inQueueLatencyName, latencyInMillis, Optional.of(TimeUnit.MILLISECONDS));
 
             _inflightRequestsCount++;
-            fireRequest(requestEntry, 1);
+            try {
+                fireRequest(requestEntry, 1);
+            // CHECKSTYLE.OFF: IllegalCatch - We need to catch everything here
+            } catch (final RuntimeException e) {
+            // CHECKSTYLE.ON: IllegalCatch
+                _inflightRequestsCount--;
+                POST_ERROR_LOGGER.error()
+                        .setMessage("Error while sending request")
+                        .addData("sink", _sink)
+                        .addData("request", requestEntry)
+                        .addContext("actor", self())
+                        .setThrowable(e)
+                        .log();
+                throw e;
+            }
         }
     }
 
@@ -402,9 +421,9 @@ private void fireRequest(final RequestEntry request, final int attempt) {
                             Optional.of(TimeUnit.MILLISECONDS));
                     if (err == null) {
                         if (_acceptedStatusCodes.contains(result.getStatusCode())) {
-                             return new PostSuccess(attempt, request, result);
+                            return new PostSuccess(attempt, request, result);
                         } else {
-                             return new PostRejected(attempt, request, result);
+                            return new PostRejected(attempt, request, result);
                         }
                     } else {
                         return new PostFailure(attempt, request, err);