Skip to content

Commit 913dae4

Browse files
committed
fix deprecation issues
1 parent c62562b commit 913dae4

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

src/main/java/com/arpnetworking/clusteraggregator/client/AggClientConnection.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import com.arpnetworking.tsdcore.statistics.Statistic;
2929
import com.google.common.collect.ImmutableList;
3030
import com.google.common.collect.ImmutableMap;
31-
import com.google.protobuf.GeneratedMessageV3;
31+
import com.google.protobuf.GeneratedMessage;
3232
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
3333
import org.apache.pekko.actor.AbstractActor;
3434
import org.apache.pekko.actor.ActorRef;
@@ -153,7 +153,7 @@ private void processMessages() {
153153
while (messageOptional.isPresent()) {
154154
final AggregationMessage message = messageOptional.get();
155155
current = current.drop(message.getLength());
156-
final GeneratedMessageV3 gm = message.getMessage();
156+
final GeneratedMessage gm = message.getMessage();
157157
if (gm instanceof Messages.HostIdentification) {
158158
final Messages.HostIdentification hostIdent = (Messages.HostIdentification) gm;
159159
_hostName = Optional.ofNullable(hostIdent.getHostName());

src/main/java/com/arpnetworking/clusteraggregator/client/HttpSourceActor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import com.google.common.util.concurrent.AtomicDouble;
3737
import com.google.inject.Inject;
3838
import com.google.inject.name.Named;
39-
import com.google.protobuf.GeneratedMessageV3;
39+
import com.google.protobuf.GeneratedMessage;
4040
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
4141
import org.apache.http.HttpHeaders;
4242
import org.apache.pekko.Done;
@@ -145,8 +145,8 @@ private void handleAggregation(
145145

146146
final AggregationMode aggregationMode = aggregationRequest.getAggregationMode();
147147
for (final AggregationMessage aggregationMessage : aggregationRequest.getAggregationMessages()) {
148-
final GeneratedMessageV3 generatedMessageV3 = aggregationMessage.getMessage();
149-
if (generatedMessageV3 instanceof Messages.StatisticSetRecord) {
148+
final GeneratedMessage generatedMessage = aggregationMessage.getMessage();
149+
if (generatedMessage instanceof Messages.StatisticSetRecord) {
150150
final Messages.StatisticSetRecord statisticSetRecord =
151151
(Messages.StatisticSetRecord) aggregationMessage.getMessage();
152152

src/main/java/com/arpnetworking/tsdcore/model/AggregationMessage.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package com.arpnetworking.tsdcore.model;
1717

1818
import com.arpnetworking.metrics.aggregation.protocol.Messages;
19-
import com.google.protobuf.GeneratedMessageV3;
19+
import com.google.protobuf.GeneratedMessage;
2020
import com.google.protobuf.InvalidProtocolBufferException;
2121
import org.apache.commons.codec.binary.Hex;
2222
import org.apache.pekko.util.ByteIterator;
@@ -42,7 +42,7 @@ public final class AggregationMessage {
4242
* @param message The message.
4343
* @return New {@link AggregationMessage} instance.
4444
*/
45-
public static AggregationMessage create(final GeneratedMessageV3 message) {
45+
public static AggregationMessage create(final GeneratedMessage message) {
4646
return new AggregationMessage(message);
4747
}
4848

@@ -139,7 +139,7 @@ public ByteString serialize() {
139139
return AggregationMessage.serialize(_message);
140140
}
141141

142-
private static ByteString serialize(final GeneratedMessageV3 message) {
142+
private static ByteString serialize(final GeneratedMessage message) {
143143
final ByteStringBuilder b = ByteString.createBuilder();
144144
if (message instanceof Messages.HostIdentification) {
145145
b.putByte((byte) 0x01);
@@ -166,24 +166,24 @@ private static ByteString serialize(final GeneratedMessageV3 message) {
166166
return sizePrefix.result().concat(b.result());
167167
}
168168

169-
public GeneratedMessageV3 getMessage() {
169+
public GeneratedMessage getMessage() {
170170
return _message;
171171
}
172172

173173
public int getLength() {
174174
return _length;
175175
}
176176

177-
private AggregationMessage(final GeneratedMessageV3 message) {
177+
private AggregationMessage(final GeneratedMessage message) {
178178
this(message, serialize(message).length());
179179
}
180180

181-
private AggregationMessage(final GeneratedMessageV3 message, final int length) {
181+
private AggregationMessage(final GeneratedMessage message, final int length) {
182182
_length = length;
183183
_message = message;
184184
}
185185

186-
private final GeneratedMessageV3 _message;
186+
private final GeneratedMessage _message;
187187
private final int _length;
188188

189189
private static final int BYTE_SIZE_IN_BYTES = 1;

src/test/java/com/arpnetworking/tsdcore/model/AggregationMessageTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package com.arpnetworking.tsdcore.model;
1717

1818
import com.arpnetworking.metrics.aggregation.protocol.Messages;
19-
import com.google.protobuf.GeneratedMessageV3;
19+
import com.google.protobuf.GeneratedMessage;
2020
import org.apache.pekko.util.ByteString;
2121
import org.apache.pekko.util.ByteStringBuilder;
2222
import org.junit.Assert;
@@ -34,7 +34,7 @@ public class AggregationMessageTest {
3434

3535
@Test
3636
public void testHostIdentification() {
37-
final GeneratedMessageV3 protobufMessage = Messages.HostIdentification.getDefaultInstance();
37+
final GeneratedMessage protobufMessage = Messages.HostIdentification.getDefaultInstance();
3838
final AggregationMessage message = AggregationMessage.create(protobufMessage);
3939
Assert.assertNotNull(message);
4040
Assert.assertSame(protobufMessage, message.getMessage());
@@ -65,7 +65,7 @@ public void testHostIdentification() {
6565

6666
@Test(expected = IllegalArgumentException.class)
6767
public void testSerializedUnsupportedMessage() {
68-
final GeneratedMessageV3 message = Messages.SparseHistogramEntry.newBuilder()
68+
final GeneratedMessage message = Messages.SparseHistogramEntry.newBuilder()
6969
.build();
7070
AggregationMessage.create(message).serialize();
7171
}

0 commit comments

Comments
 (0)