Skip to content

Commit a38240b

Browse files
author
Matthew Hayter
committed
Try-with-resources to be exception safe.
1 parent fd1fe64 commit a38240b

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/main/java/com/arpnetworking/clusteraggregator/ClusterStatusCache.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,14 @@ public void onReceive(final Object message) throws Exception {
111111
final ClusterEvent.CurrentClusterState clusterState = (ClusterEvent.CurrentClusterState) message;
112112
_clusterState = Optional.of(clusterState);
113113

114-
final Metrics metrics = _metricsFactory.create();
115-
metrics.setGauge("akka/members_count", clusterState.members().size());
116-
if (_cluster.selfAddress().equals(clusterState.getLeader())) {
117-
metrics.setGauge("akka/is_leader", 1);
118-
} else {
119-
metrics.setGauge("akka/is_leader", 0);
114+
try (final Metrics metrics = _metricsFactory.create()) {
115+
metrics.setGauge("akka/members_count", clusterState.members().size());
116+
if (_cluster.selfAddress().equals(clusterState.getLeader())) {
117+
metrics.setGauge("akka/is_leader", 1);
118+
} else {
119+
metrics.setGauge("akka/is_leader", 0);
120+
}
120121
}
121-
metrics.close();
122122
} else if (message instanceof GetRequest) {
123123
sendResponse(getSender());
124124
} else if (message instanceof ParallelLeastShardAllocationStrategy.RebalanceNotification) {

0 commit comments

Comments
 (0)