dont close the json parser when deserializing

Author: BrandonArp

config/config.hocon

@@ -12,6 +12,7 @@ jvmMetricsCollectionInterval="PT.5S"
 maxConnectionTimeout="PT2M"
 minConnectionTimeout="PT1M"
 clusterHostSuffix=".cluster"
+clusterJoinActor.type="com.arpnetworking.akka.NonJoiningClusterJoiner"
 rebalanceConfiguration {
   maxParallel=100
   threshold=500

src/main/java/com/arpnetworking/akka/NonJoiningClusterJoiner.java

@@ -17,6 +17,8 @@
 
 import akka.actor.Props;
 import akka.actor.UntypedActor;
+import com.arpnetworking.steno.Logger;
+import com.arpnetworking.steno.LoggerFactory;
 
 /**
  * Actor that does not attempt to join a cluster.
@@ -48,13 +50,17 @@ private static Props props(final Builder builder) {
      * Public constructor.
      */
     public NonJoiningClusterJoiner() {
+        LOGGER.info()
+                .setMessage("NonJoiningClusterJoiner starting up")
+                .log();
     }
 
     @Override
     public void onReceive(final Object message) throws Exception {
         unhandled(message);
     }
 
+    private static Logger LOGGER = LoggerFactory.getLogger(NonJoiningClusterJoiner.class);
 
     public static class Builder extends ActorBuilder<Builder> {
         public Builder() {

src/main/java/com/arpnetworking/clusteraggregator/configuration/ClusterAggregatorConfiguration.java

@@ -15,6 +15,8 @@
  */
 package com.arpnetworking.clusteraggregator.configuration;
 
+import akka.actor.Props;
+import com.arpnetworking.akka.NonJoiningClusterJoiner;
 import com.arpnetworking.commons.builder.OvalBuilder;
 import com.arpnetworking.commons.jackson.databind.ObjectMapperFactory;
 import com.arpnetworking.utility.InterfaceDatabase;
@@ -43,7 +45,7 @@ public final class ClusterAggregatorConfiguration {
      * @return An <code>ObjectMapper</code> for TsdAggregator configuration.
      */
     public static ObjectMapper createObjectMapper() {
-        return ObjectMapperFactory.getInstance();
+        return ObjectMapperFactory.createInstance();
     }
 
     public String getMonitoringCluster() {
@@ -138,6 +140,7 @@ public String toString() {
                 .add("RebalanceConfiguration", _rebalanceConfiguration)
                 .add("ClusterHostSuffix", _clusterHostSuffix)
                 .add("DatabaseConfigurations", _databaseConfigurations)
+                .add("ClusterJoinActor", _clusterJoinActor)
                 .toString();
     }
 
@@ -159,6 +162,7 @@ private ClusterAggregatorConfiguration(final Builder builder) {
         _rebalanceConfiguration = builder._rebalanceConfiguration;
         _clusterHostSuffix = builder._clusterHostSuffix;
         _databaseConfigurations = Maps.newHashMap(builder._databaseConfigurations);
+        _clusterJoinActor = builder._clusterJoinActor;
     }
 
     private final String _monitoringCluster;
@@ -177,6 +181,7 @@ private ClusterAggregatorConfiguration(final Builder builder) {
     private final Period _jvmMetricsCollectionInterval;
     private final RebalanceConfiguration _rebalanceConfiguration;
     private final String _clusterHostSuffix;
+    private final Props _clusterJoinActor;
     private final Map<String, DatabaseConfiguration> _databaseConfigurations;
 
     private static final InterfaceDatabase INTERFACE_DATABASE = ReflectionsDatabase.newInstance();
@@ -390,6 +395,17 @@ public Builder setDatabaseConfigurations(final Map<String, DatabaseConfiguration
             return this;
         }
 
+        /**
+         * Configuration a cluster join actor.
+         *
+         * @param value The cluster join actor configuration.
+         * @return This instance of <code>Builder</code>.
+         */
+        public Builder setClusterJoinActor(final Props value) {
+            _clusterJoinActor = value;
+            return this;
+        }
+
         @NotNull
         @NotEmpty
         private String _monitoringCluster;
@@ -429,6 +445,8 @@ public Builder setDatabaseConfigurations(final Map<String, DatabaseConfiguration
         private RebalanceConfiguration _rebalanceConfiguration;
         @NotNull
         private String _clusterHostSuffix = "";
+        @NotNull
+        private Props _clusterJoinActor = new NonJoiningClusterJoiner.Builder().build();
         private Map<String, DatabaseConfiguration> _databaseConfigurations;
     }
 }

src/main/java/com/arpnetworking/configuration/jackson/akka/ActorBuilderDeserializer.java

@@ -37,9 +37,7 @@ public Props deserialize(final JsonParser p, final DeserializationContext ctxt)
             final Builder<? extends Props> value = _mapper.readValue(treeNode.toString(), builder);
             return value.build();
         } catch (ClassNotFoundException e) {
-            throw new JsonMappingException(p, String.format("Unable to find class %s referenced by ActorRef type", type));
-        } finally {
-            p.close();
+            throw new JsonMappingException(p, String.format("Unable to find class %s referenced by Props type", type));
         }
     }