Skip to content

Commit cc989a8

Browse files
committed
Fix Netty 4.2.7 compatibility by using string literals for HTTP headers
Replace Netty HttpHeaderNames and HttpHeaderValues constants with plain string literals to avoid compatibility issues with Netty 4.2.7.Final. Changes: - Replace HttpHeaderNames.CONTENT_TYPE with "Content-Type" - Replace HttpHeaderNames.CONTENT_ENCODING with "Content-Encoding" - Replace HttpHeaderValues.GZIP with "gzip" - Remove unused Netty header imports This avoids any potential incompatibilities between AsyncHttpClient 3.0.3 and Netty 4.2.7's header constant implementations.
1 parent d68dc4e commit cc989a8

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
import com.fasterxml.jackson.annotation.JacksonInject;
2626
import com.google.common.collect.ImmutableSet;
2727
import com.google.common.collect.Lists;
28-
import io.netty.handler.codec.http.HttpHeaderNames;
29-
import io.netty.handler.codec.http.HttpHeaderValues;
3028
import net.sf.oval.Validator;
3129
import net.sf.oval.constraint.CheckWith;
3230
import net.sf.oval.constraint.CheckWithCheck;
@@ -127,12 +125,12 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
127125

128126
final RequestBuilder requestBuilder = new RequestBuilder()
129127
.setUri(getAysncHttpClientUri())
130-
.setHeader(HttpHeaderNames.CONTENT_TYPE, MediaTypes.APPLICATION_JSON.toString())
128+
.setHeader("Content-Type", MediaTypes.APPLICATION_JSON.toString())
131129
.setBody(bodyData)
132130
.setMethod(HttpConstants.Methods.POST);
133131

134132
if (_enableCompression) {
135-
requestBuilder.setHeader(HttpHeaderNames.CONTENT_ENCODING, HttpHeaderValues.GZIP);
133+
requestBuilder.setHeader("Content-Encoding", "gzip");
136134
}
137135

138136
return new RequestInfo(requestBuilder.build(), serializedData.length, bodyData.length);

src/main/java/com/arpnetworking/tsdcore/sinks/KairosDbSink.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import com.fasterxml.jackson.databind.ObjectMapper;
3636
import com.google.common.collect.ImmutableMap;
3737
import com.google.common.collect.Lists;
38-
import io.netty.handler.codec.http.HttpHeaderNames;
3938
import it.unimi.dsi.fastutil.doubles.Double2LongMap;
4039
import net.sf.oval.constraint.Min;
4140
import net.sf.oval.constraint.NotNull;
@@ -177,7 +176,7 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s
177176

178177
final RequestBuilder requestBuilder = new RequestBuilder()
179178
.setUri(getAysncHttpClientUri())
180-
.setHeader(HttpHeaderNames.CONTENT_TYPE, "application/gzip")
179+
.setHeader("Content-Type", "application/gzip")
181180
.setBody(bodyData)
182181
.setMethod(HttpConstants.Methods.POST);
183182

0 commit comments

Comments
 (0)