Incorrect sharding when `cluster` etc. is set in dimensions

[matthayter]

The Messages.StatisticSetRecord no longer requires the cluster, service and host to be present in their respective fields, instead allowing them to be conveyed via a dimension key-value. The AggClientConnection class defers to the dimensions for retrieval of the cluster, service and host; however, the AggMessageExtractor does not, and still looks in the now-optional fields of the StatisticSetRecord message.

This would appear to be a bug, causing incorrect sharding when the messages sent from MAD have opted to use dimensions to convey cluster, service and host.

Can someone sanity check me on this?

[BrandonArp]

You are correct, but right now these will always be set. See here: https://github.com/ArpNetworking/metrics-aggregator-daemon/blob/c849892c87107aa94425606de0021b79b472798f/src/main/java/com/arpnetworking/tsdcore/sinks/AggregationServerSink.java#L85-L86

I'm going to leave this open because the issue should be addressed.