Bump com.arpnetworking.build:arpnetworking-parent-pom from 3.3.4 to 3.3.8 (#783)

dependabot[bot] · BrandonArp · web-flow · commit 52b0db45e0c1 · 2025-05-23T12:13:19.000-07:00
* Bump com.arpnetworking.build:arpnetworking-parent-pom Bumps [com.arpnetworking.build:arpnetworking-parent-pom](https://github.com/arpnetworking/arpnetworking-parent-pom) from 3.3.4 to 3.3.6. - [Release notes](https://github.com/arpnetworking/arpnetworking-parent-pom/releases) - [Commits](ArpNetworking/arpnetworking-parent-pom@arpnetworking-parent-pom-3.3.4...arpnetworking-parent-pom-3.3.8) --- updated-dependencies: - dependency-name: com.arpnetworking.build:arpnetworking-parent-pom dependency-version: 3.3.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * update parent pom version * add some javadoc * Update pom.xml * clean up some findbugs warnings * clean up unused imports --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brandon Arp <brandonarp@gmail.com>
diff --git a/app/com/arpnetworking/kairos/client/models/MetricsQuery.java b/app/com/arpnetworking/kairos/client/models/MetricsQuery.java
@@ -340,7 +340,6 @@ protected void reset() {
             _otherArgs = Maps.newHashMap();
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")
         private boolean validateStart(@Nullable final Instant ignored) {
             if (_startTime == null) {
                 return _startRelative != null;
@@ -349,7 +348,6 @@ private boolean validateStart(@Nullable final Instant ignored) {
             }
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")
         private boolean validateEnd(@Nullable final Instant ignored) {
             if (_endTime != null) {
                 return _endRelative == null;
diff --git a/app/com/arpnetworking/kairos/client/models/TagsQuery.java b/app/com/arpnetworking/kairos/client/models/TagsQuery.java
@@ -335,7 +335,6 @@ protected void reset() {
             _otherArgs = Maps.newHashMap();
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")
         private boolean validateStart(@Nullable final Instant ignored) {
             if (_startTime == null) {
                 return _startRelative != null;
@@ -344,7 +343,6 @@ private boolean validateStart(@Nullable final Instant ignored) {
             }
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")
         private boolean validateEnd(@Nullable final Instant ignored) {
             if (_endTime != null) {
                 return _endRelative == null;
diff --git a/app/com/arpnetworking/metrics/portal/health/StatusActor.java b/app/com/arpnetworking/metrics/portal/health/StatusActor.java
@@ -16,7 +16,6 @@
 
 package com.arpnetworking.metrics.portal.health;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import models.view.StatusResponse;
 import org.apache.pekko.actor.AbstractActor;
 import org.apache.pekko.actor.ActorRef;
@@ -47,7 +46,6 @@ public class StatusActor extends AbstractActor {
      * @param cluster The instance of the Clustering extension.
      * @param clusterStatusCache The actor holding the cached cluster status.
      */
-    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR", justification = "getSelf() and getContext() are safe to call")
     public StatusActor(
             final Cluster cluster,
             final ActorRef clusterStatusCache) {
diff --git a/app/com/arpnetworking/metrics/portal/hosts/impl/LocalHostRepository.java b/app/com/arpnetworking/metrics/portal/hosts/impl/LocalHostRepository.java
@@ -22,7 +22,6 @@
 import com.arpnetworking.steno.LoggerFactory;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.inject.Inject;
 import models.internal.Host;
 import models.internal.HostQuery;
@@ -216,7 +215,6 @@ private Map<String, Host> getOrganizationMap(final Organization organization) {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(LocalHostRepository.class);
 
-    @SuppressFBWarnings("SE_BAD_FIELD")
     private static class HostComparator implements Comparator<Host>, Serializable {
 
         HostComparator(final HostQuery query) {
diff --git a/app/com/arpnetworking/metrics/portal/hosts/impl/MultiProvider.java b/app/com/arpnetworking/metrics/portal/hosts/impl/MultiProvider.java
@@ -21,7 +21,6 @@
 import com.google.inject.assistedinject.Assisted;
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigValueType;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.inject.Inject;
 import org.apache.pekko.actor.AbstractActor;
 import org.apache.pekko.actor.Props;
@@ -51,7 +50,6 @@ public class MultiProvider extends AbstractActor {
      * @param configuration Play configuration.
      */
     @Inject
-    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR", justification = "getContext() and getSelf() are safe to call")
     public MultiProvider(final HostProviderFactory factory, final Environment environment, @Assisted final Config configuration) {
         _factory = factory;
         _environment = environment;
diff --git a/app/com/arpnetworking/metrics/portal/hosts/impl/NoHostProvider.java b/app/com/arpnetworking/metrics/portal/hosts/impl/NoHostProvider.java
@@ -20,7 +20,6 @@
 import com.arpnetworking.steno.LoggerFactory;
 import com.google.inject.assistedinject.Assisted;
 import com.typesafe.config.Config;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.inject.Inject;
 import org.apache.pekko.actor.AbstractActor;
 
@@ -40,7 +39,6 @@ public class NoHostProvider extends AbstractActor {
      *
      * @param configuration Play configuration.
      */
-    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR", justification = "getSelf() and getContext() are safe to call")
     @Inject
     public NoHostProvider(@Assisted final Config configuration) {
         _configuration = configuration;
diff --git a/app/com/arpnetworking/metrics/portal/reports/impl/chrome/DevToolsNetworkConfigurationProtocol.java b/app/com/arpnetworking/metrics/portal/reports/impl/chrome/DevToolsNetworkConfigurationProtocol.java
@@ -26,17 +26,23 @@
 import com.github.kklisura.cdt.services.ChromeDevToolsService;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.Collection;
 import java.util.Map;
 import java.util.function.BiConsumer;
 
-@SuppressFBWarnings("SE_BAD_FIELD") // False positive: https://github.com/spotbugs/spotbugs/issues/740
 /* package private */ enum DevToolsNetworkConfigurationProtocol {
 
+    /**
+     * Network configuration.
+     *
+     * @deprecated Use FETCH instead.
+     */
     @Deprecated
     NETWORK(DevToolsNetworkConfigurationProtocol::configureWithNetwork),
+    /**
+     * Fetch configuration.
+     */
     FETCH(DevToolsNetworkConfigurationProtocol::configureWithFetch);
 
     DevToolsNetworkConfigurationProtocol(final BiConsumer<ChromeDevToolsService, PerOriginConfigs> configure) {
diff --git a/app/com/arpnetworking/metrics/portal/scheduling/JobExecutorActor.java b/app/com/arpnetworking/metrics/portal/scheduling/JobExecutorActor.java
@@ -24,7 +24,6 @@
 import com.google.common.base.CaseFormat;
 import com.google.common.base.MoreObjects;
 import com.google.inject.Injector;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import models.internal.scheduling.Job;
 import models.internal.scheduling.JobExecution;
 import net.sf.oval.constraint.NotNull;
@@ -822,7 +821,6 @@ public Builder<T> setResult(@Nullable final T result) {
                 return this;
             }
 
-            @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
             private boolean validateErrorAndResult(@Nullable final Object result) {
                 return result == null ^ _error == null;
             }
diff --git a/app/com/arpnetworking/metrics/portal/scheduling/impl/BoundedSchedule.java b/app/com/arpnetworking/metrics/portal/scheduling/impl/BoundedSchedule.java
@@ -17,7 +17,6 @@
 
 import com.arpnetworking.commons.builder.OvalBuilder;
 import com.arpnetworking.metrics.portal.scheduling.Schedule;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.sf.oval.constraint.NotNull;
 import net.sf.oval.constraint.ValidateWithMethod;
 
@@ -151,7 +150,6 @@ public B setRunUntil(@Nullable final Instant runUntil) {
             return self();
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
         private boolean validateRunAtAndAfter(final Instant runAtAndAfter) {
             return !runAtAndAfter.equals(Instant.MIN) && (_runUntil == null || !runAtAndAfter.isAfter(_runUntil));
         }
diff --git a/app/com/arpnetworking/metrics/portal/scheduling/impl/PeriodicSchedule.java b/app/com/arpnetworking/metrics/portal/scheduling/impl/PeriodicSchedule.java
@@ -19,7 +19,6 @@
 import com.arpnetworking.steno.Logger;
 import com.arpnetworking.steno.LoggerFactory;
 import com.google.common.base.MoreObjects;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import net.sf.oval.constraint.NotNull;
 import net.sf.oval.constraint.ValidateWithMethod;
 
@@ -226,7 +225,6 @@ public Builder setOffset(final Duration offset) {
             return this;
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
         private boolean validateOffset(final Duration offset) {
             return !offset.isNegative()
                    && offset.minus(_period.getDuration()).isNegative();
diff --git a/app/com/arpnetworking/notcommons/pekko/JacksonSerializer.java b/app/com/arpnetworking/notcommons/pekko/JacksonSerializer.java
@@ -69,7 +69,6 @@ public static void setObjectMapper(final ObjectMapper objectMapper) {
 
 
     @Override
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH", justification = "Preconditions.checkNotNull will throw")
     public Object fromBinaryJava(final byte[] bytes, final Class<?> manifest) {
         Preconditions.checkNotNull(manifest, "Jackson deserialization requires a manifest.");
         Preconditions.checkNotNull(gObjectMapper, "The mapper was not configured at startup.");
@@ -88,7 +87,6 @@ public int identifier() {
     }
 
     @Override
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH", justification = "Preconditions.checkNotNull will throw")
     public byte[] toBinary(final Object o) {
         Preconditions.checkNotNull(gObjectMapper, "The mapper was not configured at startup.");
         try {
diff --git a/app/com/arpnetworking/play/metrics/MetricsActionWrapper.java b/app/com/arpnetworking/play/metrics/MetricsActionWrapper.java
@@ -22,7 +22,6 @@
 import com.arpnetworking.steno.Logger;
 import com.arpnetworking.steno.LoggerFactory;
 import com.google.common.base.Strings;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import play.libs.typedmap.TypedEntry;
 import play.libs.typedmap.TypedKey;
 import play.libs.typedmap.TypedMap;
@@ -53,7 +52,6 @@ public MetricsActionWrapper(final MetricsFactory metricsFactory) {
     }
 
     @Override
-    @SuppressFBWarnings("DE_MIGHT_IGNORE")
     public CompletionStage<Result> call(final Http.Request request) {
         final Http.Request requestWithMetrics  = initMetrics(request);
         final Metrics metrics = requestWithMetrics.attrs().get(Attrs.METRICS);
diff --git a/app/com/arpnetworking/rollups/ConsistencyChecker.java b/app/com/arpnetworking/rollups/ConsistencyChecker.java
@@ -550,7 +550,6 @@ public Builder setTrigger(final Trigger value) {
                 return this;
             }
 
-            @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
             private boolean validateStartTime(final Instant startTime) {
                 return startTime.equals(_period.recentEndTime(startTime));
             }
diff --git a/app/global/Global.java b/app/global/Global.java
@@ -18,7 +18,6 @@
 
 import com.arpnetworking.steno.Logger;
 import com.arpnetworking.steno.LoggerFactory;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.inject.Inject;
 import org.apache.pekko.actor.ActorSystem;
 import play.inject.ApplicationLifecycle;
@@ -47,7 +46,6 @@ public Global(final ActorSystem pekko, final ApplicationLifecycle lifecycle) {
         LOGGER.debug().setMessage("Startup complete").log();
     }
 
-    @SuppressFBWarnings(value = "NP_NONNULL_PARAM_VIOLATION", justification = "CompletableFuture can take a null arg")
     private CompletionStage<Void> onStop() {
         final CompletableFuture<Void> shutdownFuture = new CompletableFuture<>();
         LOGGER.info().setMessage("Shutting down application...").log();
diff --git a/app/models/internal/impl/DefaultReport.java b/app/models/internal/impl/DefaultReport.java
@@ -24,7 +24,6 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSetMultimap;
 import com.google.inject.Injector;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import models.internal.reports.Recipient;
 import models.internal.reports.Report;
 import models.internal.reports.ReportFormat;
@@ -95,10 +94,6 @@ public ImmutableMap<ReportFormat, Collection<Recipient>> getRecipientsByFormat()
     }
 
     @Override
-    @SuppressFBWarnings(
-            value = "NP_NONNULL_PARAM_VIOLATION",
-            justification = "Known problem with FindBugs. See https://github.com/findbugsproject/findbugs/issues/79."
-    )
     public CompletionStage<Result> execute(final Injector injector, final Instant scheduled) {
         return injector.getInstance(ReportExecutionContext.class).execute(this, scheduled);
     }
@@ -253,7 +248,6 @@ public Builder setRecipients(final ImmutableSetMultimap<ReportFormat, Recipient>
         @NotNull
         private Duration _timeout;
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
         private boolean validateRecipientsPresent(final ImmutableSetMultimap<ReportFormat, Recipient> result) {
             return !_recipients.isEmpty();
         }
diff --git a/pom.xml b/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <groupId>com.arpnetworking.build</groupId>
     <artifactId>arpnetworking-parent-pom</artifactId>
-    <version>3.3.4</version>
+    <version>3.3.8</version>
     <relativePath />
   </parent>
 
diff --git a/spotbugs.exclude.xml b/spotbugs.exclude.xml
@@ -29,6 +29,34 @@
         <Bug pattern="DLS_DEAD_LOCAL_STORE" />
     </Match>
 
+
+     <!-- Match THROWS_METHOD_THROWS_RUNTIMEEXCEPTION violations. We commonly
+	     use runtime exceptions with lambdas, streams, and promises to indicate
+	     failure
+     -->
+     <Match>
+         <Bug pattern="THROWS_METHOD_THROWS_RUNTIMEEXCEPTION" />
+     </Match>
+
+    <!-- We often throw Exception in tests to indicate an error. The exception itself is the point, not how to handle it
+    -->
+    <Match>
+        <Or>
+            <Bug pattern="THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION" />
+            <Bug pattern="DE_MIGHT_IGNORE" />
+        </Or>
+        <Or>
+            <Class name="~.*\.[^\.]+Test" />
+            <Class name="~.*\.[^\.]+Test\$.*" />
+            <Class name="~.*\.[^\.]+TestPerf" />
+            <Class name="~.*\.[^\.]+TestPerf\$.*" />
+            <Class name="~.*\.[^\.]+IT" />
+            <Class name="~.*\.[^\.]+IT\$.*" />
+            <Class name="~.*\.[^\.]+ITPerf" />
+            <Class name="~.*\.[^\.]+ITPerf\$.*" />
+        </Or>
+    </Match>
+
     <!-- Match all EI_EXPOSE_REP violations. These are about internal state being able
         to be modified by passing in mutable objects. Problem is that SpotBugs doesn't know
         which objects are actually mutable so false positives abound.
diff --git a/test/java/com/arpnetworking/metrics/portal/alerts/impl/DailyPartitionCreatorTest.java b/test/java/com/arpnetworking/metrics/portal/alerts/impl/DailyPartitionCreatorTest.java
@@ -19,7 +19,6 @@
 import com.arpnetworking.commons.java.time.ManualClock;
 import com.arpnetworking.metrics.incubator.PeriodicMetrics;
 import com.google.common.base.MoreObjects;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.ebean.Database;
 import jakarta.persistence.PersistenceException;
 import org.apache.pekko.actor.ActorRef;
@@ -85,7 +84,6 @@ private ActorRef createActor() {
         return createActor(() -> { });
     }
 
-    @SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC_ANON")
     private ActorRef createActor(final Runnable onExecute) {
         // Create an actor with the db execution behavior mocked out.
         final Props props = Props.create(
diff --git a/test/java/com/arpnetworking/metrics/portal/integration/repositories/JobExecutionRepositoryIT.java b/test/java/com/arpnetworking/metrics/portal/integration/repositories/JobExecutionRepositoryIT.java
@@ -21,7 +21,6 @@
 import com.arpnetworking.metrics.portal.scheduling.JobExecutionRepository;
 import com.google.common.base.Throwables;
 import com.google.common.collect.ImmutableList;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import models.internal.Organization;
 import models.internal.scheduling.JobExecution;
 import org.junit.After;
@@ -102,10 +101,6 @@ public void tearDown() {
     }
 
     @Test
-    @SuppressFBWarnings(
-            value = "SIC_INNER_SHOULD_BE_STATIC_ANON",
-            justification = "The 'this' reference is the test class and I'm not concerned about it potentially living too long."
-    )
     public void testJobStarted() throws Exception {
         final Instant scheduled = Instant.now().truncatedTo(ChronoUnit.MICROS);
 
diff --git a/test/java/com/arpnetworking/metrics/portal/reports/ReportExecutionContextTest.java b/test/java/com/arpnetworking/metrics/portal/reports/ReportExecutionContextTest.java
@@ -163,7 +163,6 @@ public void testInstantiatesWithConfig() {
     }
 
     @Test
-    @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED")
     public void testExecute() throws Exception {
         final ReportExecutionContext context = new ReportExecutionContext(CLOCK, _injector, _environment, _config);
         context.execute(EXAMPLE_REPORT, T1).toCompletableFuture().get();
@@ -302,7 +301,6 @@ public ImmutableList<Problem> validateSend(final Recipient recipient, final Immu
         }
 
         @Override
-        @SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
         public CompletionStage<Void> send(
                 final Recipient recipient,
                 final ImmutableMap<ReportFormat, RenderedReport> formatsToSend
diff --git a/test/java/com/arpnetworking/metrics/portal/scheduling/JobExecutorActorTest.java b/test/java/com/arpnetworking/metrics/portal/scheduling/JobExecutorActorTest.java
@@ -30,7 +30,6 @@
 import com.google.inject.Guice;
 import com.google.inject.Injector;
 import com.typesafe.config.ConfigFactory;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import models.internal.Organization;
 import models.internal.scheduling.Job;
 import org.apache.pekko.actor.ActorRef;
@@ -242,7 +241,6 @@ public void testActorRequestsStopWhenJobNoLongerExists() {
     }
 
     @Test
-    @SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
     public void testOnlyExecutesOneAtATime() {
         final ChronoUnit period = ChronoUnit.MINUTES;
         final Instant startAt = T_0.minus(period.getDuration());
diff --git a/test/java/com/arpnetworking/metrics/portal/scheduling/mocks/DummyJob.java b/test/java/com/arpnetworking/metrics/portal/scheduling/mocks/DummyJob.java
@@ -202,7 +202,6 @@ public Builder<T> setBlocker(final CompletionStage<?> blocker) {
             return this;
         }
 
-        @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")
         private boolean validateResultXorError(final Object result) {
             return _result.isPresent() ^ _error.isPresent();
         }
diff --git a/test/java/com/arpnetworking/utility/ConfigTypedProviderTest.java b/test/java/com/arpnetworking/utility/ConfigTypedProviderTest.java
@@ -21,7 +21,6 @@
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
 import com.typesafe.config.ConfigValueFactory;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.inject.Inject;
 import org.junit.Test;
 import play.Environment;
@@ -38,7 +37,6 @@
 public final class ConfigTypedProviderTest {
 
     @Test
-    @SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC_ANON")
     public void createBasic() {
         final Config config = ConfigFactory.empty()
                 .withValue("testinterface.impl.class", ConfigValueFactory.fromAnyRef(TestClass.class.getName()));
@@ -59,7 +57,6 @@ protected void configure() {
     }
 
     @Test
-    @SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC_ANON")
     public void createWithInjected() {
         final Config config = ConfigFactory.empty()
                 .withValue("testinterface.impl.class", ConfigValueFactory.fromAnyRef(TestClassInjected.class.getName()));

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,6 @@ protected void reset() {`
`340`	`340`	`_otherArgs = Maps.newHashMap();`
`341`	`341`	`}`
`342`	`342`
`343`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")`
`344`	`343`	`private boolean validateStart(@Nullable final Instant ignored) {`
`345`	`344`	`if (_startTime == null) {`
`346`	`345`	`return _startRelative != null;`
`@@ -349,7 +348,6 @@ private boolean validateStart(@Nullable final Instant ignored) {`
`349`	`348`	`}`
`350`	`349`	`}`
`351`	`350`
`352`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")`
`353`	`351`	`private boolean validateEnd(@Nullable final Instant ignored) {`
`354`	`352`	`if (_endTime != null) {`
`355`	`353`	`return _endRelative == null;`
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,6 @@ protected void reset() {`
`335`	`335`	`_otherArgs = Maps.newHashMap();`
`336`	`336`	`}`
`337`	`337`
`338`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")`
`339`	`338`	`private boolean validateStart(@Nullable final Instant ignored) {`
`340`	`339`	`if (_startTime == null) {`
`341`	`340`	`return _startRelative != null;`
`@@ -344,7 +343,6 @@ private boolean validateStart(@Nullable final Instant ignored) {`
`344`	`343`	`}`
`345`	`344`	`}`
`346`	`345`
`347`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "Method is called by Oval")`
`348`	`346`	`private boolean validateEnd(@Nullable final Instant ignored) {`
`349`	`347`	`if (_endTime != null) {`
`350`	`348`	`return _endRelative == null;`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`import com.google.common.base.CaseFormat;`
`25`	`25`	`import com.google.common.base.MoreObjects;`
`26`	`26`	`import com.google.inject.Injector;`
`27`		`-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;`
`28`	`27`	`import models.internal.scheduling.Job;`
`29`	`28`	`import models.internal.scheduling.JobExecution;`
`30`	`29`	`import net.sf.oval.constraint.NotNull;`
`@@ -822,7 +821,6 @@ public Builder<T> setResult(@Nullable final T result) {`
`822`	`821`	`return this;`
`823`	`822`	`}`
`824`	`823`
`825`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")`
`826`	`824`	`private boolean validateErrorAndResult(@Nullable final Object result) {`
`827`	`825`	`return result == null ^ _error == null;`
`828`	`826`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`
`18`	`18`	`import com.arpnetworking.commons.builder.OvalBuilder;`
`19`	`19`	`import com.arpnetworking.metrics.portal.scheduling.Schedule;`
`20`		`-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;`
`21`	`20`	`import net.sf.oval.constraint.NotNull;`
`22`	`21`	`import net.sf.oval.constraint.ValidateWithMethod;`
`23`	`22`
`@@ -151,7 +150,6 @@ public B setRunUntil(@Nullable final Instant runUntil) {`
`151`	`150`	`return self();`
`152`	`151`	`}`
`153`	`152`
`154`		`- @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD", justification = "invoked reflectively by @ValidateWithMethod")`
`155`	`153`	`private boolean validateRunAtAndAfter(final Instant runAtAndAfter) {`
`156`	`154`	`return !runAtAndAfter.equals(Instant.MIN) && (_runUntil == null \|\| !runAtAndAfter.isAfter(_runUntil));`
`157`	`155`	`}`