Bugfix/e2e tests (#84)

Author: m8rvin

.github/workflows/release-deploy.yml

@@ -142,10 +142,30 @@ jobs:
           registry: ghcr.io
           workdir: gamey
 
+  docker-push-gameyapi:
+    name: Publish gameyapi image
+    runs-on: ubuntu-latest
+    needs: e2e
+    permissions:
+      contents: read
+      packages: write
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Publish to Registry (gameyapi)
+        uses: elgohr/Publish-Docker-Github-Action@v5
+        with:
+          name: ${{ github.repository_owner }}/${{ github.event.repository.name }}-gameyapi
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+          registry: ghcr.io
+          workdir: gameyapi
+
   deploy:
     name: Deploy over SSH
     runs-on: ubuntu-latest
-    needs: [docker-push-users, docker-push-webapp, docker-push-gamey]
+    needs: [docker-push-users, docker-push-webapp, docker-push-gamey, docker-push-gameyapi]
     steps:
       - name: Deploy over SSH
         uses: fifsky/ssh-action@master

docker-compose.yml

@@ -42,6 +42,7 @@ services:
   gamey-service:
     build: ./gameyapi
     container_name: gamey-service
+    image: ghcr.io/arquisoft/yovi_en1a-gameyapi:latest
     ports:
       - "3001:3001"
     environment:

webapp/test/e2e/features/register.feature

@@ -3,5 +3,5 @@ Feature: Register
 
   Scenario: Successful registration
     Given the register page is open
-    When I enter "Alice" as the username and submit
-    Then I should see a welcome message containing "Hello Alice"
+    When I enter "Alice" as the username and "password123" as the password and submit
+    Then I should be redirected to the lobby

webapp/test/e2e/steps/register.steps.mjs

@@ -4,20 +4,38 @@ import assert from 'assert'
 Given('the register page is open', async function () {
   const page = this.page
   if (!page) throw new Error('Page not initialized')
+
+  // Mock the login API so the test doesn't need MongoDB
+  await page.route('**/login', async (route) => {
+    await route.fulfill({
+      status: 200,
+      contentType: 'application/json',
+      body: JSON.stringify({
+        message: 'Login successful for Alice',
+        token: 'mock-jwt-token',
+        username: 'Alice'
+      })
+    })
+  })
+
   await page.goto('http://localhost:5173')
 })
 
-When('I enter {string} as the username and submit', async function (username) {
+When('I enter {string} as the username and {string} as the password and submit', async function (username, password) {
   const page = this.page
   if (!page) throw new Error('Page not initialized')
   await page.fill('#username', username)
+  await page.fill('#password', password)
   await page.click('.submit-button')
 })
 
-Then('I should see a welcome message containing {string}', async function (expected) {
+Then('I should be redirected to the lobby', async function () {
   const page = this.page
   if (!page) throw new Error('Page not initialized')
-  await page.waitForSelector('.success-message', { timeout: 5000 })
-  const text = await page.textContent('.success-message')
-  assert.ok(text && text.includes(expected), `Expected success message to include "${expected}", got: "${text}"`)
+
+  // After successful login, the app sets localStorage and navigates to ?view=lobby.
+  // Wait for the lobby content to appear (profile-username is only rendered on the lobby page).
+  await page.waitForSelector('.profile-username', { timeout: 10000 })
+  const text = await page.textContent('.profile-username')
+  assert.ok(text && text.includes('Alice'), `Expected lobby to show "Alice", got: "${text}"`)
 })