Enhance code coverage

Author: Art4

tests/unit/AttributesTest.php

@@ -3,9 +3,12 @@
 namespace Art4\JsonApiClient\Tests;
 
 use Art4\JsonApiClient\Attributes;
+use Art4\JsonApiClient\Tests\Fixtures\JsonValueTrait;
 
 class AttributesTest extends \PHPUnit_Framework_TestCase
 {
+	use JsonValueTrait;
+
 	/**
 	 * @test create with object
 	 */
@@ -44,13 +47,20 @@ public function testCreateWithObject()
 	}
 
 	/**
-	 * @test create with empty object
+	 * @dataProvider jsonValuesProvider
 	 */
-	public function testCreateWithEmptyObject()
+	public function testCreateWithDataProvider($input)
 	{
-		$object = new \stdClass();
+		// Input must be an object
+		if ( gettype($input) === 'object' )
+		{
+			$this->assertInstanceOf('Art4\JsonApiClient\Attributes', new Attributes($input));
+
+			return;
+		}
 
-		$this->assertInstanceOf('Art4\JsonApiClient\Attributes', new Attributes($object));
+		$this->setExpectedException('Art4\JsonApiClient\Exception\ValidationException');
+		$error = new Attributes($input);
 	}
 
 	/**

tests/unit/ErrorLinkTest.php

@@ -34,6 +34,23 @@ public function testOnlyAboutPropertyExists()
 		$this->assertSame($link->get('about'), 'http://example.org/about');
 	}
 
+	/**
+	 * @test 'about' property must be set
+	 *
+	 * An error object MAY have the following members:
+	 * - links: a links object containing the following members:
+	 *   - about: a link that leads to further details about this particular occurrence of the problem.
+	 */
+	public function testAboutMustBeSet()
+	{
+		$object = new \stdClass();
+		$object->foobar = new \stdClass();
+
+		$this->setExpectedException('Art4\JsonApiClient\Exception\ValidationException');
+
+		$link = new ErrorLink($object);
+	}
+
 	/**
 	 * @test 'about' property can be a link object
 	 *

tests/unit/Resource/IdentifierTest.php

@@ -135,4 +135,21 @@ public function testCreateWithObjectWithoutIdThrowsException()
 
 		$identifier = new Identifier($object);
 	}
+
+	/**
+	 * @test get() on an undefined value throws Exception
+	 */
+	public function testGetWithUndefinedValueThrowsException()
+	{
+		$object = new \stdClass();
+		$object->type = 'posts';
+		$object->id = 9;
+
+		$identifier = new Identifier($object);
+		$this->assertFalse($identifier->has('foobar'));
+
+		$this->setExpectedException('Art4\JsonApiClient\Exception\AccessException');
+
+		$identifier->get('foobar');
+	}
 }