Merge pull request #17 from Arthur2500/copilot/sub-pr-16

Remove unused imports and variables flagged in code review

Author: Arthur2500

backend/app/routes/auth.py

@@ -1,7 +1,7 @@
 """Authentication routes for user login and password management."""
 import logging
 from flask import Blueprint, request, jsonify
-from flask_jwt_extended import create_access_token, jwt_required, get_jwt_identity
+from flask_jwt_extended import create_access_token, jwt_required
 from flask_limiter import Limiter
 from flask_limiter.util import get_remote_address
 from app.models.user import User

backend/app/routes/groups.py

@@ -4,12 +4,10 @@
 from app.models.user import User
 from app.models.group import Group
 from app.utils.wireguard import generate_keypair
-from app.utils.decorators import admin_required
 from app import db
 import ipaddress
 import zipfile
 import io
-import os
 
 logger = logging.getLogger(__name__)
 

backend/app/routes/health.py

@@ -2,7 +2,6 @@
 import logging
 from flask import Blueprint, jsonify
 from app import db
-from app.models.group import Group
 
 logger = logging.getLogger(__name__)
 

backend/app/utils/helpers.py

@@ -2,7 +2,6 @@
 import logging
 import re
 from datetime import datetime
-from functools import wraps
 from flask import jsonify
 from flask_jwt_extended import get_jwt_identity
 from app.models.user import User

backend/tests/conftest.py

@@ -8,7 +8,6 @@
 
 from app import create_app, db
 from app.routes.auth import limiter
-from app.models.user import User
 
 
 @pytest.fixture

frontend/src/App.tsx

@@ -69,13 +69,13 @@ function App() {
                   <Route path="/dashboard" element={<Dashboard user={user} />} />
 
                   {/* Groups */}
-                  <Route path="/groups" element={<GroupList />} />
+                  <Route path="/groups" element={<GroupList user={user} />} />
                   <Route path="/groups/new" element={<GroupForm />} />
                   <Route path="/groups/:id" element={<GroupDetail />} />
                   <Route path="/groups/:id/edit" element={<GroupForm />} />
 
                   {/* Clients */}
-                  <Route path="/clients" element={<ClientList />} />
+                  <Route path="/clients" element={<ClientList user={user} />} />
                   <Route path="/clients/:id" element={<ClientDetail />} />
                   <Route path="/groups/:groupId/clients/new" element={<ClientForm />} />
                   <Route path="/clients/:id/edit" element={<ClientForm />} />

frontend/src/components/clients/ClientList.tsx

@@ -2,12 +2,16 @@ import React, { useState, useEffect } from 'react';
 import { Link } from 'react-router-dom';
 import clientService from '../../services/client.service';
 import groupService from '../../services/group.service';
-import { Client, Group } from '../../types';
+import { Client, Group, User } from '../../types';
 import { formatBytes, downloadFile, formatDate } from '../../utils/helpers';
 import { Download, Lock, Unlock, Pencil, Trash2, Search } from 'lucide-react';
 import './ClientList.css';
 
-const ClientList: React.FC = () => {
+interface ClientListProps {
+  user: User | null;
+}
+
+const ClientList: React.FC<ClientListProps> = ({ user }) => {
   const [clients, setClients] = useState<Client[]>([]);
   const [groups, setGroups] = useState<Group[]>([]);
   const [loading, setLoading] = useState(true);
@@ -89,9 +93,11 @@ const ClientList: React.FC = () => {
       <div className="page-header">
         <h1>All Clients</h1>
         <div className="header-actions">
-          <button onClick={() => setShowCreateModal(true)} className="btn-primary">
-            + New Client
-          </button>
+          {user?.can_create_clients && (
+            <button onClick={() => setShowCreateModal(true)} className="btn-primary">
+              + New Client
+            </button>
+          )}
         </div>
       </div>
 

frontend/src/components/dashboard/Dashboard.tsx

@@ -3,7 +3,6 @@ import { Link } from 'react-router-dom';
 import statsService from '../../services/stats.service';
 import groupService from '../../services/group.service';
 import { StatsOverview, Group, User } from '../../types';
-import { formatBytes } from '../../utils/helpers';
 import { FolderOpen, Monitor, CheckCircle, Users, Plug } from 'lucide-react';
 import './Dashboard.css';
 

frontend/src/components/groups/GroupDetail.tsx

@@ -308,9 +308,7 @@ const GroupDetail: React.FC = () => {
       </div>
 
       {/* Group Traffic Statistics Section */}
-      {group && (
-        <GroupTrafficStats groupId={Number(id)} />
-      )}
+      <GroupTrafficStats groupId={Number(id)} />
 
       {/* Group Members Section */}
       {currentUser && group && (

frontend/src/components/groups/GroupForm.tsx

@@ -34,12 +34,10 @@ const GroupForm: React.FC = () => {
   });
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState('');
-  const [defaults, setDefaults] = useState<any>(null);
 
   const loadDefaults = useCallback(async () => {
     try {
       const settingsDefaults = await settingsService.getDefaults();
-      setDefaults(settingsDefaults);
 
       // Set initial form data with defaults from backend
       if (!isEdit) {