Remove file-wide unsafe buffer pragamas in partition alloc.

Automated using tools/clang/unsafe_pragam_rewriter scripts.

The previous bulk edit modified all files, even those that might have
been compliant, so many of these will be no-op changes.

Change-Id: Ie0614a41d0162adc9f5bea8b8d74d1726bc87055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819800
Commit-Queue: Tom Sepez <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1496646}
NOKEYCHECK=True
GitOrigin-RevId: 91729f29e9465cd45335c5cbb3970adeac7a0619

Author: tsepez

src/partition_alloc/dangling_raw_ptr_checks.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/dangling_raw_ptr_checks.h"
 
 #include "partition_alloc/partition_alloc_base/component_export.h"

src/partition_alloc/internal_allocator.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/internal_allocator.h"
 
 namespace partition_alloc::internal {

src/partition_alloc/oom_callback.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/oom_callback.h"
 
 #include "partition_alloc/partition_alloc_check.h"

src/partition_alloc/partition_alloc_base/compiler_specific.h

@@ -495,7 +495,7 @@ inline constexpr bool AnalyzerAssumeTrue(bool arg) {
 
 // Annotates code indicating that it should be permanently exempted from
 // `-Wunsafe-buffer-usage`. For temporary cases such as migrating callers to
-// safer patterns, use `UNSAFE_TODO()` instead;
+// safer patterns, use `PA_UNSAFE_TODO()` instead;
 #if defined(__clang__)
 // Disabling `clang-format` allows each `_Pragma` to be on its own line, as
 // recommended by https://gcc.gnu.org/onlinedocs/cpp/Pragmas.html.

src/partition_alloc/partition_alloc_base/containers/flat_map_pa_unittest.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include <string>
 #include <string_view>
 #include <type_traits>

src/partition_alloc/partition_alloc_base/containers/flat_tree_pa_unittest.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/partition_alloc_base/containers/flat_tree.h"
 #include "partition_alloc/partition_alloc_base/cxx20_identity.h"
 
@@ -70,7 +65,7 @@ class InputIterator {
   pointer operator->() const { return it_; }
 
   InputIterator& operator++() {
-    ++it_;
+    PA_UNSAFE_TODO(++it_);
     return *this;
   }
   InputIterator operator++(int) {

src/partition_alloc/partition_alloc_base/debug/alias.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/partition_alloc_base/debug/alias.h"
 
 #include "partition_alloc/partition_alloc_base/compiler_specific.h"

src/partition_alloc/partition_alloc_base/files/file_util_posix.cc

@@ -2,22 +2,18 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/partition_alloc_base/files/file_util.h"
 
+#include "partition_alloc/partition_alloc_base/compiler_specific.h"
 #include "partition_alloc/partition_alloc_base/posix/eintr_wrapper.h"
 
 namespace partition_alloc::internal::base {
 
 bool ReadFromFD(int fd, char* buffer, size_t bytes) {
   size_t total_read = 0;
   while (total_read < bytes) {
-    ssize_t bytes_read =
-        WrapEINTR(read)(fd, buffer + total_read, bytes - total_read);
+    ssize_t bytes_read = WrapEINTR(read)(
+        fd, PA_UNSAFE_TODO(buffer + total_read), bytes - total_read);
     if (bytes_read <= 0) {
       break;
     }

src/partition_alloc/partition_alloc_base/no_destructor_pa_unittest.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include <vector>
 
 #include "partition_alloc/partition_alloc_base/compiler_specific.h"

src/partition_alloc/partition_alloc_base/process/process_handle_posix.cc

@@ -2,11 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
-#pragma allow_unsafe_buffers
-#endif
-
 #include "partition_alloc/partition_alloc_base/process/process_handle.h"
 
 #include <unistd.h>