Skip to content

Commit 21380a2

Browse files
committed
Added illegal argument exception for null
1 parent a2377b0 commit 21380a2

File tree

1 file changed

+43
-38
lines changed

1 file changed

+43
-38
lines changed

src/main/java/mesh/modifier/TranslateModifier.java

Lines changed: 43 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -5,55 +5,60 @@
55

66
public class TranslateModifier implements IMeshModifier {
77

8-
private float deltaX;
8+
private float deltaX;
99

10-
private float deltaY;
10+
private float deltaY;
1111

12-
private float deltaZ;
12+
private float deltaZ;
1313

14-
public TranslateModifier() {
15-
this(0, 0, 0);
16-
}
14+
public TranslateModifier() {
15+
this(0, 0, 0);
16+
}
1717

18-
public TranslateModifier(Vector3f delta) {
19-
this(delta.getX(), delta.getY(), delta.getZ());
20-
}
18+
public TranslateModifier(Vector3f delta) {
19+
if (delta == null)
20+
throw new IllegalArgumentException();
2121

22-
public TranslateModifier(float deltaX, float deltaY, float deltaZ) {
23-
this.deltaX = deltaX;
24-
this.deltaY = deltaY;
25-
this.deltaZ = deltaZ;
26-
}
22+
deltaX = delta.getX();
23+
deltaY = delta.getY();
24+
deltaZ = delta.getZ();
25+
}
2726

28-
@Override
29-
public Mesh3D modify(Mesh3D mesh) {
30-
for (Vector3f v : mesh.vertices)
31-
v.addLocal(deltaX, deltaY, deltaZ);
32-
return mesh;
33-
}
27+
public TranslateModifier(float deltaX, float deltaY, float deltaZ) {
28+
this.deltaX = deltaX;
29+
this.deltaY = deltaY;
30+
this.deltaZ = deltaZ;
31+
}
3432

35-
public float getDeltaX() {
36-
return deltaX;
37-
}
33+
@Override
34+
public Mesh3D modify(Mesh3D mesh) {
35+
for (Vector3f v : mesh.vertices)
36+
v.addLocal(deltaX, deltaY, deltaZ);
37+
return mesh;
38+
}
3839

39-
public void setDeltaX(float deltaX) {
40-
this.deltaX = deltaX;
41-
}
40+
public float getDeltaX() {
41+
return deltaX;
42+
}
4243

43-
public float getDeltaY() {
44-
return deltaY;
45-
}
44+
public void setDeltaX(float deltaX) {
45+
this.deltaX = deltaX;
46+
}
4647

47-
public void setDeltaY(float deltaY) {
48-
this.deltaY = deltaY;
49-
}
48+
public float getDeltaY() {
49+
return deltaY;
50+
}
5051

51-
public float getDeltaZ() {
52-
return deltaZ;
53-
}
52+
public void setDeltaY(float deltaY) {
53+
this.deltaY = deltaY;
54+
}
5455

55-
public void setDeltaZ(float deltaZ) {
56-
this.deltaZ = deltaZ;
57-
}
56+
public float getDeltaZ() {
57+
return deltaZ;
58+
}
59+
60+
public void setDeltaZ(float deltaZ) {
61+
this.deltaZ = deltaZ;
62+
}
5863

5964
}

0 commit comments

Comments
 (0)