Skip to content

Commit ca00aa1

Browse files
committed
Refactoring: Removed translate(Vector3f t) folling refactoring plan
1 parent 51d3561 commit ca00aa1

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

src/main/java/mesh/Mesh3D.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,6 @@ public Mesh3D translate(float tx, float ty, float tz) {
103103
return this;
104104
}
105105

106-
public Mesh3D translate(Vector3f t) {
107-
for (Vector3f v : vertices) {
108-
v.addLocal(t);
109-
}
110-
return this;
111-
}
112-
113106
public Bounds3 calculateBounds() {
114107
if (vertices.isEmpty())
115108
return new Bounds3();

src/main/java/mesh/creator/assets/FlangePipeCreator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import mesh.creator.primitives.CylinderCreator;
1010
import mesh.creator.special.VariableCylinderCreator;
1111
import mesh.modifier.RotateXModifier;
12+
import mesh.modifier.TranslateModifier;
1213

1314
public class FlangePipeCreator implements IMeshCreator {
1415

@@ -145,7 +146,7 @@ private Mesh3D createBoltHeads() {
145146
for (int i = 0; i < boltCount; i++) {
146147
Mesh3D bolt = creator.create();
147148
Vector3f center = circle.getVertexAt(i);
148-
bolt.translate(center);
149+
bolt.apply(new TranslateModifier(center));
149150
bolts.append(bolt);
150151
}
151152

@@ -172,7 +173,7 @@ private void createBoltConnectors() {
172173
for (int i = 0; i < boltCount; i++) {
173174
Mesh3D bolt = creator.create();
174175
Vector3f center = circle.getVertexAt(i);
175-
bolt.translate(center);
176+
bolt.apply(new TranslateModifier(center));
176177
bolt.translateY(-flangeGrooveWidth / 2f);
177178
bolts.append(bolt);
178179
}

src/main/java/mesh/modifier/CenterAtModifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public Mesh3D modify(Mesh3D mesh) {
2222
if (bounds.getCenter().equals(center))
2323
return mesh;
2424
Vector3f distance = center.subtract(bounds.getCenter());
25-
mesh.translate(distance);
25+
mesh.apply(new TranslateModifier(distance));
2626
return mesh;
2727
}
2828

0 commit comments

Comments
 (0)