Fixed Avoid reassigning parameters

ArtifactForms · ArtifactForms · commit e7659fdf5af0 · 2024-11-16T13:18:01.000+01:00
diff --git a/src/main/java/mesh/creator/primitives/ConeCreator.java b/src/main/java/mesh/creator/primitives/ConeCreator.java
@@ -60,8 +60,8 @@ private void addFace(int i, int j) {
     }
 
     private int toOneDimensionalIndex(int i, int j) {
-        j %= rotationSegments;
-        return Mathf.toOneDimensionalIndex(i, j, rotationSegments);
+        int cols = rotationSegments;
+        return Mathf.toOneDimensionalIndex(i, j % cols, cols);
     }
 
     private void createQuadFaces() {

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,8 @@ private void addFace(int i, int j) {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`private int toOneDimensionalIndex(int i, int j) {`
`63`		`- j %= rotationSegments;`
`64`		`- return Mathf.toOneDimensionalIndex(i, j, rotationSegments);`
	`63`	`+ int cols = rotationSegments;`
	`64`	`+ return Mathf.toOneDimensionalIndex(i, j % cols, cols);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`private void createQuadFaces() {`