Skip to content

Commit 3966fd5

Browse files
authored
Merge pull request #36 from rebelinux/dev
v0.6.6
2 parents fbac2a9 + e2a7b38 commit 3966fd5

13 files changed

+226
-122
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 0 additions & 35 deletions
This file was deleted.
Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
name: Bug Report
2+
description: File a bug report
3+
labels: ["bug"]
4+
assignees:
5+
- rebelinux
6+
body:
7+
- type: textarea
8+
id: bug-description
9+
attributes:
10+
label: Bug description
11+
description: >-
12+
Please provide a clear and concise description of the bug.
13+
validations:
14+
required: true
15+
- type: input
16+
id: command-line-input
17+
attributes:
18+
label: Command-line input
19+
description: >-
20+
Please provide the command line input you are using to run AsBuiltReport. Please ensure that you obscure any sensitive information.
21+
placeholder: New-AsBuiltReport -Report NetApp.ONTAP -Target xxxxxxx -Format Word,HTML -OutputFolderPath .\Documents\ -AsBuiltConfigFilePath .\AsBuiltReport\AsBuiltReport.json -ReportConfigFilePath .\AsBuiltReport\AsBuiltReport.NetApp.ONTAP.json -EnableHealthCheck -Verbose
22+
validations:
23+
required: true
24+
- type: textarea
25+
id: steps-to-reproduce
26+
attributes:
27+
label: Steps to reproduce
28+
description: >-
29+
Please provide a detailed list of steps to reproduce the bug.
30+
placeholder: |-
31+
1. ....
32+
2. ....
33+
3. ....
34+
validations:
35+
required: true
36+
- type: textarea
37+
id: expected-behaviour
38+
attributes:
39+
label: Expected behaviour
40+
description: >-
41+
Please provide a clear and concise description of what you expected to happen.
42+
validations:
43+
required: true
44+
- type: textarea
45+
id: screenshots
46+
attributes:
47+
label: Screenshots
48+
description: >-
49+
Please attach any screenshots to help explain the problem. Please ensure that you obscure any sensitive information.
50+
placeholder: |-
51+
Drag and drop screenshots here.
52+
- type: textarea
53+
id: operating-system
54+
attributes:
55+
label: Operating System
56+
description: Please provide information about the operating system are you using.
57+
placeholder: macOS Big Sur, Windows 10, Ubuntu 20.04 LTS
58+
validations:
59+
required: true
60+
- type: textarea
61+
id: powershell-version
62+
attributes:
63+
label: PowerShell Version
64+
description: Please provide information about the PowerShell version you are using. Please provide the output from the following PowerShell command `$PSVersionTable`.
65+
placeholder: $PSVersionTable
66+
validations:
67+
required: true
68+
- type: textarea
69+
id: powershell-modules
70+
attributes:
71+
label: PowerShell Modules
72+
description: Please provide information about the PowerShell modules are you using. Please provide the output from the following PowerShell command `Get-Module -ListAvailable @("AsBuiltReport.Core";"AsBuiltReport.NetApp.ONTAP";"PSPKI";"PScriboCharts";"PScribo") | Select Name, Version`
73+
placeholder: Get-Module -ListAvailable @("AsBuiltReport.Core";"AsBuiltReport.NetApp.ONTAP";"PSPKI";"PScriboCharts";"PScribo") | Select Name, Version
74+
validations:
75+
required: true
76+
- type: textarea
77+
id: additional-context
78+
attributes:
79+
label: Additional Context
80+
description: This field is optional. You may provide additional context for the bug you wish to report. You may wish to include links to any related [issues](https://github.com/AsBuiltReport/AsBuiltReport.NetApp.ONTAP/issues) or other relevant information.
81+
- type: checkboxes
82+
id: checklist
83+
attributes:
84+
label: Before submitting
85+
description: >-
86+
Please ensure your bug report fulfills all of the following requirements.
87+
If you are unsure of what a specific requirement means, please follow the links to learn about it and understand why it is necessary before submitting.
88+
options:
89+
- label: >-
90+
I have read and followed the [bug reporting guidelines](https://www.asbuiltreport.com/about/contributing/#reporting-issues-and-bugs).
91+
required: true
92+
- label: >-
93+
I have read [the documentation](https://www.asbuiltreport.com/user-guide/new-asbuiltconfig),
94+
and referred to the [known issues](https://www.asbuiltreport.com/user-guide/known-issues/) before submitting this bug report.
95+
required: true
96+
- label: >-
97+
I have checked for previously opened & closed [issues](https://github.com/AsBuiltReport/AsBuiltReport.NetApp.ONTAP/issues) before submitting this bug report.
98+
required: true
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
name: Change Request
2+
description: Request a new change or an improvement
3+
labels: ["change request"]
4+
assignees:
5+
- rebelinux
6+
body:
7+
- type: textarea
8+
id: description
9+
attributes:
10+
label: Description
11+
description: >-
12+
Please provide a detailed description of your idea so that the project maintainers and contributors can fully understand what change, feature, or improvement you are proposing.
13+
validations:
14+
required: true
15+
- type: textarea
16+
id: additional-context
17+
attributes:
18+
label: Additional Context
19+
description: This field is optional. You may provide additional context for the idea you wish to propose. You may wish to include links to any related [issues](https://github.com/AsBuiltReport/AsBuiltReport.NetApp.ONTAP/issues) or other relevant information.
20+
- type: checkboxes
21+
id: checklist
22+
attributes:
23+
label: Before submitting
24+
description: >-
25+
Please ensure your change request fulfills all of the following requirements.
26+
If you are unsure of what a specific requirement means, please follow the links to learn about it and understand why it is necessary before submitting.
27+
options:
28+
- label: >-
29+
I have read [the documentation](https://www.asbuiltreport.com/user-guide/new-asbuiltconfig),
30+
and referred to the [known issues](https://www.asbuiltreport.com/user-guide/known-issues/) before submitting this change request.
31+
required: true
32+
- label: >-
33+
I have checked for previously opened & closed [issues](https://github.com/AsBuiltReport/AsBuiltReport.NetApp.ONTAP/issues) before submitting this change request.
34+
required: true

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
blank_issues_enabled: false

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 0 additions & 17 deletions
This file was deleted.

.github/workflows/Release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
publish-to-gallery:
99
runs-on: ubuntu-latest
1010
steps:
11-
- uses: actions/checkout@v2
11+
- uses: actions/checkout@v3
1212
- name: Set PSRepository to Trusted for PowerShell Gallery
1313
shell: pwsh
1414
run: |

AsBuiltReport.NetApp.ONTAP.Style.ps1

Lines changed: 29 additions & 27 deletions
Large diffs are not rendered by default.

AsBuiltReport.NetApp.ONTAP.psd1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
RootModule = 'AsBuiltReport.NetApp.ONTAP.psm1'
1313

1414
# Version number of this module.
15-
ModuleVersion = '0.6.5'
15+
ModuleVersion = '0.6.6'
1616

1717
# Supported PSEditions
1818
# CompatiblePSEditions = @()
@@ -27,7 +27,7 @@ Author = 'Jonathan Colon Feliciano'
2727
#CompanyName = 'Unknown'
2828

2929
# Copyright statement for this module
30-
Copyright = '(c) 2022 Jonathan Colon Feliciano. All rights reserved.'
30+
Copyright = '(c) 2023 Jonathan Colon Feliciano. All rights reserved.'
3131

3232
# Description of the functionality provided by this module
3333
Description = 'A PowerShell module to generate an as built report on the configuration of NetApp ONTAP.'
@@ -54,7 +54,7 @@ Description = 'A PowerShell module to generate an as built report on the configu
5454
RequiredModules = @(
5555
@{
5656
ModuleName = 'AsBuiltReport.Core';
57-
ModuleVersion = '1.2.0'
57+
ModuleVersion = '1.3.0'
5858
},
5959
@{
6060
ModuleName = 'NetApp.ONTAP';

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
11
# :arrows_counterclockwise: NetApp ONTAP Storage As Built Report Changelog
22

3+
## [0.6.6] - 2023-08-07
4+
5+
### Changed
6+
7+
- Improved bug and feature request templates
8+
- Changed default logo from NetApp to the AsBuiltReport logo due to licensing requirements
9+
- Changed default report style font to 'Segoe Ui'
10+
- Changed Required Modules to AsBuiltReport.Core v1.3.0
11+
12+
### Fixed
13+
14+
- Fix [#35](https://github.com/AsBuiltReport/AsBuiltReport.NetApp.ONTAP/issues/35)
15+
316
## [0.6.5] - 2022-11-06
417

518
### Added

Src/Private/Get-AbrOntapClusterHA.ps1

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function Get-AbrOntapClusterHA {
55
.DESCRIPTION
66
77
.NOTES
8-
Version: 0.6.3
8+
Version: 0.6.6
99
Author: Jonathan Colon
1010
Twitter: @jcolonfzenpr
1111
Github: rebelinux
@@ -31,9 +31,17 @@ function Get-AbrOntapClusterHA {
3131
$ClusterHa = Get-NcClusterHa -Node $Nodes.Node -Controller $Array
3232
[PSCustomObject] @{
3333
'Name' = $Nodes.Node
34-
'Partner' = $ClusterHa.Partner
34+
'Partner' = Switch ([string]::IsNullOrEmpty($ClusterHa.Partner)) {
35+
'True' {'-'}
36+
'False' {$ClusterHa.Partner}
37+
default {'Unknwon'}
38+
}
3539
'TakeOver Possible' = ConvertTo-TextYN $ClusterHa.TakeoverPossible
36-
'TakeOver State' = $ClusterHa.TakeoverState
40+
'TakeOver State' = Switch ([string]::IsNullOrEmpty($ClusterHa.TakeoverState)) {
41+
'True' {'-'}
42+
'False' {$ClusterHa.TakeoverState}
43+
default {'Unknwon'}
44+
}
3745
'HA Mode' = $ClusterHa.CurrentMode.ToUpper()
3846
'HA State' = $ClusterHa.State.ToUpper()
3947
}

0 commit comments

Comments
 (0)