Skip to content

Commit 8794a27

Browse files
rebelinuxrebelinux
authored
Merge pull request #66 from rebelinux/dev
Remove PWSH v5.1 - WIP
2 parents 5fd7033 + 64e9eed commit 8794a27

File tree

164 files changed

+1937
-1604
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

164 files changed

+1937
-1604
lines changed

‎.github/workflows/PSScriptAnalyzer.yml‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
name: PSScriptAnalyzer
22
on: [push, pull_request]
33
jobs:
4-
lint:
5-
name: Run PSScriptAnalyzer
6-
runs-on: ubuntu-latest
7-
steps:
8-
- uses: actions/checkout@v5
9-
- name: lint
10-
uses: devblackops/github-action-psscriptanalyzer@master
11-
with:
12-
sendComment: true
13-
failOnErrors: true
14-
failOnWarnings: false
15-
failOnInfos: false
16-
repoToken: ${{ secrets.GITHUB_TOKEN }}
17-
settingsPath: .github/workflows/PSScriptAnalyzerSettings.psd1
4+
lint:
5+
name: Run PSScriptAnalyzer
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: actions/checkout@v5
9+
- name: lint
10+
uses: alagoutte/github-action-psscriptanalyzer@master
11+
with:
12+
sendComment: true
13+
failOnErrors: true
14+
failOnWarnings: false
15+
failOnInfos: false
16+
repoToken: ${{ secrets.GITHUB_TOKEN }}
17+
settingsPath: .github/workflows/PSScriptAnalyzerSettings.psd1

‎.github/workflows/Release.yml‎

Lines changed: 56 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,61 @@
11
name: Publish PowerShell Module
22

33
on:
4-
release:
5-
types: [published]
4+
release:
5+
types: [published]
66

77
jobs:
8-
publish-to-gallery:
9-
runs-on: ubuntu-latest
10-
steps:
11-
- uses: actions/checkout@v5
12-
- name: Set PSRepository to Trusted for PowerShell Gallery
13-
shell: pwsh
14-
run: |
15-
Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
16-
- name: Install AsBuiltReport.Core module
17-
shell: pwsh
18-
run: |
19-
Install-Module -Name AsBuiltReport.Core -Repository PSGallery -Force
20-
- name: Install NetApp.ONTAP module
21-
shell: pwsh
22-
run: |
23-
Install-Module -Name NetApp.ONTAP -Repository PSGallery -Force
24-
- name: Install Diagrammer.Core module
25-
shell: pwsh
26-
run: |
27-
Install-Module -Name Diagrammer.Core -Repository PSGallery -Force
28-
- name: Test Module Manifest
29-
shell: pwsh
30-
run: |
31-
Test-ModuleManifest .\AsBuiltReport.NetApp.ONTAP.psd1
32-
- name: Publish module to PowerShell Gallery
33-
shell: pwsh
34-
run: |
35-
Publish-Module -Path ./ -NuGetApiKey ${{ secrets.PSGALLERY_API_KEY }} -Verbose
36-
tweet:
37-
needs: publish-to-gallery
38-
runs-on: ubuntu-latest
39-
steps:
40-
- uses: Eomm/why-don-t-you-tweet@v2
41-
# We don't want to tweet if the repository is not a public one
42-
if: ${{ !github.event.repository.private }}
43-
with:
44-
# GitHub event payload
45-
# https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
46-
tweet-message: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Netapp #AsBuiltReport #PowerShell #Ontap #NetAppATeam"
47-
env:
48-
TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }}
49-
TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }}
50-
TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
51-
TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
52-
bsky-post:
53-
needs: publish-to-gallery
54-
runs-on: ubuntu-latest
55-
steps:
56-
- uses: zentered/[email protected]
57-
with:
58-
post: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Netapp #AsBuiltReport #PowerShell #Ontap #NetAppATeam"
59-
env:
60-
BSKY_IDENTIFIER: ${{ secrets.BSKY_IDENTIFIER }}
61-
BSKY_PASSWORD: ${{ secrets.BSKY_PASSWORD }}
8+
publish-to-gallery:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v5
12+
- name: Set PSRepository to Trusted for PowerShell Gallery
13+
shell: pwsh
14+
run: |
15+
Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
16+
- name: Install AsBuiltReport.Core module
17+
shell: pwsh
18+
run: |
19+
Install-Module -Name AsBuiltReport.Core -Repository PSGallery -Force
20+
- name: Install NetApp.ONTAP module
21+
shell: pwsh
22+
run: |
23+
Install-Module -Name NetApp.ONTAP -Repository PSGallery -Force
24+
- name: Install Diagrammer.Core module
25+
shell: pwsh
26+
run: |
27+
Install-Module -Name Diagrammer.Core -Repository PSGallery -Force
28+
- name: Test Module Manifest
29+
shell: pwsh
30+
run: |
31+
Test-ModuleManifest .\AsBuiltReport.NetApp.ONTAP.psd1
32+
- name: Publish module to PowerShell Gallery
33+
shell: pwsh
34+
run: |
35+
Publish-Module -Path ./ -NuGetApiKey ${{ secrets.PSGALLERY_API_KEY }} -Verbose
36+
tweet:
37+
needs: publish-to-gallery
38+
runs-on: ubuntu-latest
39+
steps:
40+
- uses: Eomm/why-don-t-you-tweet@v2
41+
# We don't want to tweet if the repository is not a public one
42+
if: ${{ !github.event.repository.private }}
43+
with:
44+
# GitHub event payload
45+
# https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
46+
tweet-message: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Netapp #AsBuiltReport #PowerShell #Ontap #NetAppATeam"
47+
env:
48+
TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }}
49+
TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }}
50+
TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
51+
TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
52+
bsky-post:
53+
needs: publish-to-gallery
54+
runs-on: ubuntu-latest
55+
steps:
56+
- uses: zentered/[email protected]
57+
with:
58+
post: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Netapp #AsBuiltReport #PowerShell #Ontap #NetAppATeam"
59+
env:
60+
BSKY_IDENTIFIER: ${{ secrets.BSKY_IDENTIFIER }}
61+
BSKY_PASSWORD: ${{ secrets.BSKY_PASSWORD }}

‎.github/workflows/codeql.yml‎

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -10,40 +10,40 @@
1010
name: CodeQL
1111

1212
on:
13-
push:
14-
branches: [ "dev" ]
15-
pull_request:
16-
branches: [ "dev" ]
17-
schedule:
18-
- cron: '20 14 * * 1'
13+
push:
14+
branches: ["dev"]
15+
pull_request:
16+
branches: ["dev"]
17+
schedule:
18+
- cron: "20 14 * * 1"
1919

2020
permissions:
21-
contents: read
21+
contents: read
2222

2323
jobs:
24-
build:
25-
permissions:
26-
contents: read # for actions/checkout to fetch code
27-
security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
28-
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
29-
name: PSScriptAnalyzer
30-
runs-on: ubuntu-latest
31-
steps:
32-
- uses: actions/checkout@v5
24+
build:
25+
permissions:
26+
contents: read # for actions/checkout to fetch code
27+
security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
28+
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
29+
name: PSScriptAnalyzer
30+
runs-on: ubuntu-latest
31+
steps:
32+
- uses: actions/checkout@v5
3333

34-
- name: Run PSScriptAnalyzer
35-
uses: microsoft/[email protected]
36-
with:
37-
# Check https://github.com/microsoft/action-psscriptanalyzer for more info about the options.
38-
# The below set up runs PSScriptAnalyzer to your entire repository and runs some basic security rules.
39-
path: .\
40-
recurse: true
41-
# Include your own basic security rules. Removing this option will run all the rules
42-
excludeRule: '"PSAvoidUsingPlainTextForPassword", "PSAvoidUsingUsernameAndPasswordParams", "PSAvoidUsingConvertToSecureStringWithPlainText"'
43-
output: results.sarif
34+
- name: Run PSScriptAnalyzer
35+
uses: microsoft/[email protected]
36+
with:
37+
# Check https://github.com/microsoft/action-psscriptanalyzer for more info about the options.
38+
# The below set up runs PSScriptAnalyzer to your entire repository and runs some basic security rules.
39+
path: .\
40+
recurse: true
41+
# Include your own basic security rules. Removing this option will run all the rules
42+
excludeRule: '"PSAvoidUsingPlainTextForPassword", "PSAvoidUsingUsernameAndPasswordParams", "PSAvoidUsingConvertToSecureStringWithPlainText"'
43+
output: results.sarif
4444

45-
# Upload the SARIF file generated in the previous step
46-
- name: Upload SARIF results file
47-
uses: github/codeql-action/upload-sarif@v3
48-
with:
49-
sarif_file: results.sarif
45+
# Upload the SARIF file generated in the previous step
46+
- name: Upload SARIF results file
47+
uses: github/codeql-action/upload-sarif@v3
48+
with:
49+
sarif_file: results.sarif

‎AsBuiltReport.NetApp.ONTAP.Style.ps1‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎AsBuiltReport.NetApp.ONTAP.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"EnableDiagramSignature": false,
2626
"DiagramColumnSize": 4,
2727
"SignatureAuthorName": "",
28-
"SignatureCompanyName": ""
28+
"SignatureCompanyName": "",
29+
"UpdateCheck": true
2930
},
3031
"InfoLevel": {
3132
"_comment_": "0 = Disabled, 1 = Enabled, 2 = Adv Summary",

‎AsBuiltReport.NetApp.ONTAP.psd1‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
RootModule = 'AsBuiltReport.NetApp.ONTAP.psm1'
1313

1414
# Version number of this module.
15-
ModuleVersion = '0.6.11'
15+
ModuleVersion = '0.6.12'
1616

1717
# Supported PSEditions
1818
# CompatiblePSEditions = @()
@@ -54,15 +54,15 @@
5454
RequiredModules = @(
5555
@{
5656
ModuleName = 'AsBuiltReport.Core';
57-
ModuleVersion = '1.5.0'
57+
ModuleVersion = '1.5.1'
5858
},
5959
@{
6060
ModuleName = 'NetApp.ONTAP';
6161
ModuleVersion = '9.17.1.2509'
6262
},
6363
@{
6464
ModuleName = 'Diagrammer.Core';
65-
ModuleVersion = '0.2.33'
65+
ModuleVersion = '0.2.36'
6666
}
6767
)
6868

‎AsBuiltReport.NetApp.ONTAP.psm1‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,31 @@
1+
# Get assemblies files and import them
2+
$assemblyName = switch ($PSVersionTable.PSEdition) {
3+
'Core' {
4+
if ($IsMacOS) {
5+
@(Get-ChildItem -Path ("$PSScriptRoot{0}Src{0}Bin{0}Assemblies{0}net90{0}osx-x64{0}*.dll" -f [System.IO.Path]::DirectorySeparatorChar) -ErrorAction SilentlyContinue)
6+
} elseif ($IsLinux) {
7+
@(Get-ChildItem -Path ("$PSScriptRoot{0}Src{0}Bin{0}Assemblies{0}net90{0}linux-x64{0}*.dll" -f [System.IO.Path]::DirectorySeparatorChar) -ErrorAction SilentlyContinue)
8+
} elseif ($IsWindows) {
9+
@(Get-ChildItem -Path ("$PSScriptRoot{0}Src{0}Bin{0}Assemblies{0}net90{0}win-x64{0}*.dll" -f [System.IO.Path]::DirectorySeparatorChar) -ErrorAction SilentlyContinue)
10+
}
11+
}
12+
'Desktop' {
13+
@(Get-ChildItem -Path ("$PSScriptRoot{0}Src{0}Bin{0}Assemblies{0}net48{0}*.dll" -f [System.IO.Path]::DirectorySeparatorChar) -ErrorAction SilentlyContinue)
14+
}
15+
default {
16+
Write-Verbose -Message 'Unable to find compatible assemblies.'
17+
}
18+
}
19+
20+
foreach ($Assembly in $assemblyName) {
21+
try {
22+
Write-Verbose -Message "Loading assembly '$($Assembly.Name)'."
23+
Add-Type -Path $Assembly.FullName -Verbose
24+
} catch {
25+
Write-Error -Message "Failed to add assembly $($Assembly.FullName): $_"
26+
}
27+
}
28+
129
# Get public and private function definition files and dot source them
230
$Public = @(Get-ChildItem -Path $PSScriptRoot\Src\Public\*.ps1 -ErrorAction SilentlyContinue)
331
$Private = @(Get-ChildItem -Path $PSScriptRoot\Src\Private\*.ps1 -ErrorAction SilentlyContinue)

‎CHANGELOG.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,35 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.6.12] - Unreleased
9+
10+
### Added
11+
12+
- Add Health Check best practices for Network Broadcast Domains
13+
- Add Health Check best practices for NTP configuration
14+
- Recommend multiple NTP servers for redundancy
15+
- Add Per Volume export policy information
16+
- Add `Node Name` to FCP Interfaces section in FCP Vserver configuration
17+
- Apply powershell best practices
18+
- Add ConvertTo-HashToYN function
19+
- Add EMS configuration setting health check
20+
21+
### Changed
22+
23+
- Bump Diagrammer.Core module requirement to v0.2.36
24+
- Bump module version to v0.6.12
25+
26+
### Fixed
27+
28+
- Fix snapshot reserve space health check to use correct calculation method
29+
- Enhance Get-AbrOntapNodesSP function with detailed service-processor information
30+
- Fix model property assignment in Get-AbrOntapStorageAggrDiagram function
31+
- Fix Volume SnapShot Configuration section showing healthcheck for non violated item
32+
33+
### Removed
34+
35+
- Removed Pwsh v5.1 support
36+
837
## [0.6.11] - 2025-11-07
938

1039
### Added

‎Src/Bin/Assemblies/net90/linux-x64/AsBuiltReportChart.dll‎

4 KB
Binary file not shown.

‎Src/Bin/Assemblies/net90/linux-x64/HarfBuzzSharp.dll‎

120 KB
Binary file not shown.

0 commit comments

Comments
 (0)